Florian Hahn fbcf8a8cbb [ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262) ...

The constraint system used for ConstraintElimination assumes all
varibles to be signed. This can cause missed optimization in the
unsigned system, due to missing the information that all variables are
unsigned (non-negative).

Variables can be marked as non-negative by adding Var >= 0 for all
variables. This is done for arguments on ConstraintInfo construction and
after adding new variables. This handles cases like the ones outlined in
https://discourse.llvm.org/t/why-does-llvm-not-perform-range-analysis-on-integer-values/74341

The original example shared above is now handled without this change,
but adding another variable means that instcombine won't be able to
simplify examples like https://godbolt.org/z/hTnra7zdY

Adding the extra variables comes with a slight compile-time increase
https://llvm-compile-time-tracker.com/compare.php?from=7568b36a2bc1a1e496ec29246966ffdfc3a8b87f&to=641a47f0acce7755e340447386013a2e086f03d9&stat=instructions:u

stage1-O3    stage1-ReleaseThinLTO    stage1-ReleaseLTO-g  stage1-O0-g
 +0.04%           +0.07%                   +0.05%           +0.02%
stage2-O3    stage2-O0-g    stage2-clang
  +0.05%         +0.05%        +0.05%

https://github.com/llvm/llvm-project/pull/76262

2023-12-23 15:53:48 +01:00

..

ADCE.cpp

[DebugInfo][RemoveDIs] Make dropping variable locations explicit (#72399)

2023-11-21 00:01:00 +00:00

AlignmentFromAssumptions.cpp

AlignmentFromAssumptions should only track pointer operand users (#73370)

2023-12-07 17:35:35 +01:00

AnnotationRemarks.cpp

…

BDCE.cpp

…

CallSiteSplitting.cpp

Reapply 34cdc91321 (#74455), call-site-splitting for RemoveDIs

2023-12-06 16:52:10 +00:00

CMakeLists.txt

[InferAlignment] Implement InferAlignmentPass

2023-09-20 12:03:36 +05:30

ConstantHoisting.cpp

[LLVM][IR] Replace ConstantInt's specialisation of getType() with getIntegerType(). (#75217)

2023-12-18 11:58:42 +00:00

ConstraintElimination.cpp

[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)

2023-12-23 15:53:48 +01:00

CorrelatedValuePropagation.cpp

[CVP] Fix #76058: missing debug location in processSDiv function (#76118)

2023-12-22 09:26:32 +01:00

DCE.cpp

[NewPM] Remove Legacy RedudantDbgInstEliminationPass (#73405)

2023-11-25 15:42:55 -08:00

DeadStoreElimination.cpp

[NFC][DSE] Fix typo comment in eliminateDeadStores (#75166)

2023-12-12 11:13:40 +00:00

DFAJumpThreading.cpp

[Transforms] Use {DenseMap,SmallPtrSet}::contains (NFC)

2023-12-22 14:51:22 -08:00

DivRemPairs.cpp

…

EarlyCSE.cpp

[EarlyCSE] Support CSE for commutative intrinsics with over 2 args (#67255)

2023-09-24 21:23:00 +08:00

FlattenCFGPass.cpp

…

Float2Int.cpp

…

GuardWidening.cpp

[DebugInfo][RemoveDIs] Have getInsertionPtAfterDef return an iterator (#73149)

2023-11-30 12:19:57 +00:00

GVN.cpp

[Transforms] Use {DenseMap,SmallPtrSet}::contains (NFC)

2023-12-22 14:51:22 -08:00

GVNHoist.cpp

…

GVNSink.cpp

[NFC][RemoveDIs] Prefer iterator-insertion over instructions

2023-09-11 11:48:45 +01:00

InductiveRangeCheckElimination.cpp

[Transforms] Remove unnecessary includes (NFC)

2023-12-09 18:23:06 -08:00

IndVarSimplify.cpp

[IndVars] Check expansion safety during LFTR

2023-09-21 14:22:01 +02:00

InferAddressSpaces.cpp

[InferAddressSpaces] Fix constant replace to avoid modifying other functions (#70611)

2023-11-13 13:28:56 +08:00

InferAlignment.cpp

[InferAlignment] Implement InferAlignmentPass

2023-09-20 12:03:36 +05:30

InstSimplifyPass.cpp

…

IVUsersPrinter.cpp

…

JumpThreading.cpp

[DebugInfo][RemoveDIs] Handle DPValues at remaining dbg.value using sites (#73788)

2023-11-30 16:30:32 +00:00

LICM.cpp

[DebugInfo][RemoveDIs] Switch some insertion routines to use iterators (#75330)

2023-12-13 14:04:35 +00:00

LoopAccessAnalysisPrinter.cpp

update_analyze_test_checks: support output from LAA (#67584)

2023-10-31 14:33:53 +00:00

LoopBoundSplit.cpp

[NFC][RemoveDIs] Use iterators over inst-pointers when using IRBuilder

2023-09-11 20:01:19 +01:00

LoopDataPrefetch.cpp

[NFC] Remove Type::getInt8PtrTy (#71029)

2023-11-07 17:26:26 +01:00

LoopDeletion.cpp

…

LoopDistribute.cpp

[LoopDist] Update the pragma info of loop distribute, NFC (#69825)

2023-10-28 17:47:46 +08:00

LoopFlatten.cpp

[LLVM][IR] Replace ConstantInt's specialisation of getType() with getIntegerType(). (#75217)

2023-12-18 11:58:42 +00:00

LoopFuse.cpp

[NFC][RemoveDIs] Prefer iterator-insertion over instructions

2023-09-11 11:48:45 +01:00

LoopIdiomRecognize.cpp

[DebugInfo][RemoveDIs] Have getInsertionPtAfterDef return an iterator (#73149)

2023-11-30 12:19:57 +00:00

LoopInstSimplify.cpp

[NewPM] Remove LoopInstSimplifyLegacyPass (#72812)

2023-11-20 01:00:08 -08:00

LoopInterchange.cpp

[NFC][RemoveDIs] Create a new spelling of the moveBefore method

2023-09-07 18:37:57 +01:00

LoopLoadElimination.cpp

[LAA] Check if dependencies access loop-varying underlying objects.

2023-11-15 21:58:57 +00:00

LoopPassManager.cpp

[LPM] Set gen_crash_diag=false for non-MSSA pass in MSSA pipeline

2023-11-30 10:21:35 +01:00

LoopPredication.cpp

[NewPM] Remove LoopPredicationLegacyPass (#72944)

2023-11-21 00:52:46 -08:00

LoopRerollPass.cpp

…

LoopRotation.cpp

…

LoopSimplifyCFG.cpp

[NewPM] Remove LoopSimplifyCFGLegacyPass (#72930)

2023-11-21 00:51:24 -08:00

LoopSink.cpp

[NewPM] Remove LoopSinkLegacy Pass (#72811)

2023-11-20 00:59:42 -08:00

LoopStrengthReduce.cpp

[BBUtils][NFC] Delete SplitLandingPadPredecessors with DT (#73406)

2023-12-02 11:33:43 -08:00

LoopUnrollAndJamPass.cpp

[Transforms] Use StringRef::starts_with/ends_with instead of startswith/endswith. NFC.

2023-11-06 16:50:18 +00:00

LoopUnrollPass.cpp

[LoopUnroll] Make UnrollMaxUpperBound to be overridable by target (#76029)

2023-12-21 09:47:46 +01:00

LoopVersioningLICM.cpp

[LoopVersioningLICM] add comment regarding dubious check (NFC)

2023-12-13 12:20:08 +01:00

LowerAtomicPass.cpp

…

LowerConstantIntrinsics.cpp

…

LowerExpectIntrinsic.cpp

Add setBranchWeigths convenience function. NFC (#72446)

2023-11-16 10:55:19 -08:00

LowerGuardIntrinsic.cpp

…

LowerMatrixIntrinsics.cpp

[Transforms] Include llvm/ADT/SmallSet.h (NFC)

2023-11-11 12:25:39 -08:00

LowerWidenableCondition.cpp

[NewPM] Remove LowerWidenableConditionLegacyPass (#72818)

2023-11-20 01:03:10 -08:00

MakeGuardsExplicit.cpp

[NewPM] Remove MakeGuardsExplicitLegacyPass (#72946)

2023-11-21 00:53:01 -08:00

MemCpyOptimizer.cpp

[MemCpyOpt] Don't perform call slot opt if alloc type is scalable (#75027)

2023-12-11 19:45:13 +08:00

MergedLoadStoreMotion.cpp

[NewPM] Remove MergedLoadStoreMotionLegacyPass (#72813)

2023-11-20 01:00:24 -08:00

MergeICmps.cpp

[NFC][RemoveDIs] Create a new spelling of the moveBefore method

2023-09-07 18:37:57 +01:00

NaryReassociate.cpp

[ValueTracking] Convert isKnownNonNegative() to use SimplifyQuery (NFC)

2023-11-29 10:52:52 +01:00

NewGVN.cpp

[NewGVN] Patch replacement instruction even for removed instructions

2023-09-28 11:45:19 +02:00

PartiallyInlineLibCalls.cpp

…

PlaceSafepoints.cpp

…

Reassociate.cpp

[Reassociate] Preserve NUW flags after expr tree rewriting (#72360)

2023-12-09 16:45:48 +08:00

Reg2Mem.cpp

[NewPM] Remove Reg2Mem Legacy Pass (#73404)

2023-11-25 15:38:10 -08:00

RewriteStatepointsForGC.cpp

[Transforms] Use {DenseMap,SmallPtrSet}::contains (NFC)

2023-12-22 14:51:22 -08:00

Scalar.cpp

[NewPM] Remove Legacy RedudantDbgInstEliminationPass (#73405)

2023-11-25 15:42:55 -08:00

ScalarizeMaskedMemIntrin.cpp

…

Scalarizer.cpp

[NewPM] Remove ScalarizerLegacyPass (#72814)

2023-11-20 01:09:27 -08:00

SCCP.cpp

[Transforms] Remove unnecessary includes (NFC)

2023-12-09 18:23:06 -08:00

SeparateConstOffsetFromGEP.cpp

[SeparateConstOffsetFromGEP] Avoid use of ConstantExpr::getCast()

2023-11-02 09:39:48 +01:00

SimpleLoopUnswitch.cpp

[SimpleLoopUnswitch] Remove callbacks (#73300)

2023-11-24 11:36:52 -08:00

SimplifyCFGPass.cpp

…

Sink.cpp

[Sink] Fix bugs of sinking unreachable BB from phi (#68576)

2023-10-09 22:34:44 +08:00

SpeculativeExecution.cpp

[SpeculativeExecution] Add only-if-divergent-target pass option

2023-11-07 11:49:37 +01:00

SROA.cpp

[SROA] Use memcpy if type size does not match store size

2023-12-22 10:19:22 +01:00

StraightLineStrengthReduce.cpp

[NFC] Remove Type::getInt8PtrTy (#71029)

2023-11-07 17:26:26 +01:00

StructurizeCFG.cpp

[LowerSwitch] Don't let pass manager handle the dependency (#68662)

2023-10-25 09:24:36 +08:00

TailRecursionElimination.cpp

[IR][TRE] Support associative intrinsics (#74226)

2023-12-04 22:35:59 -08:00

TLSVariableHoist.cpp

[llvm] Stop including tuple (NFC)

2023-12-03 23:01:26 -08:00

WarnMissedTransforms.cpp

…