caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
1daf2994de49d1ecba4bee4e6842aa8a564cbc96
clang-p2996/llvm/test/Transforms/ConstraintElimination
History
Florian Hahn fbcf8a8cbb [ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262) 
The constraint system used for ConstraintElimination assumes all
varibles to be signed. This can cause missed optimization in the
unsigned system, due to missing the information that all variables are
unsigned (non-negative).

Variables can be marked as non-negative by adding Var >= 0 for all
variables. This is done for arguments on ConstraintInfo construction and
after adding new variables. This handles cases like the ones outlined in
https://discourse.llvm.org/t/why-does-llvm-not-perform-range-analysis-on-integer-values/74341

The original example shared above is now handled without this change,
but adding another variable means that instcombine won't be able to
simplify examples like https://godbolt.org/z/hTnra7zdY

Adding the extra variables comes with a slight compile-time increase
https://llvm-compile-time-tracker.com/compare.php?from=7568b36a2bc1a1e496ec29246966ffdfc3a8b87f&to=641a47f0acce7755e340447386013a2e086f03d9&stat=instructions:u

stage1-O3    stage1-ReleaseThinLTO    stage1-ReleaseLTO-g  stage1-O0-g
 +0.04%           +0.07%                   +0.05%           +0.02%
stage2-O3    stage2-O0-g    stage2-clang
  +0.05%         +0.05%        +0.05%

https://github.com/llvm/llvm-project/pull/76262
2023-12-23 15:53:48 +01:00
..
add-nsw.ll
[ConstraintElim] Handle trivial (ICMP_ULE, 0, B) in doesHold.
2023-09-27 12:11:28 +01:00
add-nuw.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
add.ll
…
analysis-invalidation.ll
[ConstraintElim] Add A < B if A is an increasing phi for A != B.
2023-09-27 11:00:28 +01:00
and-implied-by-operands.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
and.ll
[ConstraintElim] Check if second op implies first for And. (#75750)
2023-12-20 11:58:35 +01:00
assumes.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
cond-used-in-phi.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
constants-signed-predicates.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
constants-unsigned-predicates.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
debug.ll
[ConstraintElim] Refactor checkCondition. NFC. (#75319)
2023-12-13 23:20:01 +08:00
decompose-with-temporary-indices.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
dom.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
empty-constraint.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
eq.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
gep-add-multiple-indices-signed-predicates.ll
…
gep-add-multiple-indices.ll
[ConstraintElim] Refactor GEP offset collection.
2023-11-27 09:05:58 +00:00
gep-arithmetic-add-signed-predicates.ll
…
gep-arithmetic-add.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
gep-arithmetic-different-types.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
gep-arithmetic-signed-predicates.ll
[ConstraintElim] Extend AND implication logic to support OR as well. (#76044)
2023-12-20 18:13:41 +01:00
gep-arithmetic.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
gep-chains.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
gep-constexpr.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
gep-sub-signed-predicates.ll
…
gep-sub.ll
[ConstraintElim] Refactor GEP offset collection.
2023-11-27 09:05:58 +00:00
geps-128-bit-pointers.ll
…
geps-i32-pointer-indexes.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
geps-inbounds-precondition-ub-in-use-blocks.ll
…
geps-inbounds-precondition.ll
…
geps-pointers-to-arrays.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
geps-pointers-to-structs.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
geps-precondition-overflow-check.ll
[ConstraintElim] Extend AND implication logic to support OR as well. (#76044)
2023-12-20 18:13:41 +01:00
geps-ptrvector.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
geps-signed-predicates.ll
…
geps-unsigned-predicates.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
invoke.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
large-constant-ints.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
large-system-growth.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
loops-bottom-tested-base.ll
[ConstraintElim] Add bottom tested loops with EQ predicates.
2023-08-17 11:09:19 +01:00
loops-bottom-tested-pointer-cmps.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
loops-header-tested-base.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
loops-header-tested-pointer-cmps.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
loops-header-tested-pointer-iv.ll
[ConstraintElim] Handle trivial (ICMP_ULE, 0, B) in doesHold.
2023-09-27 12:11:28 +01:00
loops.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
max-row-limit.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
minmax.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
mixed-signed-unsigned-predicates.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
mixed.ll
…
monotonic-int-phis-cfg.ll
[ConstraintElim] Handle trivial (ICMP_ULE, 0, B) in doesHold.
2023-09-27 12:11:28 +01:00
monotonic-int-phis-decrement.ll
[ConstraintElim] Support decrementing inductions with step -1. (#68644)
2023-10-10 09:37:27 -07:00
monotonic-int-phis-nested-loops.ll
[ConstraintElim] Support decrementing inductions with step -1. (#68644)
2023-10-10 09:37:27 -07:00
monotonic-int-phis-wrapping.ll
[ConstraintElim] Add A < B if A is an increasing phi for A != B.
2023-09-27 11:00:28 +01:00
monotonic-int-phis.ll
[ConstraintElim] Handle trivial (ICMP_ULE, 0, B) in doesHold.
2023-09-27 12:11:28 +01:00
monotonic-phis-adjacent-loops.ll
[ConstraintElim] Make sure add-rec is for the current loop.
2023-11-08 14:07:28 +00:00
monotonic-pointer-phis-constant-upper-offset.ll
[ConstraintElim] Add A < B if A is an increasing phi for A != B.
2023-09-27 11:00:28 +01:00
monotonic-pointer-phis-crashes.ll
…
monotonic-pointer-phis-custom-datalayout.ll
[ConstraintElim] Add A < B if A is an increasing phi for A != B.
2023-09-27 11:00:28 +01:00
monotonic-pointer-phis-early-exits.ll
[ConstraintElim] Add A < B if A is an increasing phi for A != B.
2023-09-27 11:00:28 +01:00
monotonic-pointer-phis-struct-types.ll
[ConstraintElim] Add A < B if A is an increasing phi for A != B.
2023-09-27 11:00:28 +01:00
monotonic-pointer-phis.ll
[ConstraintElim] Add A < B if A is an increasing phi for A != B.
2023-09-27 11:00:28 +01:00
mul-nsw.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
mul.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
ne.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
or-implied-by-operands.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
or.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
overflows.ll
[ConstraintElim] Add missing checks in test_overflow_in_negate_constraint (#65841)
2023-09-11 02:52:26 +08:00
pointercast.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
pr54228-variable-name-order.ll
…
pr70510.ll
[ConstraintElim] Add missing check to make sure the bound is loop-invariant (#70555)
2023-11-02 23:38:05 +08:00
range_checks.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
reason-about-add-operands.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
reproducer-remarks-debug.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
reproducer-remarks.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
sge.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
shl.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
signed-query-unsigned-system.ll
[ConstraintElimination] Extend unsigned-to-signed fact transfer
2023-09-23 08:54:19 +00:00
ssub-with-overflow.ll
…
sub-nuw.ll
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
2023-12-23 15:53:48 +01:00
sub.ll
…
switch.ll
[ConstraintElim] Support adding facts from switch terminators. (#67061)
2023-09-22 11:18:42 +01:00
transfer-signed-facts-to-unsigned-is-known-non-negative.ll
[ConstraintElim] Use isKnownNonNegative for condition transfer. (#72879)
2023-11-21 10:09:35 +00:00
transfer-signed-facts-to-unsigned.ll
[ConstraintElim] Add extra info transfer tests for #72879.
2023-11-20 22:42:30 +00:00
transfer-unsigned-facts-to-signed-is-known-non-negative.ll
[ConstraintElim] Use isKnownNonNegative for condition transfer. (#72879)
2023-11-21 10:09:35 +00:00
transfer-unsigned-facts-to-signed.ll
[ConstraintElim] Handle trivial (ICMP_ULE, 0, B) in doesHold.
2023-09-27 12:11:28 +01:00
uge.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
ugt-ule.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
ule.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
uses-in-different-blocks.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
usub-with-overflow.ll
[ConstraintElim] Handle trivial (ICMP_ULE, 0, B) in doesHold.
2023-09-27 12:11:28 +01:00
vector-compares.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
wrapping-math.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
zext-for-per-formula-reasoning.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00
zext.ll
[ConstraintElim] Remove dead compares after simplification.
2023-08-24 22:12:57 +01:00