Files
clang-p2996/mlir/lib/Dialect/PDL/IR/PDL.cpp
Tres Popp c1fa60b4cd [mlir] Update method cast calls to function calls
The MLIR classes Type/Attribute/Operation/Op/Value support
cast/dyn_cast/isa/dyn_cast_or_null functionality through llvm's doCast
functionality in addition to defining methods with the same name.
This change begins the migration of uses of the method to the
corresponding function call as has been decided as more consistent.

Note that there still exist classes that only define methods directly,
such as AffineExpr, and this does not include work currently to support
a functional cast/isa call.

Context:

* https://mlir.llvm.org/deprecation/ at "Use the free function variants for dyn_cast/cast/isa/…"
* Original discussion at https://discourse.llvm.org/t/preferred-casting-style-going-forward/68443

Implementation:
This follows a previous patch that updated calls
`op.cast<T>()-> cast<T>(op)`. However some cases could not handle an
unprefixed `cast` call due to occurrences of variables named cast, or
occurring inside of class definitions which would resolve to the method.
All C++ files that did not work automatically with `cast<T>()` are
updated here to `llvm::cast` and similar with the intention that they
can be easily updated after the methods are removed through a
find-replace.

See https://github.com/llvm/llvm-project/compare/main...tpopp:llvm-project:tidy-cast-check
for the clang-tidy check that is used and then update printed
occurrences of the function to include `llvm::` before.

One can then run the following:
```
ninja -C $BUILD_DIR clang-tidy

run-clang-tidy -clang-tidy-binary=$BUILD_DIR/bin/clang-tidy -checks='-*,misc-cast-functions'\
                 -export-fixes /tmp/cast/casts.yaml mlir/*\
                 -header-filter=mlir/ -fix

rm -rf $BUILD_DIR/tools/mlir/**/*.inc
```

Differential Revision: https://reviews.llvm.org/D150348
2023-05-12 11:21:30 +02:00

538 lines
19 KiB
C++

//===- PDL.cpp - Pattern Descriptor Language Dialect ----------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "mlir/Dialect/PDL/IR/PDL.h"
#include "mlir/Dialect/PDL/IR/PDLOps.h"
#include "mlir/Dialect/PDL/IR/PDLTypes.h"
#include "mlir/IR/BuiltinTypes.h"
#include "mlir/Interfaces/InferTypeOpInterface.h"
#include "llvm/ADT/DenseSet.h"
#include "llvm/ADT/TypeSwitch.h"
#include <optional>
using namespace mlir;
using namespace mlir::pdl;
#include "mlir/Dialect/PDL/IR/PDLOpsDialect.cpp.inc"
//===----------------------------------------------------------------------===//
// PDLDialect
//===----------------------------------------------------------------------===//
void PDLDialect::initialize() {
addOperations<
#define GET_OP_LIST
#include "mlir/Dialect/PDL/IR/PDLOps.cpp.inc"
>();
registerTypes();
}
//===----------------------------------------------------------------------===//
// PDL Operations
//===----------------------------------------------------------------------===//
/// Returns true if the given operation is used by a "binding" pdl operation.
static bool hasBindingUse(Operation *op) {
for (Operation *user : op->getUsers())
// A result by itself is not binding, it must also be bound.
if (!isa<ResultOp, ResultsOp>(user) || hasBindingUse(user))
return true;
return false;
}
/// Returns success if the given operation is not in the main matcher body or
/// is used by a "binding" operation. On failure, emits an error.
static LogicalResult verifyHasBindingUse(Operation *op) {
// If the parent is not a pattern, there is nothing to do.
if (!llvm::isa_and_nonnull<PatternOp>(op->getParentOp()))
return success();
if (hasBindingUse(op))
return success();
return op->emitOpError(
"expected a bindable user when defined in the matcher body of a "
"`pdl.pattern`");
}
/// Visits all the pdl.operand(s), pdl.result(s), and pdl.operation(s)
/// connected to the given operation.
static void visit(Operation *op, DenseSet<Operation *> &visited) {
// If the parent is not a pattern, there is nothing to do.
if (!isa<PatternOp>(op->getParentOp()) || isa<RewriteOp>(op))
return;
// Ignore if already visited.
if (visited.contains(op))
return;
// Mark as visited.
visited.insert(op);
// Traverse the operands / parent.
TypeSwitch<Operation *>(op)
.Case<OperationOp>([&visited](auto operation) {
for (Value operand : operation.getOperandValues())
visit(operand.getDefiningOp(), visited);
})
.Case<ResultOp, ResultsOp>([&visited](auto result) {
visit(result.getParent().getDefiningOp(), visited);
});
// Traverse the users.
for (Operation *user : op->getUsers())
visit(user, visited);
}
//===----------------------------------------------------------------------===//
// pdl::ApplyNativeConstraintOp
//===----------------------------------------------------------------------===//
LogicalResult ApplyNativeConstraintOp::verify() {
if (getNumOperands() == 0)
return emitOpError("expected at least one argument");
return success();
}
//===----------------------------------------------------------------------===//
// pdl::ApplyNativeRewriteOp
//===----------------------------------------------------------------------===//
LogicalResult ApplyNativeRewriteOp::verify() {
if (getNumOperands() == 0 && getNumResults() == 0)
return emitOpError("expected at least one argument or result");
return success();
}
//===----------------------------------------------------------------------===//
// pdl::AttributeOp
//===----------------------------------------------------------------------===//
LogicalResult AttributeOp::verify() {
Value attrType = getValueType();
std::optional<Attribute> attrValue = getValue();
if (!attrValue) {
if (isa<RewriteOp>((*this)->getParentOp()))
return emitOpError(
"expected constant value when specified within a `pdl.rewrite`");
return verifyHasBindingUse(*this);
}
if (attrType)
return emitOpError("expected only one of [`type`, `value`] to be set");
return success();
}
//===----------------------------------------------------------------------===//
// pdl::OperandOp
//===----------------------------------------------------------------------===//
LogicalResult OperandOp::verify() { return verifyHasBindingUse(*this); }
//===----------------------------------------------------------------------===//
// pdl::OperandsOp
//===----------------------------------------------------------------------===//
LogicalResult OperandsOp::verify() { return verifyHasBindingUse(*this); }
//===----------------------------------------------------------------------===//
// pdl::OperationOp
//===----------------------------------------------------------------------===//
static ParseResult parseOperationOpAttributes(
OpAsmParser &p,
SmallVectorImpl<OpAsmParser::UnresolvedOperand> &attrOperands,
ArrayAttr &attrNamesAttr) {
Builder &builder = p.getBuilder();
SmallVector<Attribute, 4> attrNames;
if (succeeded(p.parseOptionalLBrace())) {
auto parseOperands = [&]() {
StringAttr nameAttr;
OpAsmParser::UnresolvedOperand operand;
if (p.parseAttribute(nameAttr) || p.parseEqual() ||
p.parseOperand(operand))
return failure();
attrNames.push_back(nameAttr);
attrOperands.push_back(operand);
return success();
};
if (p.parseCommaSeparatedList(parseOperands) || p.parseRBrace())
return failure();
}
attrNamesAttr = builder.getArrayAttr(attrNames);
return success();
}
static void printOperationOpAttributes(OpAsmPrinter &p, OperationOp op,
OperandRange attrArgs,
ArrayAttr attrNames) {
if (attrNames.empty())
return;
p << " {";
interleaveComma(llvm::seq<int>(0, attrNames.size()), p,
[&](int i) { p << attrNames[i] << " = " << attrArgs[i]; });
p << '}';
}
/// Verifies that the result types of this operation, defined within a
/// `pdl.rewrite`, can be inferred.
static LogicalResult verifyResultTypesAreInferrable(OperationOp op,
OperandRange resultTypes) {
// Functor that returns if the given use can be used to infer a type.
Block *rewriterBlock = op->getBlock();
auto canInferTypeFromUse = [&](OpOperand &use) {
// If the use is within a ReplaceOp and isn't the operation being replaced
// (i.e. is not the first operand of the replacement), we can infer a type.
ReplaceOp replOpUser = dyn_cast<ReplaceOp>(use.getOwner());
if (!replOpUser || use.getOperandNumber() == 0)
return false;
// Make sure the replaced operation was defined before this one.
Operation *replacedOp = replOpUser.getOpValue().getDefiningOp();
return replacedOp->getBlock() != rewriterBlock ||
replacedOp->isBeforeInBlock(op);
};
// Check to see if the uses of the operation itself can be used to infer
// types.
if (llvm::any_of(op.getOp().getUses(), canInferTypeFromUse))
return success();
// Handle the case where the operation has no explicit result types.
if (resultTypes.empty()) {
// If we don't know the concrete operation, don't attempt any verification.
// We can't make assumptions if we don't know the concrete operation.
std::optional<StringRef> rawOpName = op.getOpName();
if (!rawOpName)
return success();
std::optional<RegisteredOperationName> opName =
RegisteredOperationName::lookup(*rawOpName, op.getContext());
if (!opName)
return success();
// If no explicit result types were provided, check to see if the operation
// expected at least one result. This doesn't cover all cases, but this
// should cover many cases in which the user intended to infer the results
// of an operation, but it isn't actually possible.
bool expectedAtLeastOneResult =
!opName->hasTrait<OpTrait::ZeroResults>() &&
!opName->hasTrait<OpTrait::VariadicResults>();
if (expectedAtLeastOneResult) {
return op
.emitOpError("must have inferable or constrained result types when "
"nested within `pdl.rewrite`")
.attachNote()
.append("operation is created in a non-inferrable context, but '",
*opName, "' does not implement InferTypeOpInterface");
}
return success();
}
// Otherwise, make sure each of the types can be inferred.
for (const auto &it : llvm::enumerate(resultTypes)) {
Operation *resultTypeOp = it.value().getDefiningOp();
assert(resultTypeOp && "expected valid result type operation");
// If the op was defined by a `apply_native_rewrite`, it is guaranteed to be
// usable.
if (isa<ApplyNativeRewriteOp>(resultTypeOp))
continue;
// If the type operation was defined in the matcher and constrains an
// operand or the result of an input operation, it can be used.
auto constrainsInput = [rewriterBlock](Operation *user) {
return user->getBlock() != rewriterBlock &&
isa<OperandOp, OperandsOp, OperationOp>(user);
};
if (TypeOp typeOp = dyn_cast<TypeOp>(resultTypeOp)) {
if (typeOp.getConstantType() ||
llvm::any_of(typeOp->getUsers(), constrainsInput))
continue;
} else if (TypesOp typeOp = dyn_cast<TypesOp>(resultTypeOp)) {
if (typeOp.getConstantTypes() ||
llvm::any_of(typeOp->getUsers(), constrainsInput))
continue;
}
return op
.emitOpError("must have inferable or constrained result types when "
"nested within `pdl.rewrite`")
.attachNote()
.append("result type #", it.index(), " was not constrained");
}
return success();
}
LogicalResult OperationOp::verify() {
bool isWithinRewrite = isa_and_nonnull<RewriteOp>((*this)->getParentOp());
if (isWithinRewrite && !getOpName())
return emitOpError("must have an operation name when nested within "
"a `pdl.rewrite`");
ArrayAttr attributeNames = getAttributeValueNamesAttr();
auto attributeValues = getAttributeValues();
if (attributeNames.size() != attributeValues.size()) {
return emitOpError()
<< "expected the same number of attribute values and attribute "
"names, got "
<< attributeNames.size() << " names and " << attributeValues.size()
<< " values";
}
// If the operation is within a rewrite body and doesn't have type inference,
// ensure that the result types can be resolved.
if (isWithinRewrite && !mightHaveTypeInference()) {
if (failed(verifyResultTypesAreInferrable(*this, getTypeValues())))
return failure();
}
return verifyHasBindingUse(*this);
}
bool OperationOp::hasTypeInference() {
if (std::optional<StringRef> rawOpName = getOpName()) {
OperationName opName(*rawOpName, getContext());
return opName.hasInterface<InferTypeOpInterface>();
}
return false;
}
bool OperationOp::mightHaveTypeInference() {
if (std::optional<StringRef> rawOpName = getOpName()) {
OperationName opName(*rawOpName, getContext());
return opName.mightHaveInterface<InferTypeOpInterface>();
}
return false;
}
//===----------------------------------------------------------------------===//
// pdl::PatternOp
//===----------------------------------------------------------------------===//
LogicalResult PatternOp::verifyRegions() {
Region &body = getBodyRegion();
Operation *term = body.front().getTerminator();
auto rewriteOp = dyn_cast<RewriteOp>(term);
if (!rewriteOp) {
return emitOpError("expected body to terminate with `pdl.rewrite`")
.attachNote(term->getLoc())
.append("see terminator defined here");
}
// Check that all values defined in the top-level pattern belong to the PDL
// dialect.
WalkResult result = body.walk([&](Operation *op) -> WalkResult {
if (!isa_and_nonnull<PDLDialect>(op->getDialect())) {
emitOpError("expected only `pdl` operations within the pattern body")
.attachNote(op->getLoc())
.append("see non-`pdl` operation defined here");
return WalkResult::interrupt();
}
return WalkResult::advance();
});
if (result.wasInterrupted())
return failure();
// Check that there is at least one operation.
if (body.front().getOps<OperationOp>().empty())
return emitOpError("the pattern must contain at least one `pdl.operation`");
// Determine if the operations within the pdl.pattern form a connected
// component. This is determined by starting the search from the first
// operand/result/operation and visiting their users / parents / operands.
// We limit our attention to operations that have a user in pdl.rewrite,
// those that do not will be detected via other means (expected bindable
// user).
bool first = true;
DenseSet<Operation *> visited;
for (Operation &op : body.front()) {
// The following are the operations forming the connected component.
if (!isa<OperandOp, OperandsOp, ResultOp, ResultsOp, OperationOp>(op))
continue;
// Determine if the operation has a user in `pdl.rewrite`.
bool hasUserInRewrite = false;
for (Operation *user : op.getUsers()) {
Region *region = user->getParentRegion();
if (isa<RewriteOp>(user) ||
(region && isa<RewriteOp>(region->getParentOp()))) {
hasUserInRewrite = true;
break;
}
}
// If the operation does not have a user in `pdl.rewrite`, ignore it.
if (!hasUserInRewrite)
continue;
if (first) {
// For the first operation, invoke visit.
visit(&op, visited);
first = false;
} else if (!visited.count(&op)) {
// For the subsequent operations, check if already visited.
return emitOpError("the operations must form a connected component")
.attachNote(op.getLoc())
.append("see a disconnected value / operation here");
}
}
return success();
}
void PatternOp::build(OpBuilder &builder, OperationState &state,
std::optional<uint16_t> benefit,
std::optional<StringRef> name) {
build(builder, state, builder.getI16IntegerAttr(benefit ? *benefit : 0),
name ? builder.getStringAttr(*name) : StringAttr());
state.regions[0]->emplaceBlock();
}
/// Returns the rewrite operation of this pattern.
RewriteOp PatternOp::getRewriter() {
return cast<RewriteOp>(getBodyRegion().front().getTerminator());
}
/// The default dialect is `pdl`.
StringRef PatternOp::getDefaultDialect() {
return PDLDialect::getDialectNamespace();
}
//===----------------------------------------------------------------------===//
// pdl::RangeOp
//===----------------------------------------------------------------------===//
static ParseResult parseRangeType(OpAsmParser &p, TypeRange argumentTypes,
Type &resultType) {
// If arguments were provided, infer the result type from the argument list.
if (!argumentTypes.empty()) {
resultType = RangeType::get(getRangeElementTypeOrSelf(argumentTypes[0]));
return success();
}
// Otherwise, parse the type as a trailing type.
return p.parseColonType(resultType);
}
static void printRangeType(OpAsmPrinter &p, RangeOp op, TypeRange argumentTypes,
Type resultType) {
if (argumentTypes.empty())
p << ": " << resultType;
}
LogicalResult RangeOp::verify() {
Type elementType = getType().getElementType();
for (Type operandType : getOperandTypes()) {
Type operandElementType = getRangeElementTypeOrSelf(operandType);
if (operandElementType != elementType) {
return emitOpError("expected operand to have element type ")
<< elementType << ", but got " << operandElementType;
}
}
return success();
}
//===----------------------------------------------------------------------===//
// pdl::ReplaceOp
//===----------------------------------------------------------------------===//
LogicalResult ReplaceOp::verify() {
if (getReplOperation() && !getReplValues().empty())
return emitOpError() << "expected no replacement values to be provided"
" when the replacement operation is present";
return success();
}
//===----------------------------------------------------------------------===//
// pdl::ResultsOp
//===----------------------------------------------------------------------===//
static ParseResult parseResultsValueType(OpAsmParser &p, IntegerAttr index,
Type &resultType) {
if (!index) {
resultType = RangeType::get(p.getBuilder().getType<ValueType>());
return success();
}
if (p.parseArrow() || p.parseType(resultType))
return failure();
return success();
}
static void printResultsValueType(OpAsmPrinter &p, ResultsOp op,
IntegerAttr index, Type resultType) {
if (index)
p << " -> " << resultType;
}
LogicalResult ResultsOp::verify() {
if (!getIndex() && llvm::isa<pdl::ValueType>(getType())) {
return emitOpError() << "expected `pdl.range<value>` result type when "
"no index is specified, but got: "
<< getType();
}
return success();
}
//===----------------------------------------------------------------------===//
// pdl::RewriteOp
//===----------------------------------------------------------------------===//
LogicalResult RewriteOp::verifyRegions() {
Region &rewriteRegion = getBodyRegion();
// Handle the case where the rewrite is external.
if (getName()) {
if (!rewriteRegion.empty()) {
return emitOpError()
<< "expected rewrite region to be empty when rewrite is external";
}
return success();
}
// Otherwise, check that the rewrite region only contains a single block.
if (rewriteRegion.empty()) {
return emitOpError() << "expected rewrite region to be non-empty if "
"external name is not specified";
}
// Check that no additional arguments were provided.
if (!getExternalArgs().empty()) {
return emitOpError() << "expected no external arguments when the "
"rewrite is specified inline";
}
return success();
}
/// The default dialect is `pdl`.
StringRef RewriteOp::getDefaultDialect() {
return PDLDialect::getDialectNamespace();
}
//===----------------------------------------------------------------------===//
// pdl::TypeOp
//===----------------------------------------------------------------------===//
LogicalResult TypeOp::verify() {
if (!getConstantTypeAttr())
return verifyHasBindingUse(*this);
return success();
}
//===----------------------------------------------------------------------===//
// pdl::TypesOp
//===----------------------------------------------------------------------===//
LogicalResult TypesOp::verify() {
if (!getConstantTypesAttr())
return verifyHasBindingUse(*this);
return success();
}
//===----------------------------------------------------------------------===//
// TableGen'd op method definitions
//===----------------------------------------------------------------------===//
#define GET_OP_CLASSES
#include "mlir/Dialect/PDL/IR/PDLOps.cpp.inc"