Dmitry Vyukov 3056ccdbae tsan: fix deadlock/crash in signal handling ...

We set in_blocking_func around some blocking C functions so that we don't
delay signal infinitely (if in_blocking_func is set we deliver signals
synchronously).

However, pthread_join is blocking but also call munmap/free to free thread
resources. If we are inside the munmap/free interceptors called from
pthread_join and deliver a signal synchronously, it can lead to deadlocks
and crashes since we re-enter runtime and try to lock the same mutexes
or use the same per-thread data structures.

If we re-enter runtime via an interceptor when in_blocking_func is set,
temporary reset in_blocking_func around the interceptor and restore it back
when we return from the recursive interceptor.

Also move in_blocking_func from ThreadSignalContext to ThreadContext
so that we can CHECK that it's not set in SlotLocker ctor.

Fixes https://github.com/google/sanitizers/issues/1540

Reviewed By: melver

Differential Revision: https://reviews.llvm.org/D127845

2022-09-30 14:23:46 +02:00

..

Darwin

[tsan][test] Remaining tests requiring weak symbols for dyld64

2022-08-01 11:02:43 -07:00

libcxx

…

libdispatch

[tsan][test] Remaining tests requiring weak symbols for dyld64

2022-08-01 11:02:43 -07:00

Linux

[tsan] Replace mem intrinsics with calls to interceptors

2022-09-06 13:09:31 -07:00

Unit

[Darwin] Limit parallelism for sanitizer tests that use shadow memory on AS

2022-03-31 14:43:28 -07:00

aligned_vs_unaligned_race.cpp

…

annotate_happens_before.cpp

…

atexit2.cpp

…

atexit3.cpp

…

atexit4.cpp

…

atexit5.cpp

…

atexit.cpp

…

atomic_free2.cpp

…

atomic_free3.cpp

…

atomic_free.cpp

…

atomic_hle.cpp

…

atomic_norace2.cpp

…

atomic_norace.cpp

…

atomic_race.cpp

…

atomic_stack.cpp

…

atomic_store.cpp

…

barrier.cpp

…

bench_acquire_only.cpp

…

bench_acquire_release.cpp

…

bench_local_mutex.cpp

…

bench_malloc.cpp

tsan: optimize DenseSlabAlloc

2022-07-19 15:42:57 +02:00

bench_memory_access.cpp

…

bench_mutex.cpp

…

bench_release_only.cpp

…

bench_rwmutex.cpp

…

bench_shadow_flush.cpp

…

bench_single_writer.cpp

…

bench_ten_mutexes.cpp

…

bench_threads.cpp

…

bench.h

…

benign_race.cpp

…

CMakeLists.txt

Revert "[CMake][compiler-rt] Clean up the use of libcxx and libcxxabi"

2022-06-25 03:10:55 +00:00

compare_exchange.cpp

…

cond_cancel.c

…

cond_destruction.cpp

…

cond_race.cpp

…

cond_version.c

…

cond.c

…

custom_mutex0.cpp

…

custom_mutex1.cpp

…

custom_mutex2.cpp

…

custom_mutex3.cpp

…

custom_mutex4.cpp

…

custom_mutex5.cpp

…

custom_mutex.h

…

cxa_guard_acquire.cpp

[TSan][Darwin] Additional TSAN test requiring weak symbol for dyld64

2022-07-29 11:24:40 -07:00

deadlock_detector_stress_test.cpp

…

debug_alloc_stack.cpp

[TSan] Fix pointer/type-mismatch bug in test that has turned into a compile error

2022-08-26 16:29:30 -07:00

debug_locate.cpp

…

debugging.cpp

[tsan][test] Remaining tests requiring weak symbols for dyld64

2022-08-01 11:02:43 -07:00

deep_stack1.cpp

…

deep_stack2.cpp

…

default_options.cpp

[TSan][Darwin] Additional TSAN test requiring weak symbol for dyld64

2022-07-29 11:24:40 -07:00

deflake.bash

…

dl_iterate_phdr.cpp

…

dlclose.cpp

…

dtls.c

…

exceptions.cpp

…

fd_close_norace2.cpp

…

fd_close_norace3.cpp

…

fd_close_norace.cpp

…

fd_close_race.cpp

…

fd_dup_norace2.cpp

…

fd_dup_norace.cpp

…

fd_dup_race.cpp

…

fd_location_closed.cpp

[Tests][TSan] Remove bash-ism |&, which is unsupported on other shells

2022-08-26 14:38:06 -07:00

fd_location.cpp

…

fd_pipe_norace.cpp

…

fd_pipe_race.cpp

…

fd_socket_connect_norace.cpp

…

fd_socket_norace.cpp

…

fd_socketpair_norace.cpp

…

fd_stdout_race.cpp

…

fd_tid_recycled.cpp

…

fiber_asm.cpp

…

fiber_cleanup.cpp

…

fiber_from_thread.cpp

…

fiber_longjmp.cpp

…

fiber_race.cpp

…

fiber_simple.cpp

…

fiber_two_threads.cpp

…

flush_memory.cpp

…

force_background_thread.cpp

…

fork_atexit.cpp

…

fork_deadlock.cpp

…

fork_multithreaded3.cpp

…

fork_multithreaded.cpp

…

free_race2.c

…

free_race3.c

…

free_race.c

…

free_race.c.supp

…

getline_nohang.cpp

…

global_race2.cpp

…

global_race3.cpp

…

global_race.cpp

…

halt_on_error.cpp

…

heap_race.cpp

…

ignore_free.cpp

…

ignore_lib0.cpp

…

ignore_lib0.cpp.supp

…

ignore_lib1.cpp

…

ignore_lib1.cpp.supp

…

ignore_lib2.cpp

…

ignore_lib2.cpp.supp

…

ignore_lib3.cpp

…

ignore_lib3.cpp.supp

…

ignore_lib4.cpp

…

ignore_lib5.cpp

…

ignore_lib5.cpp.supp

…

ignore_lib6.cpp

…

ignore_lib6.cpp.supp

…

ignore_lib_lib.h

…

ignore_malloc.cpp

…

ignore_race.cpp

…

ignore_sync.cpp

…

ignored-interceptors-mmap.cpp

…

ignorelist2.cpp

…

ignorelist.cpp

…

inlined_memcpy_race2.cpp

[tsan] Replace mem intrinsics with calls to interceptors

2022-09-06 13:09:31 -07:00

inlined_memcpy_race.cpp

[tsan] Replace mem intrinsics with calls to interceptors

2022-09-06 13:09:31 -07:00

interface_atomic_test.c

…

java_alloc.cpp

…

java_finalizer2.cpp

…

java_finalizer.cpp

…

java_find.cpp

…

java_heap_init.cpp

…

java_lock_move.cpp

…

java_lock_rec_race.cpp

…

java_lock_rec.cpp

…

java_lock.cpp

…

java_move_overlap_race.cpp

…

java_move_overlap.cpp

…

java_race_move.cpp

…

java_race_pc.cpp

…

java_race.cpp

…

java_rwlock.cpp

…

java_symbolization_legacy.cpp

[TSAN][Darwin] x86_64 specific tests requiring weak symbols

2022-08-03 15:51:23 -07:00

java_symbolization.cpp

[TSAN][Darwin] x86_64 specific tests requiring weak symbols

2022-08-03 15:51:23 -07:00

java_volatile.cpp

…

java.h

…

large_malloc_meta.cpp

…

lit.cfg.py

…

lit.site.cfg.py.in

…

load_shared_lib.cpp

…

longjmp2.cpp

…

longjmp3.cpp

…

longjmp4.cpp

…

longjmp.cpp

…

lots_of_threads.c

…

malloc_overflow.cpp

…

malloc_stack.cpp

…

map32bit.cpp

…

memcmp_race.cpp

[tsan] Replace mem intrinsics with calls to interceptors

2022-09-06 13:09:31 -07:00

memcpy_race.cpp

[tsan] Replace mem intrinsics with calls to interceptors

2022-09-06 13:09:31 -07:00

mmap_large.cpp

…

mmap_lots.cpp

…

mmap_stress2.cpp

…

mmap_stress.cpp

…

mop1.c

…

mop_with_offset2.cpp

…

mop_with_offset.cpp

…

munmap_invalid.cpp

…

must_deadlock.cpp

…

mutex_annotations.cpp

…

mutex_bad_read_lock.cpp

…

mutex_bad_read_unlock.cpp

…

mutex_bad_unlock.cpp

…

mutex_cycle2.c

…

mutex_cycle_long.c

…

mutex_destroy_locked2.cpp

…

mutex_destroy_locked.cpp

…

mutex_double_lock.cpp

…

mutex_lock_destroyed.cpp

…

mutexset1.cpp

…

mutexset2.cpp

…

mutexset3.cpp

…

mutexset4.cpp

…

mutexset5.cpp

…

mutexset6.cpp

…

mutexset7.cpp

…

mutexset8.cpp

…

on_exit.cpp

…

on_initialize_finalize_hooks.cpp

…

pie_test.cpp

…

print_full_thread_history.cpp

[TSan] Add a runtime flag to print full thread creation stacks up to the main thread

2022-03-24 17:30:27 +01:00

printf-1.c

…

pthread_atfork_deadlock2.c

…

pthread_atfork_deadlock3.c

…

pthread_atfork_deadlock.c

…

pthread_key.cpp

…

race_on_barrier2.c

…

race_on_barrier.c

…

race_on_fputs.cpp

…

race_on_heap.cpp

…

race_on_mutex2.c

…

race_on_mutex.c

…

race_on_puts.cpp

…

race_on_read.cpp

…

race_on_speculative_load.cpp

…

race_on_write.cpp

…

race_range_pc.cpp

…

race_stress.cpp

…

race_top_suppression1.cpp

…

race_top_suppression.cpp

…

race_with_finished_thread.cpp

…

real_deadlock_detector_stress_test.cpp

…

restore_stack.cpp

…

setuid2.c

…

signal_block2.cpp

…

signal_block.cpp

…

signal_cond.cpp

…

signal_errno.cpp

…

signal_exit.cpp

…

signal_longjmp.cpp

…

signal_malloc.cpp

…

signal_pause.cpp

…

signal_recursive.cpp

…

signal_reset.cpp

…

signal_sync2.cpp

…

signal_sync.cpp

…

signal_thread2.cpp

tsan: fix deadlock/crash in signal handling

2022-09-30 14:23:46 +02:00

signal_thread.cpp

…

signal_write.cpp

…

sigsuspend.cpp

…

simple_race.c

…

simple_race.cpp

…

simple_stack2.cpp

…

simple_stack.c

…

sleep_sync2.cpp

…

sleep_sync.cpp

…

stack_race2.cpp

…

stack_race.cpp

…

stack_sync_reuse.cpp

…

static_init1.cpp

…

static_init2.cpp

…

static_init3.cpp

…

static_init4.cpp

…

static_init5.cpp

…

static_init6.cpp

…

static_init7.cpp

…

strerror_r.cpp

…

stress.cpp

tsan: remove tracking of racy addresses

2022-07-25 10:33:26 +02:00

sunrpc.cpp

…

suppress_same_address.cpp

…

suppress_same_stacks.cpp

…

suppressions_global.cpp

…

suppressions_global.cpp.supp

…

suppressions_mutex.cpp

…

suppressions_mutex.cpp.supp

…

suppressions_race2.cpp

…

suppressions_race2.cpp.supp

…

suppressions_race.cpp

…

suppressions_race.cpp.supp

…

test.h

…

thread_detach2.c

…

thread_detach.c

…

thread_end_with_ignore2.cpp

…

thread_end_with_ignore3.cpp

…

thread_end_with_ignore.cpp

…

thread_exit.c

…

thread_leak2.c

…

thread_leak3.c

…

thread_leak4.c

…

thread_leak5.c

…

thread_leak.c

…

thread_name2.cpp

…

thread_name.cpp

…

tiny_race.c

…

tls_race2.cpp

…

tls_race.cpp

…

tsan-vs-gvn.cpp

…

unaligned_norace.cpp

…

unaligned_race.cpp

…

vector_race.cpp

…

vfork.cpp

…

virtual_inheritance_compile_bug.cpp

…

vptr_benign_race.cpp

…

vptr_harmful_race2.cpp

…

vptr_harmful_race3.cpp

…

vptr_harmful_race4.cpp

…

vptr_harmful_race.cpp

…

write_in_reader_lock.cpp

…