5548e807b5
This removes the extractvalue constant expression, as part of https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179. extractvalue is already not supported in bitcode, so we do not need to worry about bitcode auto-upgrade. Uses of ConstantExpr::getExtractValue() should be replaced with IRBuilder::CreateExtractValue() (if the fact that the result is constant is not important) or ConstantFoldExtractValueInstruction() (if it is). Though for this particular case, it is also possible and usually preferable to use getAggregateElement() instead. The C API function LLVMConstExtractValue() is removed, as the underlying constant expression no longer exists. Instead, LLVMBuildExtractValue() should be used (which will constant fold or create an instruction). Depending on the use-case, LLVMGetAggregateElement() may also be used instead. Differential Revision: https://reviews.llvm.org/D125795
20 lines
477 B
LLVM
20 lines
477 B
LLVM
; RUN: llc < %s
|
|
|
|
; PR33094
|
|
; Make sure that a constant extractvalue doesn't cause a crash in
|
|
; SelectionDAGBuilder::visitExtractValue.
|
|
|
|
%A = type {}
|
|
%B = type {}
|
|
%Tuple = type { i64 }
|
|
|
|
@A_Inst = global %A zeroinitializer
|
|
@B_Inst = global %B zeroinitializer
|
|
|
|
define i64 @foo() {
|
|
%e = extractvalue %Tuple select (i1 icmp eq
|
|
(%B* bitcast (%A* @A_Inst to %B*), %B* @B_Inst),
|
|
%Tuple { i64 33 }, %Tuple { i64 42 }), 0
|
|
ret i64 %e
|
|
}
|