304f1d59ca
This switches everything to use the memory attribute proposed in https://discourse.llvm.org/t/rfc-unify-memory-effect-attributes/65579. The old argmemonly, inaccessiblememonly and inaccessiblemem_or_argmemonly attributes are dropped. The readnone, readonly and writeonly attributes are restricted to parameters only. The old attributes are auto-upgraded both in bitcode and IR. The bitcode upgrade is a policy requirement that has to be retained indefinitely. The IR upgrade is mainly there so it's not necessary to update all tests using memory attributes in this patch, which is already large enough. We could drop that part after migrating tests, or retain it longer term, to make it easier to import IR from older LLVM versions. High-level Function/CallBase APIs like doesNotAccessMemory() or setDoesNotAccessMemory() are mapped transparently to the memory attribute. Code that directly manipulates attributes (e.g. via AttributeList) on the other hand needs to switch to working with the memory attribute instead. Differential Revision: https://reviews.llvm.org/D135780
134 lines
4.6 KiB
LLVM
134 lines
4.6 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --check-attributes --check-globals
|
|
; RUN: opt -aa-pipeline=basic-aa -passes=attributor -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=2 -S < %s | FileCheck %s --check-prefixes=CHECK,TUNIT
|
|
; RUN: opt -aa-pipeline=basic-aa -passes=attributor-cgscc -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK,CGSCC
|
|
;
|
|
; When a function is marked `alwaysinline` and is able to be inlined,
|
|
; we can IPO its boundaries
|
|
|
|
; the function is not exactly defined, and marked alwaysinline and can be inlined,
|
|
; so the function can be analyzed
|
|
define linkonce void @inner1() alwaysinline {
|
|
; CHECK: Function Attrs: alwaysinline nofree norecurse nosync nounwind willreturn memory(none)
|
|
; CHECK-LABEL: define {{[^@]+}}@inner1
|
|
; CHECK-SAME: () #[[ATTR0:[0-9]+]] {
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
entry:
|
|
ret void
|
|
}
|
|
|
|
define void @outer1() {
|
|
; TUNIT: Function Attrs: nofree norecurse nosync nounwind willreturn memory(none)
|
|
; TUNIT-LABEL: define {{[^@]+}}@outer1
|
|
; TUNIT-SAME: () #[[ATTR1:[0-9]+]] {
|
|
; TUNIT-NEXT: entry:
|
|
; TUNIT-NEXT: ret void
|
|
;
|
|
; CGSCC: Function Attrs: nofree nosync nounwind willreturn memory(none)
|
|
; CGSCC-LABEL: define {{[^@]+}}@outer1
|
|
; CGSCC-SAME: () #[[ATTR1:[0-9]+]] {
|
|
; CGSCC-NEXT: entry:
|
|
; CGSCC-NEXT: ret void
|
|
;
|
|
entry:
|
|
call void @inner1()
|
|
ret void
|
|
}
|
|
|
|
; The function is not alwaysinline and is not exactly defined
|
|
; so it will not be analyzed
|
|
define linkonce i32 @inner2() {
|
|
; CHECK-LABEL: define {{[^@]+}}@inner2() {
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: ret i32 1
|
|
;
|
|
entry:
|
|
ret i32 1
|
|
}
|
|
|
|
; CHECK-NOT: Function Attrs
|
|
define i32 @outer2() {
|
|
; TUNIT: Function Attrs: norecurse
|
|
; TUNIT-LABEL: define {{[^@]+}}@outer2
|
|
; TUNIT-SAME: () #[[ATTR2:[0-9]+]] {
|
|
; TUNIT-NEXT: entry:
|
|
; TUNIT-NEXT: [[R:%.*]] = call i32 @inner2() #[[ATTR3:[0-9]+]]
|
|
; TUNIT-NEXT: ret i32 [[R]]
|
|
;
|
|
; CGSCC-LABEL: define {{[^@]+}}@outer2() {
|
|
; CGSCC-NEXT: entry:
|
|
; CGSCC-NEXT: [[R:%.*]] = call i32 @inner2() #[[ATTR2:[0-9]+]]
|
|
; CGSCC-NEXT: ret i32 [[R]]
|
|
;
|
|
entry:
|
|
%r = call i32 @inner2() alwaysinline
|
|
ret i32 %r
|
|
}
|
|
|
|
; This function cannot be inlined although it is marked alwaysinline
|
|
; it is `unexactly defined` and alwaysinline but cannot be inlined.
|
|
; so it will not be analyzed
|
|
define linkonce i32 @inner3(i8* %addr) alwaysinline {
|
|
; TUNIT: Function Attrs: alwaysinline
|
|
; TUNIT-LABEL: define {{[^@]+}}@inner3
|
|
; TUNIT-SAME: (i8* [[ADDR:%.*]]) #[[ATTR3]] {
|
|
; TUNIT-NEXT: entry:
|
|
; TUNIT-NEXT: indirectbr i8* [[ADDR]], [label [[ONE:%.*]], label %two]
|
|
; TUNIT: one:
|
|
; TUNIT-NEXT: ret i32 42
|
|
; TUNIT: two:
|
|
; TUNIT-NEXT: ret i32 44
|
|
;
|
|
; CGSCC: Function Attrs: alwaysinline
|
|
; CGSCC-LABEL: define {{[^@]+}}@inner3
|
|
; CGSCC-SAME: (i8* [[ADDR:%.*]]) #[[ATTR2]] {
|
|
; CGSCC-NEXT: entry:
|
|
; CGSCC-NEXT: indirectbr i8* [[ADDR]], [label [[ONE:%.*]], label %two]
|
|
; CGSCC: one:
|
|
; CGSCC-NEXT: ret i32 42
|
|
; CGSCC: two:
|
|
; CGSCC-NEXT: ret i32 44
|
|
;
|
|
entry:
|
|
indirectbr i8* %addr, [ label %one, label %two ]
|
|
|
|
one:
|
|
ret i32 42
|
|
|
|
two:
|
|
ret i32 44
|
|
}
|
|
|
|
define i32 @outer3(i32 %x) {
|
|
; TUNIT: Function Attrs: norecurse
|
|
; TUNIT-LABEL: define {{[^@]+}}@outer3
|
|
; TUNIT-SAME: (i32 [[X:%.*]]) #[[ATTR2]] {
|
|
; TUNIT-NEXT: [[CMP:%.*]] = icmp slt i32 [[X]], 42
|
|
; TUNIT-NEXT: [[ADDR:%.*]] = select i1 [[CMP]], i8* blockaddress(@inner3, [[ONE:%.*]]), i8* blockaddress(@inner3, [[TWO:%.*]])
|
|
; TUNIT-NEXT: [[CALL:%.*]] = call i32 @inner3(i8* [[ADDR]])
|
|
; TUNIT-NEXT: ret i32 [[CALL]]
|
|
;
|
|
; CGSCC-LABEL: define {{[^@]+}}@outer3
|
|
; CGSCC-SAME: (i32 [[X:%.*]]) {
|
|
; CGSCC-NEXT: [[CMP:%.*]] = icmp slt i32 [[X]], 42
|
|
; CGSCC-NEXT: [[ADDR:%.*]] = select i1 [[CMP]], i8* blockaddress(@inner3, [[ONE:%.*]]), i8* blockaddress(@inner3, [[TWO:%.*]])
|
|
; CGSCC-NEXT: [[CALL:%.*]] = call i32 @inner3(i8* [[ADDR]])
|
|
; CGSCC-NEXT: ret i32 [[CALL]]
|
|
;
|
|
%cmp = icmp slt i32 %x, 42
|
|
%addr = select i1 %cmp, i8* blockaddress(@inner3, %one), i8* blockaddress(@inner3, %two)
|
|
%call = call i32 @inner3(i8* %addr)
|
|
ret i32 %call
|
|
}
|
|
;.
|
|
; TUNIT: attributes #[[ATTR0]] = { alwaysinline nofree norecurse nosync nounwind willreturn memory(none) }
|
|
; TUNIT: attributes #[[ATTR1]] = { nofree norecurse nosync nounwind willreturn memory(none) }
|
|
; TUNIT: attributes #[[ATTR2]] = { norecurse }
|
|
; TUNIT: attributes #[[ATTR3]] = { alwaysinline }
|
|
;.
|
|
; CGSCC: attributes #[[ATTR0]] = { alwaysinline nofree norecurse nosync nounwind willreturn memory(none) }
|
|
; CGSCC: attributes #[[ATTR1]] = { nofree nosync nounwind willreturn memory(none) }
|
|
; CGSCC: attributes #[[ATTR2]] = { alwaysinline }
|
|
;.
|