7eaf1d96ad
This is part of the continuing effort to increase parity between LLD and MSVC PDBs. link still doesn't like our PDBs, so the most obvious thing to check was whether adding an empty publics stream would get it to do something else. It still fails in the same way but at least this removes one more variable from the equation. The next logical step would be to try creating an empty globals stream. Differential Revision: https://reviews.llvm.org/D35224 llvm-svn: 307598
131 lines
4.7 KiB
C++
131 lines
4.7 KiB
C++
//===- PublicsStream.cpp - PDB Public Symbol Stream -----------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// The data structures defined in this file are based on the reference
|
|
// implementation which is available at
|
|
// https://github.com/Microsoft/microsoft-pdb/blob/master/PDB/dbi/gsi.h
|
|
//
|
|
// When you are reading the reference source code, you'd find the
|
|
// information below useful.
|
|
//
|
|
// - ppdb1->m_fMinimalDbgInfo seems to be always true.
|
|
// - SMALLBUCKETS macro is defined.
|
|
//
|
|
// The reference doesn't compile, so I learned just by reading code.
|
|
// It's not guaranteed to be correct.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/DebugInfo/PDB/Native/PublicsStream.h"
|
|
#include "GSI.h"
|
|
#include "llvm/ADT/iterator_range.h"
|
|
#include "llvm/DebugInfo/CodeView/SymbolRecord.h"
|
|
#include "llvm/DebugInfo/MSF/MappedBlockStream.h"
|
|
#include "llvm/DebugInfo/PDB/Native/PDBFile.h"
|
|
#include "llvm/DebugInfo/PDB/Native/RawError.h"
|
|
#include "llvm/DebugInfo/PDB/Native/SymbolStream.h"
|
|
#include "llvm/Support/BinaryStreamReader.h"
|
|
#include "llvm/Support/Endian.h"
|
|
#include "llvm/Support/Error.h"
|
|
#include <algorithm>
|
|
#include <cstdint>
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::msf;
|
|
using namespace llvm::support;
|
|
using namespace llvm::pdb;
|
|
|
|
PublicsStream::PublicsStream(PDBFile &File,
|
|
std::unique_ptr<MappedBlockStream> Stream)
|
|
: Pdb(File), Stream(std::move(Stream)) {}
|
|
|
|
PublicsStream::~PublicsStream() = default;
|
|
|
|
uint32_t PublicsStream::getSymHash() const { return Header->SymHash; }
|
|
uint32_t PublicsStream::getAddrMap() const { return Header->AddrMap; }
|
|
|
|
// Publics stream contains fixed-size headers and a serialized hash table.
|
|
// This implementation is not complete yet. It reads till the end of the
|
|
// stream so that we verify the stream is at least not corrupted. However,
|
|
// we skip over the hash table which we believe contains information about
|
|
// public symbols.
|
|
Error PublicsStream::reload() {
|
|
BinaryStreamReader Reader(*Stream);
|
|
|
|
// Check stream size.
|
|
if (Reader.bytesRemaining() <
|
|
sizeof(PublicsStreamHeader) + sizeof(GSIHashHeader))
|
|
return make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Publics Stream does not contain a header.");
|
|
|
|
// Read PSGSIHDR and GSIHashHdr structs.
|
|
if (Reader.readObject(Header))
|
|
return make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Publics Stream does not contain a header.");
|
|
|
|
if (auto EC = readGSIHashHeader(HashHdr, Reader))
|
|
return EC;
|
|
|
|
if (auto EC = readGSIHashRecords(HashRecords, HashHdr, Reader))
|
|
return EC;
|
|
|
|
if (auto EC = readGSIHashBuckets(HashBuckets, HashHdr, Reader))
|
|
return EC;
|
|
NumBuckets = HashBuckets.size();
|
|
|
|
// Something called "address map" follows.
|
|
uint32_t NumAddressMapEntries = Header->AddrMap / sizeof(uint32_t);
|
|
if (auto EC = Reader.readArray(AddressMap, NumAddressMapEntries))
|
|
return joinErrors(std::move(EC),
|
|
make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Could not read an address map."));
|
|
|
|
// Something called "thunk map" follows.
|
|
if (auto EC = Reader.readArray(ThunkMap, Header->NumThunks))
|
|
return joinErrors(std::move(EC),
|
|
make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Could not read a thunk map."));
|
|
|
|
// Something called "section map" follows.
|
|
if (Reader.bytesRemaining() > 0) {
|
|
if (auto EC = Reader.readArray(SectionOffsets, Header->NumSections))
|
|
return joinErrors(std::move(EC),
|
|
make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Could not read a section map."));
|
|
}
|
|
|
|
if (Reader.bytesRemaining() > 0)
|
|
return make_error<RawError>(raw_error_code::corrupt_file,
|
|
"Corrupted publics stream.");
|
|
return Error::success();
|
|
}
|
|
|
|
iterator_range<codeview::CVSymbolArray::Iterator>
|
|
PublicsStream::getSymbols(bool *HadError) const {
|
|
auto SymbolS = Pdb.getPDBSymbolStream();
|
|
if (SymbolS.takeError()) {
|
|
codeview::CVSymbolArray::Iterator Iter;
|
|
return make_range(Iter, Iter);
|
|
}
|
|
SymbolStream &SS = SymbolS.get();
|
|
|
|
return SS.getSymbols(HadError);
|
|
}
|
|
|
|
Expected<const codeview::CVSymbolArray &>
|
|
PublicsStream::getSymbolArray() const {
|
|
auto SymbolS = Pdb.getPDBSymbolStream();
|
|
if (!SymbolS)
|
|
return SymbolS.takeError();
|
|
|
|
return SymbolS->getSymbolArray();
|
|
}
|
|
|
|
Error PublicsStream::commit() { return Error::success(); }
|