be994649b4
Summary:
- Reason of both bugs:
1. For the very first frame, Unwinder doesn't check the validity
of Full UnwindPlan before creating StackFrame from it:
When 'process launch' command is run after setting a breakpoint
in inferior, the Unwinder runs and saves only Frame 0 (the frame
in which breakpoint was set) in thread's StackFrameList i.e.
m_curr_frames_sp. However, it doesn't check the validity of the
Full UnwindPlan for this frame by unwinding 2 more frames further.
2. Unwinder doesn't update the CFA value of Cursor when Full UnwindPlan
fails and FallBack UnwindPlan succeeds in providing valid CFA values
for frames:
Sometimes during unwinding of stack frames, the Full UnwindPlan
inside the RegisterContextLLDB object may fail to provide valid
CFA values for these frames. Then the Fallback UnwindPlan is used
to unwind the frames.
If the Fallback UnwindPlan succeeds, then it provides a valid new
CFA value. The RegisterContextLLDB::m_cfa field of Cursor object
is updated during the Fallback UnwindPlan execution. However,
UnwindLLDB misses the implementation to update the 'cfa' field
of this Cursor with this valid new CFA value.
- This patch fixes both these issues.
- Remove XFAIL in test files corresponding to these 2 Bugs
Change-Id: I932ea407545ceee2d628f946ecc61a4806d4cc86
Signed-off-by: Abhishek Aggarwal <abhishek.a.aggarwal@intel.com>
Reviewers: jingham, lldb-commits, jasonmolenda
Subscribers: lldb-commits, ovyalov, tberghammer
Differential Revision: http://reviews.llvm.org/D14226
llvm-svn: 253026
79 lines
3.1 KiB
Python
79 lines
3.1 KiB
Python
"""Test convenience variables when you drop in from lldb prompt into an embedded interpreter."""
|
|
|
|
from __future__ import print_function
|
|
|
|
|
|
|
|
import os
|
|
import lldb
|
|
from lldbsuite.test.lldbtest import *
|
|
|
|
class ConvenienceVariablesCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
def setUp(self):
|
|
# Call super's setUp().
|
|
TestBase.setUp(self)
|
|
# Find the line number to break on inside main.cpp.
|
|
self.line = line_number('main.c', 'Hello world.')
|
|
|
|
@skipIfFreeBSD # llvm.org/pr17228
|
|
@skipIfRemote
|
|
@expectedFailureWindows("llvm.org/pr22274: need a pexpect replacement for windows")
|
|
def test_with_run_commands(self):
|
|
"""Test convenience variables lldb.debugger, lldb.target, lldb.process, lldb.thread, and lldb.frame."""
|
|
self.build()
|
|
import pexpect
|
|
exe = os.path.join(os.getcwd(), "a.out")
|
|
prompt = "(lldb) "
|
|
python_prompt = ">>> "
|
|
|
|
# So that the child gets torn down after the test.
|
|
self.child = pexpect.spawn('%s %s %s' % (lldbtest_config.lldbExec, self.lldbOption, exe))
|
|
child = self.child
|
|
# Turn on logging for what the child sends back.
|
|
if self.TraceOn():
|
|
child.logfile_read = sys.stdout
|
|
|
|
# Set the breakpoint, run the inferior, when it breaks, issue print on
|
|
# the various convenience variables.
|
|
child.expect_exact(prompt)
|
|
child.sendline('breakpoint set -f main.c -l %d' % self.line)
|
|
child.expect_exact(prompt)
|
|
child.sendline('run')
|
|
child.expect_exact("stop reason = breakpoint 1.1")
|
|
child.expect_exact(prompt)
|
|
child.sendline('script')
|
|
child.expect_exact(python_prompt)
|
|
|
|
# Set a flag so that we know during teardown time, we need to exit the
|
|
# Python interpreter, then the lldb interpreter.
|
|
self.child_in_script_interpreter = True
|
|
|
|
child.sendline('print(lldb.debugger)')
|
|
child.expect_exact(python_prompt)
|
|
self.expect(child.before, exe=False,
|
|
patterns = ['Debugger \(instance: .*, id: \d\)'])
|
|
|
|
child.sendline('print(lldb.target)')
|
|
child.expect_exact(python_prompt)
|
|
self.expect(child.before, exe=False,
|
|
substrs = ['a.out'])
|
|
|
|
child.sendline('print(lldb.process)')
|
|
child.expect_exact(python_prompt)
|
|
self.expect(child.before, exe=False,
|
|
patterns = ['SBProcess: pid = \d+, state = stopped, threads = \d, executable = a.out'])
|
|
|
|
child.sendline('print(lldb.thread)')
|
|
child.expect_exact(python_prompt)
|
|
# Linux outputs decimal tid and 'name' instead of 'queue'
|
|
self.expect(child.before, exe=False,
|
|
patterns = ['thread #1: tid = (0x[0-9a-f]+|[0-9]+), 0x[0-9a-f]+ a\.out`main\(argc=1, argv=0x[0-9a-f]+\) \+ \d+ at main\.c:%d, (name|queue) = \'.+\', stop reason = breakpoint 1\.1' % self.line])
|
|
|
|
child.sendline('print(lldb.frame)')
|
|
child.expect_exact(python_prompt)
|
|
self.expect(child.before, exe=False,
|
|
patterns = ['frame #0: 0x[0-9a-f]+ a\.out`main\(argc=1, argv=0x[0-9a-f]+\) \+ \d+ at main\.c:%d' % self.line])
|