43222bd309
This pull request aims to remove any dependency on OpenCL/SPIR-V type information in LLVM IR metadata. While, using metadata might simplify and prettify the resulting SPIR-V output (and restore some of the information missed in the transformation to opaque pointers), the overall methodology for resolving kernel parameter types is highly inefficient. The high-level strategy is to assign kernel parameter types in this order: 1. Resolving the types using builtin function calls as mangled names must contain type information or by looking up builtin definition in SPIRVBuiltins.td. Then: - Assigning the type temporarily using an intrinsic and later setting the right SPIR-V type in SPIRVGlobalRegistry after IRTranslation - Inserting a bitcast 2. Defaulting to LLVM IR types (in case of pointers the generic i8* type or types from byval/byref attributes) In case of type incompatibility (e.g. parameter defined initially as sampler_t and later used as image_t) the error will be found early on before IRTranslation (in the SPIRVEmitIntrinsics pass).
24 lines
1008 B
LLVM
24 lines
1008 B
LLVM
|
|
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
|
|
|
|
; CHECK-DAG: %[[#INT8:]] = OpTypeInt 8 0
|
|
; CHECK-DAG: %[[#INT64:]] = OpTypeInt 64 0
|
|
; CHECK-DAG: %[[#PTRINT8:]] = OpTypePointer Workgroup %[[#INT8]]
|
|
; CHECK-DAG: %[[#CONST:]] = OpConstant %[[#INT64]] 1
|
|
|
|
; CHECK: %[[#PARAM1:]] = OpFunctionParameter %[[#PTRINT8]]
|
|
define spir_kernel void @test1(ptr addrspace(3) %address) {
|
|
; CHECK: %[[#]] = OpInBoundsPtrAccessChain %[[#PTRINT8]] %[[#PARAM1]] %[[#CONST]]
|
|
%cast = bitcast ptr addrspace(3) %address to ptr addrspace(3)
|
|
%gep = getelementptr inbounds i8, ptr addrspace(3) %cast, i64 1
|
|
ret void
|
|
}
|
|
|
|
; CHECK: %[[#PARAM2:]] = OpFunctionParameter %[[#PTRINT8]]
|
|
define spir_kernel void @test2(ptr addrspace(3) %address) {
|
|
; CHECK: %[[#]] = OpInBoundsPtrAccessChain %[[#PTRINT8]] %[[#PARAM2]] %[[#CONST]]
|
|
%gep = getelementptr inbounds i8, ptr addrspace(3) %address, i64 1
|
|
ret void
|
|
}
|