This PR: * adds support for G_SPLAT_VECTOR generic opcode that may be legally generated instead of G_BUILD_VECTOR by previous passes of the translator (see https://github.com/llvm/llvm-project/pull/80378 for the source of breaking changes); * improves deduction of types for opaque pointers. This PR also fixes the following issues: * if a function has ptr argument(s), two functions that have different SPIR-V type definitions may get identical LLVM function types and break agreements of global register and duplicate checker; * checks for pointer types do not account for TypedPointerType. Update of tests: * A test case is added to cover the issue with function ptr parameters. * The first case, that is support for G_SPLAT_VECTOR generic opcode, is covered by existing test cases. * Multiple additional checks by `spirv-val` is added to cover more possibilities of generation of invalid code.
17 lines
653 B
LLVM
17 lines
653 B
LLVM
; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv32-unknown-unknown %s -o - -filetype=obj | spirv-val %}
|
|
|
|
; CHECK-DAG: %[[#INT:]] = OpTypeInt 32
|
|
; CHECK-DAG: %[[#GLOBAL_PTR_INT:]] = OpTypePointer CrossWorkgroup %[[#INT]]
|
|
|
|
define i32 @foo(i32 %a, ptr addrspace(1) %p) {
|
|
store i32 %a, i32 addrspace(1)* %p
|
|
%b = load i32, i32 addrspace(1)* %p
|
|
ret i32 %b
|
|
}
|
|
|
|
; CHECK: %[[#A:]] = OpFunctionParameter %[[#INT]]
|
|
; CHECK: %[[#CorP:]] = {{OpBitcast|OpFunctionParameter}}{{.*}}%[[#GLOBAL_PTR_INT]]{{.*}}
|
|
; CHECK: OpStore %[[#CorP]] %[[#A]]
|
|
; CHECK: %[[#B:]] = OpLoad %[[#INT]] %[[#CorP]]
|