Files
clang-p2996/llvm/test/Transforms/InstSimplify/shift.ll
Nikita Popov d9a5aa8e2d [PatternMatch] Do not accept undef elements in m_AllOnes() and friends (#88217)
Change all the cstval_pred_ty based PatternMatch helpers (things like
m_AllOnes and m_Zero) to only allow poison elements inside vector
splats, not undef elements.

Historically, we used to represent non-demanded elements in vectors
using undef. Nowadays, we use poison instead. As such, I believe that
support for undef in vector splats is no longer useful.

At the same time, while poison splat elements are pretty much always
safe to ignore, this is not generally the case for undef elements. We
have existing miscompiles in our tests due to this (see the
masked-merge-*.ll tests changed here) and it's easy to miss such cases
in the future, now that we write tests using poison instead of undef
elements.

I think overall, keeping support for undef elements no longer makes
sense, and we should drop it. Once this is done consistently, I think we
may also consider allowing poison in m_APInt by default, as doing that
change is much less risky than doing the same with undef.

This change involves a substantial amount of test changes. For most
tests, I've just replaced undef with poison, as I don't think there is
value in retaining both. For some tests (where the distinction between
undef and poison is important), I've duplicated tests.
2024-04-17 18:22:05 +09:00

412 lines
10 KiB
LLVM

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=instsimplify -S | FileCheck %s
define i47 @shl_by_0(i47 %A) {
; CHECK-LABEL: @shl_by_0(
; CHECK-NEXT: ret i47 [[A:%.*]]
;
%B = shl i47 %A, 0
ret i47 %B
}
define i41 @shl_0(i41 %X) {
; CHECK-LABEL: @shl_0(
; CHECK-NEXT: ret i41 0
;
%B = shl i41 0, %X
ret i41 %B
}
define <2 x i41> @shl_0_vec_poison_elt(<2 x i41> %X) {
; CHECK-LABEL: @shl_0_vec_poison_elt(
; CHECK-NEXT: ret <2 x i41> zeroinitializer
;
%B = shl <2 x i41> <i41 0, i41 poison>, %X
ret <2 x i41> %B
}
define i41 @ashr_by_0(i41 %A) {
; CHECK-LABEL: @ashr_by_0(
; CHECK-NEXT: ret i41 [[A:%.*]]
;
%B = ashr i41 %A, 0
ret i41 %B
}
define i39 @ashr_0(i39 %X) {
; CHECK-LABEL: @ashr_0(
; CHECK-NEXT: ret i39 0
;
%B = ashr i39 0, %X
ret i39 %B
}
define <2 x i141> @ashr_0_vec_poison_elt(<2 x i141> %X) {
; CHECK-LABEL: @ashr_0_vec_poison_elt(
; CHECK-NEXT: ret <2 x i141> zeroinitializer
;
%B = shl <2 x i141> <i141 poison, i141 0>, %X
ret <2 x i141> %B
}
define i55 @lshr_by_bitwidth(i55 %A) {
; CHECK-LABEL: @lshr_by_bitwidth(
; CHECK-NEXT: ret i55 poison
;
%B = lshr i55 %A, 55
ret i55 %B
}
define i32 @shl_by_bitwidth(i32 %A) {
; CHECK-LABEL: @shl_by_bitwidth(
; CHECK-NEXT: ret i32 poison
;
%B = shl i32 %A, 32
ret i32 %B
}
define <4 x i32> @lshr_by_bitwidth_splat(<4 x i32> %A) {
; CHECK-LABEL: @lshr_by_bitwidth_splat(
; CHECK-NEXT: ret <4 x i32> poison
;
%B = lshr <4 x i32> %A, <i32 32, i32 32, i32 32, i32 32> ;; shift all bits out
ret <4 x i32> %B
}
define <4 x i32> @lshr_by_0_splat(<4 x i32> %A) {
; CHECK-LABEL: @lshr_by_0_splat(
; CHECK-NEXT: ret <4 x i32> [[A:%.*]]
;
%B = lshr <4 x i32> %A, zeroinitializer
ret <4 x i32> %B
}
define <4 x i32> @shl_by_bitwidth_splat(<4 x i32> %A) {
; CHECK-LABEL: @shl_by_bitwidth_splat(
; CHECK-NEXT: ret <4 x i32> poison
;
%B = shl <4 x i32> %A, <i32 32, i32 32, i32 32, i32 32> ;; shift all bits out
ret <4 x i32> %B
}
define i32 @ashr_undef() {
; CHECK-LABEL: @ashr_undef(
; CHECK-NEXT: ret i32 0
;
%B = ashr i32 undef, 2 ;; top two bits must be equal, so not undef
ret i32 %B
}
define i32 @ashr_undef_variable_shift_amount(i32 %A) {
; CHECK-LABEL: @ashr_undef_variable_shift_amount(
; CHECK-NEXT: ret i32 0
;
%B = ashr i32 undef, %A ;; top %A bits must be equal, so not undef
ret i32 %B
}
define i32 @ashr_all_ones(i32 %A) {
; CHECK-LABEL: @ashr_all_ones(
; CHECK-NEXT: ret i32 -1
;
%B = ashr i32 -1, %A
ret i32 %B
}
define <3 x i8> @ashr_all_ones_vec_with_poison_elts(<3 x i8> %x, <3 x i8> %y) {
; CHECK-LABEL: @ashr_all_ones_vec_with_poison_elts(
; CHECK-NEXT: ret <3 x i8> <i8 -1, i8 -1, i8 -1>
;
%sh = ashr <3 x i8> <i8 poison, i8 -1, i8 poison>, %y
ret <3 x i8> %sh
}
define i8 @lshr_by_sext_bool(i1 %x, i8 %y) {
; CHECK-LABEL: @lshr_by_sext_bool(
; CHECK-NEXT: ret i8 [[Y:%.*]]
;
%s = sext i1 %x to i8
%r = lshr i8 %y, %s
ret i8 %r
}
define <2 x i8> @lshr_by_sext_bool_vec(<2 x i1> %x, <2 x i8> %y) {
; CHECK-LABEL: @lshr_by_sext_bool_vec(
; CHECK-NEXT: ret <2 x i8> [[Y:%.*]]
;
%s = sext <2 x i1> %x to <2 x i8>
%r = lshr <2 x i8> %y, %s
ret <2 x i8> %r
}
define i8 @ashr_by_sext_bool(i1 %x, i8 %y) {
; CHECK-LABEL: @ashr_by_sext_bool(
; CHECK-NEXT: ret i8 [[Y:%.*]]
;
%s = sext i1 %x to i8
%r = ashr i8 %y, %s
ret i8 %r
}
define <2 x i8> @ashr_by_sext_bool_vec(<2 x i1> %x, <2 x i8> %y) {
; CHECK-LABEL: @ashr_by_sext_bool_vec(
; CHECK-NEXT: ret <2 x i8> [[Y:%.*]]
;
%s = sext <2 x i1> %x to <2 x i8>
%r = ashr <2 x i8> %y, %s
ret <2 x i8> %r
}
define i8 @shl_by_sext_bool(i1 %x, i8 %y) {
; CHECK-LABEL: @shl_by_sext_bool(
; CHECK-NEXT: ret i8 [[Y:%.*]]
;
%s = sext i1 %x to i8
%r = shl i8 %y, %s
ret i8 %r
}
define <2 x i8> @shl_by_sext_bool_vec(<2 x i1> %x, <2 x i8> %y) {
; CHECK-LABEL: @shl_by_sext_bool_vec(
; CHECK-NEXT: ret <2 x i8> [[Y:%.*]]
;
%s = sext <2 x i1> %x to <2 x i8>
%r = shl <2 x i8> %y, %s
ret <2 x i8> %r
}
define i64 @shl_or_shr(i32 %a, i32 %b) {
; CHECK-LABEL: @shl_or_shr(
; CHECK-NEXT: [[T1:%.*]] = zext i32 [[A:%.*]] to i64
; CHECK-NEXT: ret i64 [[T1]]
;
%t1 = zext i32 %a to i64
%t2 = zext i32 %b to i64
%t3 = shl nuw i64 %t1, 32
%t4 = or i64 %t2, %t3
%t5 = lshr i64 %t4, 32
ret i64 %t5
}
; Since shift count of shl is smaller than the size of %b, OR cannot be eliminated.
define i64 @shl_or_shr2(i32 %a, i32 %b) {
; CHECK-LABEL: @shl_or_shr2(
; CHECK-NEXT: [[T1:%.*]] = zext i32 [[A:%.*]] to i64
; CHECK-NEXT: [[T2:%.*]] = zext i32 [[B:%.*]] to i64
; CHECK-NEXT: [[T3:%.*]] = shl nuw i64 [[T1]], 31
; CHECK-NEXT: [[T4:%.*]] = or i64 [[T2]], [[T3]]
; CHECK-NEXT: [[T5:%.*]] = lshr i64 [[T4]], 31
; CHECK-NEXT: ret i64 [[T5]]
;
%t1 = zext i32 %a to i64
%t2 = zext i32 %b to i64
%t3 = shl nuw i64 %t1, 31
%t4 = or i64 %t2, %t3
%t5 = lshr i64 %t4, 31
ret i64 %t5
}
; Unit test for vector integer
define <2 x i64> @shl_or_shr1v(<2 x i32> %a, <2 x i32> %b) {
; CHECK-LABEL: @shl_or_shr1v(
; CHECK-NEXT: [[T1:%.*]] = zext <2 x i32> [[A:%.*]] to <2 x i64>
; CHECK-NEXT: ret <2 x i64> [[T1]]
;
%t1 = zext <2 x i32> %a to <2 x i64>
%t2 = zext <2 x i32> %b to <2 x i64>
%t3 = shl nuw <2 x i64> %t1, <i64 32, i64 32>
%t4 = or <2 x i64> %t3, %t2
%t5 = lshr <2 x i64> %t4, <i64 32, i64 32>
ret <2 x i64> %t5
}
; Negative unit test for vector integer
define <2 x i64> @shl_or_shr2v(<2 x i32> %a, <2 x i32> %b) {
; CHECK-LABEL: @shl_or_shr2v(
; CHECK-NEXT: [[T1:%.*]] = zext <2 x i32> [[A:%.*]] to <2 x i64>
; CHECK-NEXT: [[T2:%.*]] = zext <2 x i32> [[B:%.*]] to <2 x i64>
; CHECK-NEXT: [[T3:%.*]] = shl nuw <2 x i64> [[T1]], <i64 31, i64 31>
; CHECK-NEXT: [[T4:%.*]] = or <2 x i64> [[T2]], [[T3]]
; CHECK-NEXT: [[T5:%.*]] = lshr <2 x i64> [[T4]], <i64 31, i64 31>
; CHECK-NEXT: ret <2 x i64> [[T5]]
;
%t1 = zext <2 x i32> %a to <2 x i64>
%t2 = zext <2 x i32> %b to <2 x i64>
%t3 = shl nuw <2 x i64> %t1, <i64 31, i64 31>
%t4 = or <2 x i64> %t2, %t3
%t5 = lshr <2 x i64> %t4, <i64 31, i64 31>
ret <2 x i64> %t5
}
define i32 @poison(i32 %x) {
; CHECK-LABEL: @poison(
; CHECK-NEXT: ret i32 poison
;
%v = lshr i32 %x, poison
ret i32 %v
}
define i32 @poison2(i32 %x) {
; CHECK-LABEL: @poison2(
; CHECK-NEXT: ret i32 poison
;
%v = ashr i32 %x, poison
ret i32 %v
}
define i32 @poison3(i32 %x) {
; CHECK-LABEL: @poison3(
; CHECK-NEXT: ret i32 poison
;
%v = shl i32 %x, poison
ret i32 %v
}
define i32 @poison4(i32 %x) {
; CHECK-LABEL: @poison4(
; CHECK-NEXT: ret i32 poison
;
%v = lshr i32 poison, %x
ret i32 %v
}
define i32 @poison5(i32 %x) {
; CHECK-LABEL: @poison5(
; CHECK-NEXT: ret i32 poison
;
%v = ashr i32 poison, %x
ret i32 %v
}
define i32 @poison6(i32 %x) {
; CHECK-LABEL: @poison6(
; CHECK-NEXT: ret i32 poison
;
%v = shl i32 poison, %x
ret i32 %v
}
define i32 @all_ones_left_right(i32 %x) {
; CHECK-LABEL: @all_ones_left_right(
; CHECK-NEXT: ret i32 -1
;
%left = shl i32 -1, %x
%right = ashr i32 %left, %x
ret i32 %right
}
define <2 x i7> @all_ones_left_right_splat(<2 x i7> %x) {
; CHECK-LABEL: @all_ones_left_right_splat(
; CHECK-NEXT: ret <2 x i7> <i7 -1, i7 -1>
;
%left = shl <2 x i7> <i7 -1, i7 -1>, %x
%right = ashr <2 x i7> %left, %x
ret <2 x i7> %right
}
; Poison could propagate, but undef must not.
define <3 x i7> @all_ones_left_right_splat_undef_elt(<3 x i7> %x) {
; CHECK-LABEL: @all_ones_left_right_splat_undef_elt(
; CHECK-NEXT: [[LEFT:%.*]] = shl <3 x i7> <i7 undef, i7 -1, i7 undef>, [[X:%.*]]
; CHECK-NEXT: [[RIGHT:%.*]] = ashr <3 x i7> [[LEFT]], [[X]]
; CHECK-NEXT: ret <3 x i7> [[RIGHT]]
;
%left = shl <3 x i7> <i7 undef, i7 -1, i7 undef>, %x
%right = ashr <3 x i7> %left, %x
ret <3 x i7> %right
}
define <3 x i7> @all_ones_left_right_splat_poison__elt(<3 x i7> %x) {
; CHECK-LABEL: @all_ones_left_right_splat_poison__elt(
; CHECK-NEXT: ret <3 x i7> <i7 -1, i7 -1, i7 -1>
;
%left = shl <3 x i7> <i7 poison, i7 -1, i7 poison>, %x
%right = ashr <3 x i7> %left, %x
ret <3 x i7> %right
}
; negative test - must have -1
define i32 @almost_all_ones_left_right(i32 %x) {
; CHECK-LABEL: @almost_all_ones_left_right(
; CHECK-NEXT: [[LEFT:%.*]] = shl i32 -2, [[X:%.*]]
; CHECK-NEXT: [[RIGHT:%.*]] = ashr i32 [[LEFT]], [[X]]
; CHECK-NEXT: ret i32 [[RIGHT]]
;
%left = shl i32 -2, %x
%right = ashr i32 %left, %x
ret i32 %right
}
; negative test - must have same shift amount
define i32 @all_ones_left_right_not_same_shift(i32 %x, i32 %y) {
; CHECK-LABEL: @all_ones_left_right_not_same_shift(
; CHECK-NEXT: [[LEFT:%.*]] = shl i32 -1, [[X:%.*]]
; CHECK-NEXT: [[RIGHT:%.*]] = ashr i32 [[LEFT]], [[Y:%.*]]
; CHECK-NEXT: ret i32 [[RIGHT]]
;
%left = shl i32 -1, %x
%right = ashr i32 %left, %y
ret i32 %right
}
; shift by splat of bitwidth or more is poison
define <vscale x 4 x i16> @lshr_scalable_overshift(<vscale x 4 x i16> %va) {
; CHECK-LABEL: @lshr_scalable_overshift(
; CHECK-NEXT: ret <vscale x 4 x i16> poison
;
%vc = lshr <vscale x 4 x i16> %va, splat (i16 16)
ret <vscale x 4 x i16> %vc
}
; shl nsw+nuw is 0
define i8 @shl_nsw_nuw_7_eq_0(i8 %x) {
; CHECK-LABEL: @shl_nsw_nuw_7_eq_0(
; CHECK-NEXT: ret i8 0
;
%y = shl nsw nuw i8 %x, 7
ret i8 %y
}
; Make sure we match the element width
define <2 x i8> @shl_vec_nsw_nuw_7_eq_0(<2 x i8> %x) {
; CHECK-LABEL: @shl_vec_nsw_nuw_7_eq_0(
; CHECK-NEXT: ret <2 x i8> zeroinitializer
;
%y = shl nsw nuw <2 x i8> %x, <i8 7, i8 7>
ret <2 x i8> %y
}
; negative test (missing nuw)
define i8 @shl_nsw_7_fail_missing_nuw(i8 %x) {
; CHECK-LABEL: @shl_nsw_7_fail_missing_nuw(
; CHECK-NEXT: [[Y:%.*]] = shl nsw i8 [[X:%.*]], 7
; CHECK-NEXT: ret i8 [[Y]]
;
%y = shl nsw i8 %x, 7
ret i8 %y
}
; negative test (missing nsw)
define i8 @shl_nuw_7_fail_missing_nsw(i8 %x) {
; CHECK-LABEL: @shl_nuw_7_fail_missing_nsw(
; CHECK-NEXT: [[Y:%.*]] = shl nuw i8 [[X:%.*]], 7
; CHECK-NEXT: ret i8 [[Y]]
;
%y = shl nuw i8 %x, 7
ret i8 %y
}
; negative test (shift value != bitwdth - 1)
define i8 @shl_nsw_nuw_6_do_nothing(i8 %x) {
; CHECK-LABEL: @shl_nsw_nuw_6_do_nothing(
; CHECK-NEXT: [[Y:%.*]] = shl nuw nsw i8 [[X:%.*]], 6
; CHECK-NEXT: ret i8 [[Y]]
;
%y = shl nsw nuw i8 %x, 6
ret i8 %y
}