The greedy rewriter is used in many different flows and it has a lot of
convenience (work list management, debugging actions, tracing, etc). But
it combines two kinds of greedy behavior 1) how ops are matched, 2)
folding wherever it can.
These are independent forms of greedy and leads to inefficiency. E.g.,
cases where one need to create different phases in lowering and is
required to applying patterns in specific order split across different
passes. Using the driver one ends up needlessly retrying folding/having
multiple rounds of folding attempts, where one final run would have
sufficed.
Of course folks can locally avoid this behavior by just building their
own, but this is also a common requested feature that folks keep on
working around locally in suboptimal ways.
For downstream users, there should be no behavioral change. Updating
from the deprecated should just be a find and replace (e.g., `find ./
-type f -exec sed -i
's|applyPatternsAndFoldGreedily|applyPatternsGreedily|g' {} \;` variety)
as the API arguments hasn't changed between the two.
158 lines
5.3 KiB
C++
158 lines
5.3 KiB
C++
//===- TestMakeIsolatedFromAbove.cpp - Test makeIsolatedFromAbove method -===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "TestDialect.h"
|
|
#include "TestOps.h"
|
|
#include "mlir/Dialect/Func/IR/FuncOps.h"
|
|
#include "mlir/IR/PatternMatch.h"
|
|
#include "mlir/Pass/Pass.h"
|
|
#include "mlir/Transforms/GreedyPatternRewriteDriver.h"
|
|
#include "mlir/Transforms/RegionUtils.h"
|
|
|
|
using namespace mlir;
|
|
|
|
/// Helper function to call the `makeRegionIsolatedFromAbove` to convert
|
|
/// `test.one_region_op` to `test.isolated_one_region_op`.
|
|
static LogicalResult
|
|
makeIsolatedFromAboveImpl(RewriterBase &rewriter,
|
|
test::OneRegionWithOperandsOp regionOp,
|
|
llvm::function_ref<bool(Operation *)> callBack) {
|
|
Region ®ion = regionOp.getRegion();
|
|
SmallVector<Value> capturedValues =
|
|
makeRegionIsolatedFromAbove(rewriter, region, callBack);
|
|
SmallVector<Value> operands = regionOp.getOperands();
|
|
operands.append(capturedValues);
|
|
auto isolatedRegionOp =
|
|
rewriter.create<test::IsolatedOneRegionOp>(regionOp.getLoc(), operands);
|
|
rewriter.inlineRegionBefore(region, isolatedRegionOp.getRegion(),
|
|
isolatedRegionOp.getRegion().begin());
|
|
rewriter.eraseOp(regionOp);
|
|
return success();
|
|
}
|
|
|
|
namespace {
|
|
|
|
/// Simple test for making region isolated from above without cloning any
|
|
/// operations.
|
|
struct SimpleMakeIsolatedFromAbove
|
|
: OpRewritePattern<test::OneRegionWithOperandsOp> {
|
|
using OpRewritePattern::OpRewritePattern;
|
|
|
|
LogicalResult matchAndRewrite(test::OneRegionWithOperandsOp regionOp,
|
|
PatternRewriter &rewriter) const override {
|
|
return makeIsolatedFromAboveImpl(rewriter, regionOp,
|
|
[](Operation *) { return false; });
|
|
}
|
|
};
|
|
|
|
/// Test for making region isolated from above while clong operations
|
|
/// with no operands.
|
|
struct MakeIsolatedFromAboveAndCloneOpsWithNoOperands
|
|
: OpRewritePattern<test::OneRegionWithOperandsOp> {
|
|
using OpRewritePattern::OpRewritePattern;
|
|
|
|
LogicalResult matchAndRewrite(test::OneRegionWithOperandsOp regionOp,
|
|
PatternRewriter &rewriter) const override {
|
|
return makeIsolatedFromAboveImpl(rewriter, regionOp, [](Operation *op) {
|
|
return op->getNumOperands() == 0;
|
|
});
|
|
}
|
|
};
|
|
|
|
/// Test for making region isolated from above while clong operations
|
|
/// with no operands.
|
|
struct MakeIsolatedFromAboveAndCloneOpsWithOperands
|
|
: OpRewritePattern<test::OneRegionWithOperandsOp> {
|
|
using OpRewritePattern::OpRewritePattern;
|
|
|
|
LogicalResult matchAndRewrite(test::OneRegionWithOperandsOp regionOp,
|
|
PatternRewriter &rewriter) const override {
|
|
return makeIsolatedFromAboveImpl(rewriter, regionOp,
|
|
[](Operation *op) { return true; });
|
|
}
|
|
};
|
|
|
|
/// Test pass for testing the `makeIsolatedFromAbove` function.
|
|
struct TestMakeIsolatedFromAbovePass
|
|
: public PassWrapper<TestMakeIsolatedFromAbovePass,
|
|
OperationPass<func::FuncOp>> {
|
|
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestMakeIsolatedFromAbovePass)
|
|
|
|
TestMakeIsolatedFromAbovePass() = default;
|
|
TestMakeIsolatedFromAbovePass(const TestMakeIsolatedFromAbovePass &pass)
|
|
: PassWrapper(pass) {}
|
|
|
|
StringRef getArgument() const final {
|
|
return "test-make-isolated-from-above";
|
|
}
|
|
|
|
StringRef getDescription() const final {
|
|
return "Test making a region isolated from above";
|
|
}
|
|
|
|
Option<bool> simple{
|
|
*this, "simple",
|
|
llvm::cl::desc("Test simple case with no cloning of operations"),
|
|
llvm::cl::init(false)};
|
|
|
|
Option<bool> cloneOpsWithNoOperands{
|
|
*this, "clone-ops-with-no-operands",
|
|
llvm::cl::desc("Test case with cloning of operations with no operands"),
|
|
llvm::cl::init(false)};
|
|
|
|
Option<bool> cloneOpsWithOperands{
|
|
*this, "clone-ops-with-operands",
|
|
llvm::cl::desc("Test case with cloning of operations with no operands"),
|
|
llvm::cl::init(false)};
|
|
|
|
void runOnOperation() override;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
void TestMakeIsolatedFromAbovePass::runOnOperation() {
|
|
MLIRContext *context = &getContext();
|
|
func::FuncOp funcOp = getOperation();
|
|
|
|
if (simple) {
|
|
RewritePatternSet patterns(context);
|
|
patterns.insert<SimpleMakeIsolatedFromAbove>(context);
|
|
if (failed(applyPatternsGreedily(funcOp, std::move(patterns)))) {
|
|
return signalPassFailure();
|
|
}
|
|
return;
|
|
}
|
|
|
|
if (cloneOpsWithNoOperands) {
|
|
RewritePatternSet patterns(context);
|
|
patterns.insert<MakeIsolatedFromAboveAndCloneOpsWithNoOperands>(context);
|
|
if (failed(applyPatternsGreedily(funcOp, std::move(patterns)))) {
|
|
return signalPassFailure();
|
|
}
|
|
return;
|
|
}
|
|
|
|
if (cloneOpsWithOperands) {
|
|
RewritePatternSet patterns(context);
|
|
patterns.insert<MakeIsolatedFromAboveAndCloneOpsWithOperands>(context);
|
|
if (failed(applyPatternsGreedily(funcOp, std::move(patterns)))) {
|
|
return signalPassFailure();
|
|
}
|
|
return;
|
|
}
|
|
}
|
|
|
|
namespace mlir {
|
|
namespace test {
|
|
void registerTestMakeIsolatedFromAbovePass() {
|
|
PassRegistration<TestMakeIsolatedFromAbovePass>();
|
|
}
|
|
} // namespace test
|
|
} // namespace mlir
|