1b4f161978
Testing `openmp` on Solaris/amd64 shows a large number of failures, all
due to the same issue:
```
# .---command stderr------------
# | openmp/runtime/test/ompt/misc/interoperability.cpp:67:16: error: CHECK-SAME: expected string not found in input
# | // CHECK-SAME: parent_task_frame.reenter={{0x[0-f]+}}
# | ^
# | <stdin>:5:101: note: scanning from here
# | 281474976710658: ompt_event_parallel_begin: parent_task_id=281474976710659, parent_task_frame.exit=0, parent_task_frame.reenter=7fffbedffe90, parallel_id=281474976710661, requested_team_size=2, codeptr_ra=408b8e, invoker=2
```
The testsuite expects pointers to be printed with a `0x` prefix when
using the `%p` format, while Solaris `libc` just prints them in hex
without a prefix.
However, this difference is completely benign. ISO C (up to C23,
7.23.6.1) states
```
p The argument shall be a pointer to void or a pointer to a character
type. The value of the pointer is converted to a sequence of printing
characters, in an implementation-defined manner.
```
I saw two ways around this:
- replace every instance of `%p` with a macro (`KMP_PTR_FMT`, defined as
`"%p"` or `"0x%p" as appropriate), or
- adjust the testsuite to make the `0x` prefix optional
The second route seemed less intrusive and more readable, so that's what
this patch does. While large, it's also completely mechanical.
Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.
36 lines
1001 B
C
36 lines
1001 B
C
// RUN: %libomp-compile-and-run 2>&1 | sort | FileCheck %s
|
|
// REQUIRES: ompt
|
|
|
|
#include <string.h>
|
|
#include <stdio.h>
|
|
#include "callback.h"
|
|
|
|
// TODO: use error directive when compiler suppors
|
|
typedef void ident_t;
|
|
extern void __kmpc_error(ident_t *, int, const char *);
|
|
|
|
int main() {
|
|
#pragma omp parallel num_threads(2)
|
|
{
|
|
if (omp_get_thread_num() == 0) {
|
|
const char *msg = "User message goes here";
|
|
printf("0: Message length=%" PRIu64 "\n", (uint64_t)strlen(msg));
|
|
__kmpc_error(NULL, ompt_warning, msg);
|
|
}
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
// CHECK: {{^}}0: Message length=[[LENGTH:[0-9]+]]
|
|
// CHECK: {{^}}0: NULL_POINTER=[[NULL:.*$]]
|
|
|
|
// CHECK: {{^}}[[PRIMARY_ID:[0-9]+]]: ompt_event_implicit_task_begin
|
|
// CHECK: {{^}}[[PRIMARY_ID]]: ompt_event_runtime_error
|
|
// CHECK-SAME: severity=1
|
|
// CHECK-SAME: message=User message goes here
|
|
// CHECK-SAME: length=[[LENGTH]]
|
|
// CHECK-SAME: codeptr_ra={{(0x)?[0-f]+}}
|
|
|
|
// Message from runtime
|
|
// CHECK: {{^}}OMP: Warning{{.*}}User message goes here
|