1b4f161978
Testing `openmp` on Solaris/amd64 shows a large number of failures, all
due to the same issue:
```
# .---command stderr------------
# | openmp/runtime/test/ompt/misc/interoperability.cpp:67:16: error: CHECK-SAME: expected string not found in input
# | // CHECK-SAME: parent_task_frame.reenter={{0x[0-f]+}}
# | ^
# | <stdin>:5:101: note: scanning from here
# | 281474976710658: ompt_event_parallel_begin: parent_task_id=281474976710659, parent_task_frame.exit=0, parent_task_frame.reenter=7fffbedffe90, parallel_id=281474976710661, requested_team_size=2, codeptr_ra=408b8e, invoker=2
```
The testsuite expects pointers to be printed with a `0x` prefix when
using the `%p` format, while Solaris `libc` just prints them in hex
without a prefix.
However, this difference is completely benign. ISO C (up to C23,
7.23.6.1) states
```
p The argument shall be a pointer to void or a pointer to a character
type. The value of the pointer is converted to a sequence of printing
characters, in an implementation-defined manner.
```
I saw two ways around this:
- replace every instance of `%p` with a macro (`KMP_PTR_FMT`, defined as
`"%p"` or `"0x%p" as appropriate), or
- adjust the testsuite to make the `0x` prefix optional
The second route seemed less intrusive and more readable, so that's what
this patch does. While large, it's also completely mechanical.
Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.
81 lines
3.4 KiB
C
81 lines
3.4 KiB
C
// RUN: %libomp-compile-and-run | %sort-threads | FileCheck %s
|
|
// REQUIRES: ompt
|
|
|
|
#include "callback.h"
|
|
#include <omp.h>
|
|
|
|
int main()
|
|
{
|
|
#pragma omp parallel num_threads(1)
|
|
{
|
|
// region 0
|
|
#pragma omp parallel num_threads(1)
|
|
{
|
|
// region 1
|
|
#pragma omp parallel num_threads(1)
|
|
{
|
|
// region 2
|
|
// region 2's implicit task
|
|
print_ids(0);
|
|
// region 1's implicit task
|
|
print_ids(1);
|
|
// region 0's implicit task
|
|
print_ids(2);
|
|
// initial task
|
|
print_ids(3);
|
|
}
|
|
}
|
|
}
|
|
|
|
// Check if libomp supports the callbacks for this test.
|
|
// CHECK-NOT: {{^}}0: Could not register callback 'ompt_callback_task_create'
|
|
// CHECK-NOT: {{^}}0: Could not register callback 'ompt_callback_implicit_task'
|
|
|
|
|
|
// CHECK: {{^}}0: NULL_POINTER=[[NULL:.*$]]
|
|
// CHECK: {{^}}[[MASTER_ID:[0-9]+]]: ompt_event_initial_task_begin: parallel_id=[[INITIAL_PARALLEL_ID:[0-9]+]], task_id=[[INITIAL_TASK_ID:[0-9]+]], actual_parallelism=1, index=1, flags=1
|
|
|
|
// region 0
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_parallel_begin
|
|
// CHECK-SAME: parent_task_frame.exit=[[NULL]], parent_task_frame.reenter=[[INITIAL_TASK_FRAME_ENTER:(0x)?[0-f]+]],
|
|
// CHECK-SAME: parallel_id=[[PARALLEL_ID_0:[0-9]+]]
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_implicit_task_begin: parallel_id=[[PARALLEL_ID_0]], task_id=[[TASK_ID_0:[0-9]+]]
|
|
|
|
// region 1
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_parallel_begin
|
|
// CHECK-SAME: parent_task_frame.exit=[[REGION_0_FRAME_EXIT:(0x)?[0-f]+]], parent_task_frame.reenter=[[REGION_0_FRAME_ENTER:(0x)?[0-f]+]],
|
|
// CHECK-SAME: parallel_id=[[PARALLEL_ID_1:[0-9]+]]
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_implicit_task_begin: parallel_id=[[PARALLEL_ID_1]], task_id=[[TASK_ID_1:[0-9]+]]
|
|
|
|
// region 2
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_parallel_begin
|
|
// CHECK-SAME: parent_task_frame.exit=[[REGION_1_FRAME_EXIT:(0x)?[0-f]+]], parent_task_frame.reenter=[[REGION_1_FRAME_ENTER:(0x)?[0-f]+]],
|
|
// CHECK-SAME: parallel_id=[[PARALLEL_ID_2:[0-9]+]]
|
|
// CHECK: {{^}}[[MASTER_ID]]: ompt_event_implicit_task_begin: parallel_id=[[PARALLEL_ID_2]], task_id=[[TASK_ID_2:[0-9]+]]
|
|
|
|
// region 2's implicit task information (exit frame should be set, while enter should be NULL)
|
|
// CHECK: {{^}}[[MASTER_ID]]: task level 0: parallel_id=[[PARALLEL_ID_2]], task_id=[[TASK_ID_2]]
|
|
// CHECK-SAME: exit_frame={{(0x)?[0-f]+}}
|
|
// CHECK-SAME: reenter_frame=[[NULL]]
|
|
// CHECK-SAME: task_type=ompt_task_implicit
|
|
|
|
// region 1's implicit task information (both exit and enter frames should be set)
|
|
// CHECK: {{^}}[[MASTER_ID]]: task level 1: parallel_id=[[PARALLEL_ID_1]], task_id=[[TASK_ID_1]]
|
|
// CHECK-SAME: exit_frame=[[REGION_1_FRAME_EXIT]]
|
|
// CHECK-SAME: reenter_frame=[[REGION_1_FRAME_ENTER]]
|
|
// CHECK-SAME: task_type=ompt_task_implicit
|
|
|
|
// region 0's implicit task information (both exit and enter frames should be set)
|
|
// CHECK: {{^}}[[MASTER_ID]]: task level 2: parallel_id=[[PARALLEL_ID_0]], task_id=[[TASK_ID_0]]
|
|
// CHECK-SAME: exit_frame=[[REGION_0_FRAME_EXIT]]
|
|
// CHECK-SAME: reenter_frame=[[REGION_0_FRAME_ENTER]]
|
|
// CHECK-SAME: task_type=ompt_task_implicit
|
|
|
|
// region 0's initial task information (both exit and enter frames should be set)
|
|
// CHECK: {{^}}[[MASTER_ID]]: task level 3: parallel_id=[[INITIAL_PARALLEL_ID]], task_id=[[INITIAL_TASK_ID]]
|
|
// CHECK-SAME: exit_frame=[[NULL]]
|
|
// CHECK-SAME: reenter_frame=[[INITIAL_TASK_FRAME_ENTER]]
|
|
// CHECK-SAME: task_type=ompt_task_initial
|
|
|
|
return 0;
|
|
} |