9c73925226
Summary: This patch addresses an ambiguity in how our existing tests invoke the compiler. Roughly two thirds of our current "shell" tests invoke the compiler to build the executables for the host. However, there is also a significant number of tests which don't build a host binary (because they don't need to run it) and instead they hardcode a certain target. We also have code which adds a bunch of default arguments to the %clang substitutions. However, most of these arguments only really make sense for the host compilation. So far, this has worked mostly ok, because the arguments we were adding were not conflicting with the target-hardcoding tests (though they did provoke an occasional "argument unused" warning). However, this started to break down when we wanted to use target-hardcoding clang-cl tests (D69031) because clang-cl has a substantially different command line, and it was getting very confused by some of the arguments we were adding on non-windows hosts. This patch avoid this problem by creating separate %clang(xx,_cl)_host substutitions, which are specifically meant to be used for compiling host binaries. All funny host-specific options are moved there. To ensure that the regular %clang substitutions are not used for compiling host binaries (skipping the extra arguments) I employ a little hac^H^H^Htrick -- I add an invalid --target argument to the %clang substitution, which means that one has to use an explicit --target in order for the compilation to succeed. Reviewers: JDevlieghere, aprantl, mstorsjo, espindola Subscribers: emaste, arichardson, MaskRay, jfb, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D69619
77 lines
2.2 KiB
Plaintext
77 lines
2.2 KiB
Plaintext
# RUN: %clang_host %p/Inputs/stop-hook.c -g -o %t
|
|
# Test setting stop-hook per-function
|
|
# RUN: %lldb -b -s %p/Inputs/stop-hook-1.lldbinit -s %s -f %t \
|
|
# RUN: | FileCheck --check-prefix=CHECK --check-prefix=CHECK-FUNC %s
|
|
# Test setting stop-hook per-line range
|
|
# RUN: %lldb -b -s %p/Inputs/stop-hook-2.lldbinit -s %s -f %t | FileCheck %s
|
|
# Test setting stop-hook with multi-line expression
|
|
# RUN: %lldb -b -s %p/Inputs/stop-hook-3.lldbinit -s %s -f %t | FileCheck %s
|
|
# This test is not "unsupported" on Windows, but it fails because "expr ptr"
|
|
# does not evaluate correctly. However, the error message contains the expected
|
|
# string, so the test "passes" despite the fact that the commands failed
|
|
# llvm.org/pr40119
|
|
# UNSUPPORTED: system-windows
|
|
|
|
break set -f stop-hook.c -p "// Set breakpoint here to test target stop-hook"
|
|
break set -f stop-hook.c -p "// Another breakpoint which is outside of the stop-hook range"
|
|
target stop-hook list
|
|
|
|
# CHECK: Hook: 1
|
|
# CHECK-NEXT: State: enabled
|
|
# CHECK-NEXT: Specifier:
|
|
# CHECK-FUNC-NEXT: Function: b.
|
|
# CHECK-NEXT: Commands:
|
|
# CHECK-NEXT: expr ptr
|
|
|
|
target stop-hook disable
|
|
|
|
target stop-hook list
|
|
# CHECK: Hook: 1
|
|
# CHECK-NEXT: State: disabled
|
|
# CHECK-NEXT: Specifier:
|
|
# CHECK-FUNC-NEXT: Function: b.
|
|
# CHECK-NEXT: Commands:
|
|
# CHECK-NEXT: expr ptr
|
|
|
|
target stop-hook enable
|
|
|
|
target stop-hook list
|
|
# CHECK: Hook: 1
|
|
# CHECK-NEXT: State: enabled
|
|
# CHECK-NEXT: Specifier:
|
|
# CHECK-FUNC-NEXT: Function: b.
|
|
# CHECK-NEXT: Commands:
|
|
# CHECK-NEXT: expr ptr
|
|
|
|
run
|
|
# Stopping inside of the stop hook range
|
|
# CHECK: (lldb) run
|
|
# CHECK-NEXT: (void *) $0 = 0x
|
|
|
|
thread step-over
|
|
# Stepping inside of the stop hook range
|
|
# CHECK: (lldb) thread step-over
|
|
# CHECK-NEXT: (void *) $1 = 0x
|
|
# CHECK: ->{{.*}} // We should stop here after stepping.
|
|
|
|
process continue
|
|
# Stopping outside of the stop hook range
|
|
# CHECK: (lldb) process continue
|
|
# CHECK-NOT: (void *)
|
|
# CHECK: ->{{.*}} // Another breakpoint which is outside of the stop-hook range.
|
|
|
|
thread step-over
|
|
# Stepping inside of the stop hook range
|
|
# CHECK: (lldb) thread step-over
|
|
# CHECK-NOT: (void *)
|
|
|
|
settings set auto-confirm true
|
|
target stop-hook delete
|
|
|
|
target stop-hook list
|
|
# CHECK: (lldb) target stop-hook list
|
|
# CHECK-NOT: Hook: 1
|
|
# CHECK: No stop hooks
|
|
# CHECK-NOT: Hook: 1
|
|
|