13e1cf8065
This reverts commit 3e928c4b9d.
This fixes an issue seen on Windows where we did not properly
get the section names of regions if they overlapped. Windows
has regions like:
[0x00007fff928db000-0x00007fff949a0000) ---
[0x00007fff949a0000-0x00007fff949a1000) r-- PECOFF header
[0x00007fff949a0000-0x00007fff94a3d000) r-x .hexpthk
[0x00007fff949a0000-0x00007fff94a85000) r-- .rdata
[0x00007fff949a0000-0x00007fff94a88000) rw- .data
[0x00007fff949a0000-0x00007fff94a94000) r-- .pdata
[0x00007fff94a94000-0x00007fff95250000) ---
I assumed that you could just resolve the address and get the section
name using the start of the region but here you'd always get
"PECOFF header" because they all have the same start point.
The usual command repeating loop used the end address of the previous
region when requesting the next, or getting the section name.
So I've matched this in the --all scenario.
In the example above, somehow asking for the region at
0x00007fff949a1000 would get you a region that starts at
0x00007fff949a0000 but has a different end point. Using the load
address you get (what I assume is) the correct section name.
89 lines
3.4 KiB
Python
89 lines
3.4 KiB
Python
"""
|
|
Test the 'memory region' command.
|
|
"""
|
|
|
|
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class MemoryCommandRegion(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
def setUp(self):
|
|
TestBase.setUp(self)
|
|
# Find the line number to break for main.c.
|
|
self.line = line_number(
|
|
'main.cpp',
|
|
'// Run here before printing memory regions')
|
|
|
|
def test_help(self):
|
|
""" Test that help shows you must have one of address or --all, not both."""
|
|
self.expect("help memory region",
|
|
substrs=["memory region <address-expression>",
|
|
"memory region -a"])
|
|
|
|
def test(self):
|
|
self.build()
|
|
|
|
# Set breakpoint in main and run
|
|
self.runCmd("file " + self.getBuildArtifact("a.out"), CURRENT_EXECUTABLE_SET)
|
|
lldbutil.run_break_set_by_file_and_line(
|
|
self, "main.cpp", self.line, num_expected_locations=-1, loc_exact=True)
|
|
|
|
self.runCmd("run", RUN_SUCCEEDED)
|
|
|
|
interp = self.dbg.GetCommandInterpreter()
|
|
result = lldb.SBCommandReturnObject()
|
|
|
|
# Test that the first 'memory region' command prints the usage.
|
|
interp.HandleCommand("memory region", result)
|
|
self.assertFalse(result.Succeeded())
|
|
self.assertEqual(result.GetError(),
|
|
"error: 'memory region' takes one argument or \"--all\" option:\n"
|
|
"Usage: memory region <address-expression> (or --all)\n")
|
|
|
|
# We allow --all or an address argument, not both
|
|
interp.HandleCommand("memory region --all 0", result)
|
|
self.assertFalse(result.Succeeded())
|
|
self.assertRegexpMatches(result.GetError(),
|
|
"The \"--all\" option cannot be used when an address argument is given")
|
|
|
|
# Test that when the address fails to parse, we show an error and do not continue
|
|
interp.HandleCommand("memory region not_an_address", result)
|
|
self.assertFalse(result.Succeeded())
|
|
self.assertEqual(result.GetError(),
|
|
"error: invalid address argument \"not_an_address\": address expression \"not_an_address\" evaluation failed\n")
|
|
|
|
# Accumulate the results to compare with the --all output
|
|
all_regions = ""
|
|
|
|
# Now let's print the memory region starting at 0 which should always work.
|
|
interp.HandleCommand("memory region 0x0", result)
|
|
self.assertTrue(result.Succeeded())
|
|
self.assertRegexpMatches(result.GetOutput(), "\\[0x0+-")
|
|
all_regions += result.GetOutput()
|
|
|
|
# Keep printing memory regions until we printed all of them.
|
|
while True:
|
|
interp.HandleCommand("memory region", result)
|
|
if not result.Succeeded():
|
|
break
|
|
all_regions += result.GetOutput()
|
|
|
|
# Now that we reached the end, 'memory region' should again print the usage.
|
|
interp.HandleCommand("memory region", result)
|
|
self.assertFalse(result.Succeeded())
|
|
self.assertRegexpMatches(result.GetError(), "Usage: memory region <address\-expression> \(or \-\-all\)")
|
|
|
|
# --all should match what repeating the command gives you
|
|
interp.HandleCommand("memory region --all", result)
|
|
self.assertTrue(result.Succeeded())
|
|
self.assertEqual(result.GetOutput(), all_regions)
|