David Justo 2dc22615fd [ASan] Honor allocator_may_return_null when set through user-function and fix large alloc edge case (#117929) ...

**Related:** #117925

**About this PR:**
This PR performs 3 small but related fixes for ASan users on Windows:
1. It ensures that the `allocator_may_return_null` flag is honored when
set through the user function `__asan_default_options`. For more
details, please see: #117925
2. It adds a missing `AllocatorMayReturnNull()` check inside
`InternalAlloc` that's needed to avoid error'ing out when the allocator
_correctly_ returns `null` when `allocator_may_return_null` is set.
3. In `sanitizer_win`'s `ReturnNullptrOnOOMOrDie`, it allows returning
`null` when the last error is set to `ERROR_INVALID_PARAMETER` which may
be set by `VirtualAlloc` on WIndows when attempting to allocate
exceedingly large memory.

I've added test cases that should cover these new behaviors. Happy to
take on any feedback as well. Thank you :-)

---------

Co-authored-by: David Justo <dajusto@microsoft.com>

2024-12-11 10:21:35 +01:00

..

msvc

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

aligned_mallocs.cpp

…

allocator_may_return_null_limits.cpp

[ASan] Honor allocator_may_return_null when set through user-function and fix large alloc edge case (#117929)

2024-12-11 10:21:35 +01:00

allocators_sanity.cpp

…

beginthreadex.cpp

…

bind_io_completion_callback.cpp

…

bitfield_uaf.cpp

[asan][windows] Further relax how deep in the callstack main can be in some asan tests (#92329)

2024-05-22 17:47:20 -07:00

bitfield.cpp

…

breakpoint.cpp

…

calloc_left_oob.cpp

[asan][windows] Further relax how deep in the callstack main can be in some asan tests (#92329)

2024-05-22 17:47:20 -07:00

calloc_right_oob.cpp

[asan][windows] Further relax how deep in the callstack main can be in some asan tests (#92329)

2024-05-22 17:47:20 -07:00

calloc_uaf.cpp

[asan][windows] Further relax how deep in the callstack main can be in some asan tests (#92329)

2024-05-22 17:47:20 -07:00

coverage-basic.cpp

…

crash_read_write.cpp

…

crt_initializers.cpp

…

delay_dbghelp.cpp

[compiler-rt] [test] Remove an unintended grep parameter

2024-10-20 22:56:41 +03:00

demangled_names.cpp

…

dll_aligned_mallocs.cpp

…

dll_allocators_sanity.cpp

…

dll_global_dead_strip.c

Revert ""Reland "[asan] Remove debug tracing from report_globals (#104404)"" (#105926)

2024-08-23 23:29:09 -07:00

dll_heap_allocation.cpp

[asan][windows] Make tests more flexable (#85274)

2024-03-15 10:42:21 -07:00

dll_host.cpp

[asan][windows] Make tests more flexable (#85274)

2024-03-15 10:42:21 -07:00

dll_intercept_memchr.cpp

…

dll_intercept_memcpy_indirect.cpp

…

dll_intercept_memcpy.cpp

…

dll_intercept_memset.cpp

…

dll_intercept_strlen.cpp

…

dll_malloc_left_oob.cpp

[asan][windows] Make tests more flexable (#85274)

2024-03-15 10:42:21 -07:00

dll_malloc_uaf.cpp

[asan][windows] Make tests more flexable (#85274)

2024-03-15 10:42:21 -07:00

dll_noreturn.cpp

…

dll_null_deref.cpp

…

dll_operator_array_new_left_oob.cpp

…

dll_operator_array_new_with_dtor_left_oob.cpp

…

dll_poison_unpoison.cpp

…

dll_report_globals_symbolization_at_startup.cpp

Revert ""Reland "[asan] Remove debug tracing from report_globals (#104404)"" (#105926)

2024-08-23 23:29:09 -07:00

dll_stack_use_after_return.cpp

…

dll_thread_stack_array_left_oob.cpp

…

dll_unload.cpp

…

double_free.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

double_operator_delete.cpp

…

free_hook_realloc.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

fuse-lld-globals.cpp

…

fuse-lld.cpp

…

global_const_string_oob.cpp

…

global_const_string.cpp

…

global_dead_strip.c

Revert ""Reland "[asan] Remove debug tracing from report_globals (#104404)"" (#105926)

2024-08-23 23:29:09 -07:00

heapalloc_dll_double_free.cpp

…

heapalloc_dll_unload_realloc_uaf.cpp

…

heapalloc_doublefree.cpp

…

heapalloc_flags_fallback.cpp

…

heapalloc_huge.cpp

…

heapalloc_rtl_transfer.cpp

…

heapalloc_sanity.cpp

…

heapalloc_transfer.cpp

…

heapalloc_uaf.cpp

…

heapalloc_zero_size.cpp

…

heapalloc.cpp

…

heaprealloc_alloc_zero.cpp

…

heaprealloc_zero_size.cpp

…

heaprealloc.cpp

…

hello_world.cpp

…

illegal_instruction.cpp

…

integer_divide_by_zero.cpp

…

intercept_memcpy.cpp

…

intercept_strdup.cpp

Reapply "[sanitizer][asan][win] Intercept _strdup on Windows (#85006)

2024-03-13 16:11:21 -07:00

intercept_strlen.cpp

…

issue64990.cpp

[asan][windows] fix issue64990 test (#85137)

2024-03-13 15:34:12 -07:00

lit.local.cfg.py

…

longjmp.cpp

…

malloc_left_oob.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

malloc_right_oob.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

malloc_uaf.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

null_deref_multiple_dlls.cpp

[asan] Fix Windows tests

2024-08-08 00:17:19 -07:00

null_deref.cpp

…

oom.cpp

…

operator_array_new_left_oob.cpp

…

operator_array_new_right_oob.cpp

…

operator_array_new_uaf.cpp

…

operator_array_new_with_dtor_left_oob.cpp

…

operator_delete_wrong_argument.cpp

…

operator_new_left_oob.cpp

…

operator_new_right_oob.cpp

…

operator_new_uaf.cpp

…

queue_user_work_item_report.cpp

…

queue_user_work_item.cpp

…

realloc_left_oob.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

realloc_right_oob.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

realloc_uaf.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

recalloc_sanity.cpp

…

report_after_syminitialize.cpp

…

report_globals_reload_dll.cpp

[asan] Fix Windows tests

2024-08-08 00:17:19 -07:00

report_globals_vs_freelibrary.cpp

Revert ""Reland "[asan] Remove debug tracing from report_globals (#104404)"" (#105926)

2024-08-23 23:29:09 -07:00

rtlallocateheap_dll_unload_double_free.cpp

…

rtlallocateheap_dll_unload_realloc.cpp

…

rtlallocateheap_flags_fallback.cpp

…

rtlallocateheap_zero.cpp

…

rtlallocateheap.cpp

…

sanitizer_purge.cpp

…

shadow_conflict_32.cpp

…

shadow_mapping_failure.cpp

…

sse_misalignment.cpp

…

stack_array_left_oob.cpp

…

stack_array_right_oob.cpp

…

stack_array_sanity.cpp

…

stack_use_after_return.cpp

…

symbols_path.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

thread_simple.cpp

…

thread_stack_array_left_oob.cpp

…

thread_stack_array_right_oob.cpp

…

thread_stack_reuse.cpp

…

thread_stress.cpp

…

thread_suspended.cpp

…

unsymbolized.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

use_after_realloc.cpp

Reland [asan][windows] Eliminate the static asan runtime on windows (#107899)

2024-09-09 13:41:08 -07:00

user-exception.cpp

…

windows_h.cpp

…

wrong_downcast_on_heap.cpp

…

wrong_downcast_on_stack.cpp

…