ab930ee7ca
It turns out that the notes section for corefiles (or really any elf
file with multiple notes) is set up in such a way for LLVM formatted
output that the JSON equivalent only has the last note since the notes
are held in a dictionary with every key being Note. This pr alters the
layout for the notes to a list of dictionaries to sidestep this issue
for JSON output. Prior to this pr a note section in the output looked
like (for LLVM output):
```
Notes [
NoteSection {
Name: <?>
Offset: 0x2148
Size: 0x1F864
Note {
Owner: CORE
Data size: 0x150
Type: NT_PRSTATUS (prstatus structure)
Description data (
0000: 06000000 00000000 00000000 06000000 |................|
...
)
}
Note {
Owner: CORE
Data size: 0x88
Type: NT_PRPSINFO (prpsinfo structure)
Description data (
0000: 02440000 00000000 04054040 00000000 |.D........@@....|
....
```
But is now:
```
NoteSections [
NoteSection {
Name: <?>
Offset: 0x2148
Size: 0x1F864
Notes [
{
Owner: CORE
Data size: 0x150
Type: NT_PRSTATUS (prstatus structure)
Description data (
0000: 06000000 00000000 00000000 06000000 |................|
...
)
}
{
Owner: CORE
Data size: 0x88
Type: NT_PRPSINFO (prpsinfo structure)
Description data (
0000: 02440000 00000000 04054040 00000000 |.D........@@....|
...
```
43 lines
1.4 KiB
Plaintext
43 lines
1.4 KiB
Plaintext
## Check that a malformed NT_GNU_ABI_TAG note can be dumped without crashing.
|
|
# RUN: yaml2obj %s -o %t
|
|
# RUN: llvm-readelf --notes %t | FileCheck %s --check-prefix=GNU
|
|
# RUN: llvm-readobj --elf-output-style LLVM --notes %t | FileCheck %s --check-prefix=LLVM
|
|
## GNU binutils does not print the raw description data when encountering an
|
|
## invalid NT_GNU_ABI_TAG, but in LLVM style we print it.
|
|
|
|
# GNU: Displaying notes found in: .note.ABI-tag
|
|
# GNU-NEXT: Owner Data size Description
|
|
# GNU-NEXT: GNU 0x00000004 NT_GNU_ABI_TAG (ABI version tag)
|
|
# GNU-NEXT: <corrupt GNU_ABI_TAG>
|
|
# GNU-EMPTY:
|
|
|
|
# LLVM: NoteSections [
|
|
# LLVM-NEXT: NoteSection {
|
|
# LLVM-NEXT: Name: .note.ABI-tag
|
|
# LLVM-NEXT: Offset:
|
|
# LLVM-NEXT: Size: 0x14
|
|
# LLVM-NEXT: Notes [
|
|
# LLVM-NEXT: {
|
|
# LLVM-NEXT: Owner: GNU
|
|
# LLVM-NEXT: Data size: 0x4
|
|
# LLVM-NEXT: Type: NT_GNU_ABI_TAG (ABI version tag)
|
|
# LLVM-NEXT: ABI: <corrupt GNU_ABI_TAG>
|
|
# LLVM-NEXT: Description data (
|
|
# LLVM-NEXT: 0000: 00000000 |....|
|
|
# LLVM-NEXT: )
|
|
# LLVM-NEXT: }
|
|
# LLVM-NEXT: ]
|
|
# LLVM-NEXT: }
|
|
# LLVM-NEXT: ]
|
|
|
|
--- !ELF
|
|
FileHeader:
|
|
Class: ELFCLASS64
|
|
Data: ELFDATA2LSB
|
|
Type: ET_EXEC
|
|
Sections:
|
|
- Name: .note.ABI-tag
|
|
Type: SHT_NOTE
|
|
AddressAlign: 0x0000000000000004
|
|
Content: 040000000400000001000000474E550000000000
|