2c1c67674c
This patch is a first pass at making consistent syntax across the `LinalgTransformOp`s that use dynamic index lists for size parameters. Previously, there were two different forms: inline types in the list, or place them in the functional style tuple. This patch goes for the latter. In order to do this, the `printPackedOrDynamicIndexList`, `printDynamicIndexList` and their `parse` counterparts were modified so that the types can be optionally provided to the corresponding custom directives. All affected ops now use tablegen `assemblyFormat`, so custom `parse`/`print` functions have been removed. There are a couple ops that will likely add dynamic size support, and once that happens it should be made sure that the assembly remains consistent with the changes in this patch. The affected ops are as follows: `pack`, `pack_greedily`, `tile_using_forall`. The `tile_using_for` and `vectorize` ops already used this syntax, but their custom assembly was removed. --------- Co-authored-by: Oleksandr "Alex" Zinenko <ftynse@gmail.com>
53 lines
1.9 KiB
C++
53 lines
1.9 KiB
C++
//===- Utils.cpp - Transform dialect utilities ----------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/Dialect/Transform/Utils/Utils.h"
|
|
|
|
#include "mlir/IR/OpDefinition.h"
|
|
#include "mlir/Interfaces/ViewLikeInterface.h"
|
|
|
|
using namespace mlir;
|
|
using namespace mlir::transform;
|
|
|
|
void mlir::transform::printPackedOrDynamicIndexList(
|
|
OpAsmPrinter &printer, Operation *op, Value packed, Type packedType,
|
|
OperandRange values, TypeRange valueTypes, DenseI64ArrayAttr integers) {
|
|
if (packed) {
|
|
assert(values.empty() && (!integers || integers.empty()) &&
|
|
"expected no values/integers");
|
|
printer << "*(" << packed;
|
|
if (packedType) {
|
|
printer << " : " << packedType;
|
|
}
|
|
printer << ")";
|
|
return;
|
|
}
|
|
printDynamicIndexList(printer, op, values, integers, valueTypes);
|
|
}
|
|
|
|
ParseResult mlir::transform::parsePackedOrDynamicIndexList(
|
|
OpAsmParser &parser, std::optional<OpAsmParser::UnresolvedOperand> &packed,
|
|
Type &packedType, SmallVectorImpl<OpAsmParser::UnresolvedOperand> &values,
|
|
SmallVectorImpl<Type> *valueTypes, DenseI64ArrayAttr &integers) {
|
|
OpAsmParser::UnresolvedOperand packedOperand;
|
|
if (parser.parseOptionalStar().succeeded()) {
|
|
if (parser.parseLParen().failed() ||
|
|
parser.parseOperand(packedOperand).failed())
|
|
return failure();
|
|
if (packedType && (parser.parseColonType(packedType).failed()))
|
|
return failure();
|
|
if (parser.parseRParen().failed())
|
|
return failure();
|
|
packed.emplace(packedOperand);
|
|
integers = parser.getBuilder().getDenseI64ArrayAttr({});
|
|
return success();
|
|
}
|
|
|
|
return parseDynamicIndexList(parser, values, integers, valueTypes);
|
|
}
|