61bfc703c3
The various GetSharedModule methods have an optional out parameter for the old module when a file has changed or been replaced, which the Target uses to keep its module list current/correct. We've been using a single ModuleSP to track "the" old module, and this change switches to using a SmallVector of ModuleSP, which has a couple benefits: - There are multiple codepaths which may discover an old module, and this centralizes the code for how to handle multiples in one place, in the Target code. With the single ModuleSP, each place that may discover an old module is responsible for how it handles multiples, and the current code is inconsistent (some code paths drop the first old module, others drop the second). - The API will be more natural for identifying old modules in routines that work on sets, like ModuleList::ReplaceEquivalent (which I plan on updating to report old module(s) in a subsequent change to fix a bug). I'm not convinced we can ever actually run into the case that multiple old modules are found in the same GetOrCreateModule call, but I think this change makes sense regardless, in light of the above. When an old module is reported, Target::GetOrCreateModule calls m_images.ReplaceModule, which doesn't allow multiple "old" modules; the new code calls ReplaceModule for the first "old" module, and for any subsequent old modules it logs the event and calls m_images.Remove. Reviewed By: jingham Differential Revision: https://reviews.llvm.org/D89156
112 lines
4.0 KiB
C++
112 lines
4.0 KiB
C++
//===-- PlatformRemoteDarwinDevice.h -------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLDB_SOURCE_PLUGINS_PLATFORM_MACOSX_PLATFORMREMOTEDARWINDEVICE_H
|
|
#define LLDB_SOURCE_PLUGINS_PLATFORM_MACOSX_PLATFORMREMOTEDARWINDEVICE_H
|
|
|
|
#include <string>
|
|
|
|
#include "PlatformDarwin.h"
|
|
#include "lldb/Utility/FileSpec.h"
|
|
|
|
#include "llvm/Support/FileSystem.h"
|
|
|
|
class PlatformRemoteDarwinDevice : public PlatformDarwin {
|
|
public:
|
|
PlatformRemoteDarwinDevice();
|
|
|
|
~PlatformRemoteDarwinDevice() override;
|
|
|
|
// lldb_private::Platform functions
|
|
lldb_private::Status ResolveExecutable(
|
|
const lldb_private::ModuleSpec &module_spec, lldb::ModuleSP &module_sp,
|
|
const lldb_private::FileSpecList *module_search_paths_ptr) override;
|
|
|
|
void GetStatus(lldb_private::Stream &strm) override;
|
|
|
|
virtual lldb_private::Status
|
|
GetSymbolFile(const lldb_private::FileSpec &platform_file,
|
|
const lldb_private::UUID *uuid_ptr,
|
|
lldb_private::FileSpec &local_file);
|
|
|
|
lldb_private::Status
|
|
GetSharedModule(const lldb_private::ModuleSpec &module_spec,
|
|
lldb_private::Process *process, lldb::ModuleSP &module_sp,
|
|
const lldb_private::FileSpecList *module_search_paths_ptr,
|
|
llvm::SmallVectorImpl<lldb::ModuleSP> *old_modules,
|
|
bool *did_create_ptr) override;
|
|
|
|
void
|
|
AddClangModuleCompilationOptions(lldb_private::Target *target,
|
|
std::vector<std::string> &options) override {
|
|
return PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
|
|
target, options, lldb_private::XcodeSDK::Type::iPhoneOS);
|
|
}
|
|
|
|
protected:
|
|
struct SDKDirectoryInfo {
|
|
SDKDirectoryInfo(const lldb_private::FileSpec &sdk_dir_spec);
|
|
lldb_private::FileSpec directory;
|
|
lldb_private::ConstString build;
|
|
llvm::VersionTuple version;
|
|
bool user_cached;
|
|
};
|
|
|
|
typedef std::vector<SDKDirectoryInfo> SDKDirectoryInfoCollection;
|
|
|
|
std::mutex m_sdk_dir_mutex;
|
|
SDKDirectoryInfoCollection m_sdk_directory_infos;
|
|
std::string m_device_support_directory;
|
|
std::string m_device_support_directory_for_os_version;
|
|
std::string m_build_update;
|
|
uint32_t m_last_module_sdk_idx;
|
|
uint32_t m_connected_module_sdk_idx;
|
|
|
|
bool UpdateSDKDirectoryInfosIfNeeded();
|
|
|
|
const char *GetDeviceSupportDirectory();
|
|
|
|
const char *GetDeviceSupportDirectoryForOSVersion();
|
|
|
|
const SDKDirectoryInfo *GetSDKDirectoryForLatestOSVersion();
|
|
|
|
const SDKDirectoryInfo *GetSDKDirectoryForCurrentOSVersion();
|
|
|
|
static lldb_private::FileSystem::EnumerateDirectoryResult
|
|
GetContainedFilesIntoVectorOfStringsCallback(void *baton,
|
|
llvm::sys::fs::file_type ft,
|
|
llvm::StringRef path);
|
|
|
|
uint32_t FindFileInAllSDKs(const char *platform_file_path,
|
|
lldb_private::FileSpecList &file_list);
|
|
|
|
bool GetFileInSDK(const char *platform_file_path, uint32_t sdk_idx,
|
|
lldb_private::FileSpec &local_file);
|
|
|
|
uint32_t FindFileInAllSDKs(const lldb_private::FileSpec &platform_file,
|
|
lldb_private::FileSpecList &file_list);
|
|
|
|
uint32_t GetConnectedSDKIndex();
|
|
|
|
// Get index of SDK in SDKDirectoryInfoCollection by its pointer and return
|
|
// UINT32_MAX if that SDK not found.
|
|
uint32_t GetSDKIndexBySDKDirectoryInfo(const SDKDirectoryInfo *sdk_info);
|
|
|
|
|
|
virtual void GetDeviceSupportDirectoryNames (std::vector<std::string> &dirnames) = 0;
|
|
|
|
virtual std::string GetPlatformName () = 0;
|
|
|
|
private:
|
|
PlatformRemoteDarwinDevice(const PlatformRemoteDarwinDevice &) = delete;
|
|
const PlatformRemoteDarwinDevice &
|
|
operator=(const PlatformRemoteDarwinDevice &) = delete;
|
|
};
|
|
|
|
#endif // LLDB_SOURCE_PLUGINS_PLATFORM_MACOSX_PLATFORMREMOTEDARWINDEVICE_H
|