7c7702b318
https://discourse.llvm.org/t/parallel-input-file-parsing/60164 initializeSymbols currently sets Defined::section and handles non-prevailing COMDAT groups. Move the code to the parallel postParse to reduce work from the single-threading code path and make parallel section initialization infeasible. Postpone reporting duplicate symbol errors so that the messages have the section information. (`Defined::section` is assigned in postParse and another thread may not have the information). * duplicated-synthetic-sym.s: BinaryFile duplicate definition (very rare) now has no section information * comdat-binding: `%t/w.o %t/g.o` leads to an undesired undefined symbol. This is not ideal but we report a diagnostic to inform that this is unsupported. (See release note) * comdat-discarded-lazy.s: %tdef.o is unextracted. The new behavior (discarded section error) makes more sense * i386-comdat.s: switched to a better approach working around .gnu.linkonce.t.__x86.get_pc_thunk.bx in glibc<2.32 for x86-32. Drop the ancient no-longer-relevant workaround for __i686.get_pc_thunk.bx Depends on D120640 Differential Revision: https://reviews.llvm.org/D120626
32 lines
1.1 KiB
ArmAsm
32 lines
1.1 KiB
ArmAsm
# REQUIRES: x86
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t1.o
|
|
# RUN: echo '.section .text.foo,"axG",@progbits,foo,comdat; .globl foo; foo:' |\
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 - -o %t2.o
|
|
# RUN: echo '.weak foo; foo: .section .text.foo,"axG",@progbits,foo,comdat; .globl bar; bar:' |\
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 - -o %t3.o
|
|
|
|
# RUN: not ld.lld %t2.o %t3.o %t1.o -o /dev/null 2>&1 | FileCheck %s
|
|
|
|
# CHECK: error: relocation refers to a symbol in a discarded section: bar
|
|
# CHECK-NEXT: >>> defined in {{.*}}3.o
|
|
# CHECK-NEXT: >>> section group signature: foo
|
|
# CHECK-NEXT: >>> prevailing definition is in {{.*}}2.o
|
|
# CHECK-NEXT: >>> or the symbol in the prevailing group {{.*}}
|
|
# CHECK-NEXT: >>> referenced by {{.*}}1.o:(.text+0x1)
|
|
|
|
# CHECK: error: relocation refers to a discarded section: .text.foo
|
|
# CHECK-NEXT: >>> defined in {{.*}}1.o
|
|
# CHECK-NEXT: >>> section group signature: foo
|
|
# CHECK-NEXT: >>> prevailing definition is in {{.*}}2.o
|
|
# CHECK-NEXT: >>> referenced by {{.*}}1.o:(.data+0x0)
|
|
|
|
.globl _start
|
|
_start:
|
|
jmp bar
|
|
|
|
.section .text.foo,"axG",@progbits,foo,comdat
|
|
.globl foo
|
|
foo:
|
|
.data
|
|
.quad .text.foo
|