03cc58ff2a
This improves several things and addresses comments up to the diff [11] in this stack. - Simplify many functions to receive less parameters that they can identify easily - Create Storage classes for Trace and TraceIntelPT that can make it easier to reason about what can change with live process refreshes and what cannot. - Don't cache the perf zero conversion numbers in lldb-server to make sure we get the most up-to-date numbers. - Move the thread identifaction from context switches to the bundle parser, to leave TraceIntelPT simpler. This also makes sure that the constructor of TraceIntelPT is invoked when the entire data has been checked to be correct. - Normalize all bundle paths before the Processes, Threads and Modules are created, so that they can assume that all paths are correct and absolute - Fix some issues in the tests. Now they all pass. - return the specific instance when constructing PerThread and MultiCore processor tracers. - Properly implement IntelPTMultiCoreTrace::TraceStart. - Improve some comments. - Use the typedef ContextSwitchTrace more often for clarity. - Move CreateContextSwitchTracePerfEvent to Perf.h as a utility function. - Synchronize better the state of the context switch and the intel pt perf events. - Use a booblean instead of an enum for the PerfEvent state. Differential Revision: https://reviews.llvm.org/D127456
63 lines
2.1 KiB
C++
63 lines
2.1 KiB
C++
//===-- IntelPTPerThreadProcessTrace.h ------------------------ -*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_IntelPTPerThreadProcessTrace_H_
|
|
#define liblldb_IntelPTPerThreadProcessTrace_H_
|
|
|
|
#include "IntelPTProcessTrace.h"
|
|
#include "IntelPTSingleBufferTrace.h"
|
|
#include "IntelPTThreadTraceCollection.h"
|
|
|
|
namespace lldb_private {
|
|
namespace process_linux {
|
|
|
|
/// Manages a "process trace" instance by tracing each thread individually.
|
|
class IntelPTPerThreadProcessTrace : public IntelPTProcessTrace {
|
|
public:
|
|
/// Start tracing the current process by tracing each of its tids
|
|
/// individually.
|
|
///
|
|
/// \param[in] request
|
|
/// Intel PT configuration parameters.
|
|
///
|
|
/// \param[in] current_tids
|
|
/// List of tids currently alive. In the future, whenever a new thread is
|
|
/// spawned, they should be traced by calling the \a TraceStart(tid) method.
|
|
///
|
|
/// \return
|
|
/// An \a IntelPTMultiCoreTrace instance if tracing was successful, or
|
|
/// an \a llvm::Error otherwise.
|
|
static llvm::Expected<std::unique_ptr<IntelPTPerThreadProcessTrace>>
|
|
Start(const TraceIntelPTStartRequest &request,
|
|
llvm::ArrayRef<lldb::tid_t> current_tids);
|
|
|
|
bool TracesThread(lldb::tid_t tid) const override;
|
|
|
|
llvm::Error TraceStart(lldb::tid_t tid) override;
|
|
|
|
llvm::Error TraceStop(lldb::tid_t tid) override;
|
|
|
|
TraceIntelPTGetStateResponse GetState() override;
|
|
|
|
llvm::Expected<llvm::Optional<std::vector<uint8_t>>>
|
|
TryGetBinaryData(const TraceGetBinaryDataRequest &request) override;
|
|
|
|
private:
|
|
IntelPTPerThreadProcessTrace(const TraceIntelPTStartRequest &request)
|
|
: m_tracing_params(request) {}
|
|
|
|
IntelPTThreadTraceCollection m_thread_traces;
|
|
/// Params used to trace threads when the user started "process tracing".
|
|
TraceIntelPTStartRequest m_tracing_params;
|
|
};
|
|
|
|
} // namespace process_linux
|
|
} // namespace lldb_private
|
|
|
|
#endif // liblldb_IntelPTPerThreadProcessTrace_H_
|