0628bea513
This broke Chromium's PGO build, it seems because hot-cold-splitting got turned
on unintentionally. See comment on the code review for repro etc.
> This patch adds -f[no-]split-cold-code CC1 options to clang. This allows
> the splitting pass to be toggled on/off. The current method of passing
> `-mllvm -hot-cold-split=true` to clang isn't ideal as it may not compose
> correctly (say, with `-O0` or `-Oz`).
>
> To implement the -fsplit-cold-code option, an attribute is applied to
> functions to indicate that they may be considered for splitting. This
> removes some complexity from the old/new PM pipeline builders, and
> behaves as expected when LTO is enabled.
>
> Co-authored by: Saleem Abdulrasool <compnerd@compnerd.org>
> Differential Revision: https://reviews.llvm.org/D57265
> Reviewed By: Aditya Kumar, Vedant Kumar
> Reviewers: Teresa Johnson, Aditya Kumar, Fedor Sergeev, Philip Pfaffe, Vedant Kumar
This reverts commit 273c299d5d.
38 lines
971 B
LLVM
38 lines
971 B
LLVM
; RUN: opt -hotcoldsplit -hotcoldsplit-threshold=-1 -pass-remarks=hotcoldsplit -S < %s 2>&1 | FileCheck %s
|
|
; RUN: opt -passes=hotcoldsplit -hotcoldsplit-threshold=-1 -pass-remarks=hotcoldsplit -S < %s 2>&1 | FileCheck %s
|
|
|
|
; Make sure this compiles. This test used to fail with an invalid phi node: the
|
|
; two predecessors were outlined and the SSA representation was invalid.
|
|
|
|
; CHECK: remark: <unknown>:0:0: fun split cold code into fun.cold.1
|
|
; CHECK-LABEL: @fun
|
|
; CHECK: codeRepl:
|
|
; CHECK-NEXT: call void @fun.cold.1
|
|
|
|
; CHECK: define {{.*}}@fun.cold.1{{.*}} [[cold_attr:#[0-9]+]]
|
|
; CHECK: attributes [[cold_attr]] = { {{.*}}noreturn
|
|
|
|
define void @fun() {
|
|
entry:
|
|
br i1 undef, label %if.then, label %if.else
|
|
|
|
if.then:
|
|
ret void
|
|
|
|
if.else:
|
|
br label %if.then4
|
|
|
|
if.then4:
|
|
br i1 undef, label %if.then5, label %if.end
|
|
|
|
if.then5:
|
|
br label %cleanup
|
|
|
|
if.end:
|
|
br label %cleanup
|
|
|
|
cleanup:
|
|
%cleanup.dest.slot.0 = phi i32 [ 1, %if.then5 ], [ 0, %if.end ]
|
|
unreachable
|
|
}
|