8977bd5806
At the moment, rewriteLoopExitValue forgets the current phi node in the loop that collects phis to rewrite. A few lines after the value is forgotten, SCEV is used again to analyze incoming values and potentially expand SCEV expression. This means that another SCEV is created for PN, before the IR is actually updated in the next loop. This leads to accessing invalid cached expression in combination with D71539. PN should only be changed once the actual incoming exit value is set in the next loop. Moving invalidation there should ensure that PN is invalidated in all relevant cases. Reviewed By: mkazantsev Differential Revision: https://reviews.llvm.org/D111495
86 lines
2.6 KiB
LLVM
86 lines
2.6 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
|
|
; RUN: opt -passes='loop(indvars,loop-deletion)' -S %s | FileCheck %s
|
|
|
|
; Make sure indvarsimplify properly forgets the exit value %p.2.lcssa phi after
|
|
; modifying it. Loop deletion is required to show the incorrect use of the cached
|
|
; SCEV value.
|
|
|
|
define void @test(i1 %c) {
|
|
; CHECK-LABEL: @test(
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: br label [[HEADER_1:%.*]]
|
|
; CHECK: header.1.loopexit:
|
|
; CHECK-NEXT: br label [[HEADER_1_BACKEDGE:%.*]]
|
|
; CHECK: header.1:
|
|
; CHECK-NEXT: br label [[HEADER_2:%.*]]
|
|
; CHECK: header.2:
|
|
; CHECK-NEXT: br i1 [[C:%.*]], label [[LATCH_1:%.*]], label [[LATCH_2:%.*]]
|
|
; CHECK: latch.1:
|
|
; CHECK-NEXT: br label [[HEADER_1_LOOPEXIT:%.*]]
|
|
; CHECK: latch.2:
|
|
; CHECK-NEXT: br label [[HEADER_1_BACKEDGE]]
|
|
; CHECK: header.1.backedge:
|
|
; CHECK-NEXT: br label [[HEADER_1]]
|
|
;
|
|
entry:
|
|
br label %header.1
|
|
|
|
header.1:
|
|
%p.1 = phi i32 [ 0, %entry ], [ %p.2.lcssa, %latch.2 ], [ 0, %latch.1 ]
|
|
br label %header.2
|
|
|
|
header.2:
|
|
%p.2 = phi i32 [ %p.1, %header.1 ], [ %p.2.next, %latch.1 ]
|
|
br i1 %c, label %latch.1, label %latch.2
|
|
|
|
latch.1:
|
|
%p.2.next = add i32 %p.2, 1
|
|
br i1 false, label %header.2, label %header.1
|
|
|
|
latch.2:
|
|
%p.2.lcssa = phi i32 [ %p.2, %header.2 ]
|
|
br label %header.1
|
|
}
|
|
|
|
define i8 @test_pr52023(i1 %c.1, i1 %c.2) {
|
|
; CHECK-LABEL: @test_pr52023(
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: br label [[LOOP_1:%.*]]
|
|
; CHECK: loop.1:
|
|
; CHECK-NEXT: [[INC79:%.*]] = phi i8 [ [[TMP0:%.*]], [[LOOP_1_LATCH:%.*]] ], [ 0, [[ENTRY:%.*]] ]
|
|
; CHECK-NEXT: [[TMP0]] = add i8 [[INC79]], 1
|
|
; CHECK-NEXT: br label [[LOOP_2:%.*]]
|
|
; CHECK: loop.2:
|
|
; CHECK-NEXT: br i1 [[C_1:%.*]], label [[LOOP_2_LATCH:%.*]], label [[LOOP_1_LATCH]]
|
|
; CHECK: loop.2.latch:
|
|
; CHECK-NEXT: br label [[LOOP_1_LATCH]]
|
|
; CHECK: loop.1.latch:
|
|
; CHECK-NEXT: br i1 [[C_2:%.*]], label [[EXIT:%.*]], label [[LOOP_1]]
|
|
; CHECK: exit:
|
|
; CHECK-NEXT: [[INC_LCSSA_LCSSA:%.*]] = phi i8 [ [[TMP0]], [[LOOP_1_LATCH]] ]
|
|
; CHECK-NEXT: ret i8 [[INC_LCSSA_LCSSA]]
|
|
;
|
|
entry:
|
|
br label %loop.1
|
|
|
|
loop.1:
|
|
%inc79 = phi i8 [ %inc.lcssa, %loop.1.latch ], [ 0, %entry ]
|
|
br label %loop.2
|
|
|
|
loop.2:
|
|
%inc6 = phi i8 [ %inc79, %loop.1 ], [ %inc, %loop.2.latch ]
|
|
%inc = add i8 %inc6, 1
|
|
br i1 %c.1, label %loop.2.latch , label %loop.1.latch
|
|
|
|
loop.2.latch:
|
|
br i1 false, label %loop.2, label %loop.1.latch
|
|
|
|
loop.1.latch:
|
|
%inc.lcssa = phi i8 [ %inc, %loop.2.latch ], [ undef, %loop.2 ]
|
|
br i1 %c.2, label %exit, label %loop.1
|
|
|
|
exit:
|
|
%inc.lcssa.lcssa = phi i8 [ %inc.lcssa, %loop.1.latch ]
|
|
ret i8 %inc.lcssa.lcssa
|
|
}
|