82a0adf0f7
In order to be more in-line with ELF semantics, a previous patch added support for a new ELF section type to indicate if a section contains offloading data. This allows us to now check using this rather than checking the section name directly. This patch updates the logic to check the type now instead. I chose to make this emit a warning if the input is not an ELF-object file. I could have made the logic fall-back to the section name, but this offloading in LLVM is currently not supported on any other targets so it's probably best to emit a warning until we improve support. Depends on D129052 Reviewed By: jhenderson Differential Revision: https://reviews.llvm.org/D129053
22 lines
807 B
Plaintext
22 lines
807 B
Plaintext
## Ensure we give a warning on bad input following good input.
|
|
# RUN: yaml2obj %S/Inputs/binary.yaml -o %t-good.bin
|
|
# RUN: yaml2obj %S/Inputs/malformed.yaml -o %t-bad.bin
|
|
# RUN: cat %t-bad.bin >> %t-good.bin
|
|
# RUN: yaml2obj %s -o %t.elf
|
|
# RUN: llvm-objcopy --update-section .llvm.offloading=%t-good.bin %t.elf
|
|
# RUN: llvm-objdump --offloading %t.elf 2>&1 | FileCheck %s -DFILENAME=%t.elf
|
|
|
|
!ELF
|
|
FileHeader:
|
|
Class: ELFCLASS64
|
|
Data: ELFDATA2LSB
|
|
Type: ET_EXEC
|
|
Sections:
|
|
- Name: .llvm.offloading
|
|
Type: SHT_LLVM_OFFLOADING
|
|
Flags: [ SHF_EXCLUDE ]
|
|
AddressAlign: 0x0000000000000008
|
|
|
|
# CHECK: OFFLOADING IMAGE [0]:
|
|
# CHECK: warning: '[[FILENAME]]': while parsing offloading files: The end of the file was unexpectedly encountered
|