7e225423d3
Prior to this patch, the semantics utility GetExpr() will crash unconditionally if it encounters a typed expression in the parse tree that has not been set by expression semantics. This is the right behavior when called from lowering, by which time it is known that the program had no fatal user errors, since it signifies a fatal internal error. However, prior to lowering, in the statement semantics checking code, a more nuanced test should be used before crashing -- specifically, we should not crash in the face of a missing typed expression when in error recovery mode. Getting this right requires GetExpr() and its helper class to have access to the semantics context, so that it can check AnyFatalErrors() before crashing. So this patch touches nearly all of its call sites. Differential Revision: https://reviews.llvm.org/D123873
46 lines
1.8 KiB
C++
46 lines
1.8 KiB
C++
//===-- lib/Semantics/check-arithmeticif.cpp ------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "check-arithmeticif.h"
|
|
#include "flang/Parser/message.h"
|
|
#include "flang/Parser/parse-tree.h"
|
|
#include "flang/Semantics/tools.h"
|
|
|
|
namespace Fortran::semantics {
|
|
|
|
bool IsNumericExpr(const SomeExpr &expr) {
|
|
auto dynamicType{expr.GetType()};
|
|
return dynamicType && common::IsNumericTypeCategory(dynamicType->category());
|
|
}
|
|
|
|
void ArithmeticIfStmtChecker::Leave(
|
|
const parser::ArithmeticIfStmt &arithmeticIfStmt) {
|
|
// Arithmetic IF statements have been removed from Fortran 2018.
|
|
// The constraints and requirements here refer to the 2008 spec.
|
|
// R853 Check for a scalar-numeric-expr
|
|
// C849 that shall not be of type complex.
|
|
auto &parsedExpr{std::get<parser::Expr>(arithmeticIfStmt.t)};
|
|
if (const auto *expr{GetExpr(context_, parsedExpr)}) {
|
|
if (expr->Rank() > 0) {
|
|
context_.Say(parsedExpr.source,
|
|
"ARITHMETIC IF expression must be a scalar expression"_err_en_US);
|
|
} else if (ExprHasTypeCategory(*expr, common::TypeCategory::Complex)) {
|
|
context_.Say(parsedExpr.source,
|
|
"ARITHMETIC IF expression must not be a COMPLEX expression"_err_en_US);
|
|
} else if (!IsNumericExpr(*expr)) {
|
|
context_.Say(parsedExpr.source,
|
|
"ARITHMETIC IF expression must be a numeric expression"_err_en_US);
|
|
}
|
|
}
|
|
// The labels have already been checked in resolve-labels.
|
|
// TODO: Really? Check that they are really branch target
|
|
// statements and in the same inclusive scope.
|
|
}
|
|
|
|
} // namespace Fortran::semantics
|