4aca9b1cd8
Summary: In clang-tidy we'd like to know the name of the checker producing each diagnostic message. PathDiagnostic has BugType and Category fields, which are both arbitrary human-readable strings, but we need to know the exact name of the checker in the form that can be used in the CheckersControlList option to enable/disable the specific checker. This patch adds the CheckName field to the CheckerBase class, and sets it in the CheckerManager::registerChecker() method, which gets them from the CheckerRegistry. Checkers that implement multiple checks have to store the names of each check in the respective registerXXXChecker method. Reviewers: jordan_rose, krememek Reviewed By: jordan_rose CC: cfe-commits Differential Revision: http://llvm-reviews.chandlerc.com/D2557 llvm-svn: 201186
71 lines
2.3 KiB
C++
71 lines
2.3 KiB
C++
//=== PointerArithChecker.cpp - Pointer arithmetic checker -----*- C++ -*--===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This files defines PointerArithChecker, a builtin checker that checks for
|
|
// pointer arithmetic on locations other than array elements.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ClangSACheckers.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
namespace {
|
|
class PointerArithChecker
|
|
: public Checker< check::PreStmt<BinaryOperator> > {
|
|
mutable OwningPtr<BuiltinBug> BT;
|
|
|
|
public:
|
|
void checkPreStmt(const BinaryOperator *B, CheckerContext &C) const;
|
|
};
|
|
}
|
|
|
|
void PointerArithChecker::checkPreStmt(const BinaryOperator *B,
|
|
CheckerContext &C) const {
|
|
if (B->getOpcode() != BO_Sub && B->getOpcode() != BO_Add)
|
|
return;
|
|
|
|
ProgramStateRef state = C.getState();
|
|
const LocationContext *LCtx = C.getLocationContext();
|
|
SVal LV = state->getSVal(B->getLHS(), LCtx);
|
|
SVal RV = state->getSVal(B->getRHS(), LCtx);
|
|
|
|
const MemRegion *LR = LV.getAsRegion();
|
|
|
|
if (!LR || !RV.isConstant())
|
|
return;
|
|
|
|
// If pointer arithmetic is done on variables of non-array type, this often
|
|
// means behavior rely on memory organization, which is dangerous.
|
|
if (isa<VarRegion>(LR) || isa<CodeTextRegion>(LR) ||
|
|
isa<CompoundLiteralRegion>(LR)) {
|
|
|
|
if (ExplodedNode *N = C.addTransition()) {
|
|
if (!BT)
|
|
BT.reset(
|
|
new BuiltinBug(this, "Dangerous pointer arithmetic",
|
|
"Pointer arithmetic done on non-array variables "
|
|
"means reliance on memory layout, which is "
|
|
"dangerous."));
|
|
BugReport *R = new BugReport(*BT, BT->getDescription(), N);
|
|
R->addRange(B->getSourceRange());
|
|
C.emitReport(R);
|
|
}
|
|
}
|
|
}
|
|
|
|
void ento::registerPointerArithChecker(CheckerManager &mgr) {
|
|
mgr.registerChecker<PointerArithChecker>();
|
|
}
|