b3a0c4d7dc
Summary:
The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.
This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.
This patch was mostly written by a shell script with some manual verification afterwards:
```
lang=python
import sys
def sanitize_line(line):
if line.strip().startswith("self.assertTrue(") and " == " in line:
line = line.replace("self.assertTrue(", "self.assertEquals(")
line = line.replace(" == ", ", ", 1)
if line.strip().startswith("self.assertTrue(") and " != " in line:
line = line.replace("self.assertTrue(", "self.assertNotEqual(")
line = line.replace(" != ", ", ", 1)
return line
for a in sys.argv[1:]:
with open(a, "r") as f:
lines = f.readlines()
with open(a, "w") as f:
for line in lines:
f.write(sanitize_line(line))
```
Reviewers: labath, JDevlieghere
Reviewed By: labath
Subscribers: abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74475
92 lines
3.1 KiB
Python
92 lines
3.1 KiB
Python
"""
|
|
Test address breakpoints set with shared library of SBAddress work correctly.
|
|
"""
|
|
|
|
|
|
|
|
import lldb
|
|
import lldbsuite.test.lldbutil as lldbutil
|
|
from lldbsuite.test.lldbtest import *
|
|
|
|
|
|
class AddressBreakpointTestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
def test_address_breakpoints(self):
|
|
"""Test address breakpoints set with shared library of SBAddress work correctly."""
|
|
self.build()
|
|
self.address_breakpoints()
|
|
|
|
def address_breakpoints(self):
|
|
"""Test address breakpoints set with shared library of SBAddress work correctly."""
|
|
exe = self.getBuildArtifact("a.out")
|
|
|
|
# Create a target by the debugger.
|
|
target = self.dbg.CreateTarget(exe)
|
|
self.assertTrue(target, VALID_TARGET)
|
|
|
|
# Now create a breakpoint on main.c by name 'c'.
|
|
breakpoint = target.BreakpointCreateBySourceRegex(
|
|
"Set a breakpoint here", lldb.SBFileSpec("main.c"))
|
|
self.assertTrue(breakpoint and
|
|
breakpoint.GetNumLocations() >= 1,
|
|
VALID_BREAKPOINT)
|
|
|
|
# Get the breakpoint location from breakpoint after we verified that,
|
|
# indeed, it has one location.
|
|
location = breakpoint.GetLocationAtIndex(0)
|
|
self.assertTrue(location and
|
|
location.IsEnabled(),
|
|
VALID_BREAKPOINT_LOCATION)
|
|
|
|
# Next get the address from the location, and create an address breakpoint using
|
|
# that address:
|
|
|
|
address = location.GetAddress()
|
|
target.BreakpointDelete(breakpoint.GetID())
|
|
|
|
breakpoint = target.BreakpointCreateBySBAddress(address)
|
|
|
|
# Disable ASLR. This will allow us to actually test (on platforms that support this flag)
|
|
# that the breakpoint was able to track the module.
|
|
|
|
launch_info = lldb.SBLaunchInfo(None)
|
|
flags = launch_info.GetLaunchFlags()
|
|
flags &= ~lldb.eLaunchFlagDisableASLR
|
|
launch_info.SetLaunchFlags(flags)
|
|
|
|
error = lldb.SBError()
|
|
|
|
process = target.Launch(launch_info, error)
|
|
self.assertTrue(process, PROCESS_IS_VALID)
|
|
|
|
# Did we hit our breakpoint?
|
|
from lldbsuite.test.lldbutil import get_threads_stopped_at_breakpoint
|
|
threads = get_threads_stopped_at_breakpoint(process, breakpoint)
|
|
self.assertTrue(
|
|
len(threads) == 1,
|
|
"There should be a thread stopped at our breakpoint")
|
|
|
|
# The hit count for the breakpoint should be 1.
|
|
self.assertEquals(breakpoint.GetHitCount(), 1)
|
|
|
|
process.Kill()
|
|
|
|
# Now re-launch and see that we hit the breakpoint again:
|
|
launch_info.Clear()
|
|
launch_info.SetLaunchFlags(flags)
|
|
|
|
process = target.Launch(launch_info, error)
|
|
self.assertTrue(process, PROCESS_IS_VALID)
|
|
|
|
thread = get_threads_stopped_at_breakpoint(process, breakpoint)
|
|
self.assertTrue(
|
|
len(threads) == 1,
|
|
"There should be a thread stopped at our breakpoint")
|
|
|
|
# The hit count for the breakpoint should now be 2.
|
|
self.assertEquals(breakpoint.GetHitCount(), 2)
|