a1857e2ce3
span.cons/container.pass.cpp
N4842 22.7.3.2 [span.cons]/13 constrains span's range constructor
for ranges::contiguous_range (among other criteria).
24.4.5 [range.refinements]/2 says that contiguous_range requires data(),
and (via contiguous_range, random_access_range, bidirectional_range,
forward_range, input_range, range) it also requires begin() and end()
(see 24.4.2 [range.range]/1).
Therefore, IsAContainer needs to provide begin() and end().
(Detected by MSVC's concept-constrained implementation.)
span.cons/stdarray.pass.cpp
This test uses std::array, so it must include <array>.
<span> isn't guaranteed to drag in <array>.
(Detected by MSVC's implementation which uses a forward declaration to
avoid dragging in <array>, for increased compiler throughput.)
span.objectrep/as_bytes.pass.cpp
span.objectrep/as_writable_bytes.pass.cpp
Testing `sp.extent == std::dynamic_extent` triggers MSVC warning
C4127 "conditional expression is constant". Using `if constexpr` is a
simple way to avoid this without disrupting anyone else (as span
requires C++20 mode).
span.tuple/get.pass.cpp
22.7.3.2 [span.cons]/4.3: "Preconditions: If extent is not equal to
dynamic_extent, then count is equal to extent."
These lines were triggering undefined behavior (detected by assertions
in MSVC's implementation).
I changed the count arguments in the first two chunks, followed by
changing the span extents, in order to preserve the test's coverage
and follow the existing pattern.
span.cons/span.pass.cpp
22.7.3.2 [span.cons]/18.1 constrains span's converting constructor with
"Extent == dynamic_extent || Extent == OtherExtent is true".
This means that converting from dynamic extent to static extent is
not allowed. (Other constructors tested elsewhere, like
span(It first, size_type count), can be used to write such code.)
As this is the test for the converting constructor, I have:
* Removed the "dynamic -> static" case from checkCV(), which is
comprehensive.
* Changed the initialization of std::span<T, 0> s1{}; in
testConstexprSpan() and testRuntimeSpan(), because s1 is used below.
* Removed ASSERT_NOEXCEPT(std::span<T, 0>{s0}); from those functions,
as they are otherwise comprehensive.
* Deleted testConversionSpan() entirely. Note that this could never
compile (it had a bool return type, but forgot to say `return`). And it
couldn't have provided useful coverage, as the /18.2 constraint
"OtherElementType(*)[] is convertible to ElementType(*)[]"
permits only cv-qualifications, which are already tested by checkCV().
117 lines
3.6 KiB
C++
117 lines
3.6 KiB
C++
// -*- C++ -*-
|
|
//===------------------------------ span ---------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===---------------------------------------------------------------------===//
|
|
// UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
|
|
|
|
// <span>
|
|
|
|
// template<size_t N>
|
|
// constexpr span(array<value_type, N>& arr) noexcept;
|
|
// template<size_t N>
|
|
// constexpr span(const array<value_type, N>& arr) noexcept;
|
|
//
|
|
// Remarks: These constructors shall not participate in overload resolution unless:
|
|
// — extent == dynamic_extent || N == extent is true, and
|
|
// — remove_pointer_t<decltype(data(arr))>(*)[] is convertible to ElementType(*)[].
|
|
//
|
|
|
|
|
|
#include <span>
|
|
#include <array>
|
|
#include <cassert>
|
|
#include <string>
|
|
|
|
#include "test_macros.h"
|
|
// std::array is explicitly allowed to be initialized with A a = { init-list };.
|
|
// Disable the missing braces warning for this reason.
|
|
#include "disable_missing_braces_warning.h"
|
|
|
|
|
|
void checkCV()
|
|
{
|
|
std::array<int, 3> arr = {1,2,3};
|
|
// STL says these are not cromulent
|
|
// std::array<const int,3> carr = {4,5,6};
|
|
// std::array<volatile int, 3> varr = {7,8,9};
|
|
// std::array<const volatile int, 3> cvarr = {1,3,5};
|
|
|
|
// Types the same (dynamic sized)
|
|
{
|
|
std::span< int> s1{ arr}; // a span< int> pointing at int.
|
|
}
|
|
|
|
// Types the same (static sized)
|
|
{
|
|
std::span< int,3> s1{ arr}; // a span< int> pointing at int.
|
|
}
|
|
|
|
|
|
// types different (dynamic sized)
|
|
{
|
|
std::span<const int> s1{ arr}; // a span<const int> pointing at int.
|
|
std::span< volatile int> s2{ arr}; // a span< volatile int> pointing at int.
|
|
std::span< volatile int> s3{ arr}; // a span< volatile int> pointing at const int.
|
|
std::span<const volatile int> s4{ arr}; // a span<const volatile int> pointing at int.
|
|
}
|
|
|
|
// types different (static sized)
|
|
{
|
|
std::span<const int,3> s1{ arr}; // a span<const int> pointing at int.
|
|
std::span< volatile int,3> s2{ arr}; // a span< volatile int> pointing at int.
|
|
std::span< volatile int,3> s3{ arr}; // a span< volatile int> pointing at const int.
|
|
std::span<const volatile int,3> s4{ arr}; // a span<const volatile int> pointing at int.
|
|
}
|
|
}
|
|
|
|
|
|
template <typename T>
|
|
constexpr bool testConstexprSpan()
|
|
{
|
|
constexpr std::array<T,2> val = { T(), T() };
|
|
ASSERT_NOEXCEPT(std::span<const T> {val});
|
|
ASSERT_NOEXCEPT(std::span<const T, 2>{val});
|
|
std::span<const T> s1{val};
|
|
std::span<const T, 2> s2{val};
|
|
return
|
|
s1.data() == &val[0] && s1.size() == 2
|
|
&& s2.data() == &val[0] && s2.size() == 2;
|
|
}
|
|
|
|
|
|
template <typename T>
|
|
void testRuntimeSpan()
|
|
{
|
|
std::array<T,2> val;
|
|
ASSERT_NOEXCEPT(std::span<T> {val});
|
|
ASSERT_NOEXCEPT(std::span<T, 2>{val});
|
|
std::span<T> s1{val};
|
|
std::span<T, 2> s2{val};
|
|
assert(s1.data() == &val[0] && s1.size() == 2);
|
|
assert(s2.data() == &val[0] && s2.size() == 2);
|
|
}
|
|
|
|
struct A{};
|
|
|
|
int main(int, char**)
|
|
{
|
|
static_assert(testConstexprSpan<int>(), "");
|
|
static_assert(testConstexprSpan<long>(), "");
|
|
static_assert(testConstexprSpan<double>(), "");
|
|
static_assert(testConstexprSpan<A>(), "");
|
|
|
|
testRuntimeSpan<int>();
|
|
testRuntimeSpan<long>();
|
|
testRuntimeSpan<double>();
|
|
testRuntimeSpan<std::string>();
|
|
testRuntimeSpan<A>();
|
|
|
|
checkCV();
|
|
|
|
return 0;
|
|
}
|