Summary: This is the first change to enable the TLI to be built per-function so that -fno-builtin* handling can be migrated to use function attributes. See discussion on D61634 for background. This is an enabler for fixing handling of these options for LTO, for example. This change should not affect behavior, as the provided function is not yet used to build a specifically per-function TLI, but rather enables that migration. Most of the changes were very mechanical, e.g. passing a Function to the legacy analysis pass's getTLI interface, or in Module level cases, adding a callback. This is similar to the way the per-function TTI analysis works. There was one place where we were looking for builtins but not in the context of a specific function. See FindCXAAtExit in lib/Transforms/IPO/GlobalOpt.cpp. I'm somewhat concerned my workaround could provide the wrong behavior in some corner cases. Suggestions welcome. Reviewers: chandlerc, hfinkel Subscribers: arsenm, dschuff, jvesely, nhaehnle, mehdi_amini, javed.absar, sbc100, jgravelle-google, eraman, aheejin, steven_wu, george.burgess.iv, dexonsmith, jfb, asbirlea, gchatelet, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66428 llvm-svn: 371284
219 lines
7.9 KiB
C++
219 lines
7.9 KiB
C++
//===-- WebAssemblyPeephole.cpp - WebAssembly Peephole Optimiztions -------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
///
|
|
/// \file
|
|
/// Late peephole optimizations for WebAssembly.
|
|
///
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "MCTargetDesc/WebAssemblyMCTargetDesc.h"
|
|
#include "WebAssembly.h"
|
|
#include "WebAssemblyMachineFunctionInfo.h"
|
|
#include "WebAssemblySubtarget.h"
|
|
#include "llvm/Analysis/TargetLibraryInfo.h"
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
#include "llvm/CodeGen/MachineInstrBuilder.h"
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
using namespace llvm;
|
|
|
|
#define DEBUG_TYPE "wasm-peephole"
|
|
|
|
static cl::opt<bool> DisableWebAssemblyFallthroughReturnOpt(
|
|
"disable-wasm-fallthrough-return-opt", cl::Hidden,
|
|
cl::desc("WebAssembly: Disable fallthrough-return optimizations."),
|
|
cl::init(false));
|
|
|
|
namespace {
|
|
class WebAssemblyPeephole final : public MachineFunctionPass {
|
|
StringRef getPassName() const override {
|
|
return "WebAssembly late peephole optimizer";
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
AU.setPreservesCFG();
|
|
AU.addRequired<TargetLibraryInfoWrapperPass>();
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
|
|
bool runOnMachineFunction(MachineFunction &MF) override;
|
|
|
|
public:
|
|
static char ID;
|
|
WebAssemblyPeephole() : MachineFunctionPass(ID) {}
|
|
};
|
|
} // end anonymous namespace
|
|
|
|
char WebAssemblyPeephole::ID = 0;
|
|
INITIALIZE_PASS(WebAssemblyPeephole, DEBUG_TYPE,
|
|
"WebAssembly peephole optimizations", false, false)
|
|
|
|
FunctionPass *llvm::createWebAssemblyPeephole() {
|
|
return new WebAssemblyPeephole();
|
|
}
|
|
|
|
/// If desirable, rewrite NewReg to a drop register.
|
|
static bool maybeRewriteToDrop(unsigned OldReg, unsigned NewReg,
|
|
MachineOperand &MO, WebAssemblyFunctionInfo &MFI,
|
|
MachineRegisterInfo &MRI) {
|
|
bool Changed = false;
|
|
if (OldReg == NewReg) {
|
|
Changed = true;
|
|
Register NewReg = MRI.createVirtualRegister(MRI.getRegClass(OldReg));
|
|
MO.setReg(NewReg);
|
|
MO.setIsDead();
|
|
MFI.stackifyVReg(NewReg);
|
|
}
|
|
return Changed;
|
|
}
|
|
|
|
static bool maybeRewriteToFallthrough(MachineInstr &MI, MachineBasicBlock &MBB,
|
|
const MachineFunction &MF,
|
|
WebAssemblyFunctionInfo &MFI,
|
|
MachineRegisterInfo &MRI,
|
|
const WebAssemblyInstrInfo &TII,
|
|
unsigned FallthroughOpc,
|
|
unsigned CopyLocalOpc) {
|
|
if (DisableWebAssemblyFallthroughReturnOpt)
|
|
return false;
|
|
if (&MBB != &MF.back())
|
|
return false;
|
|
|
|
MachineBasicBlock::iterator End = MBB.end();
|
|
--End;
|
|
assert(End->getOpcode() == WebAssembly::END_FUNCTION);
|
|
--End;
|
|
if (&MI != &*End)
|
|
return false;
|
|
|
|
if (FallthroughOpc != WebAssembly::FALLTHROUGH_RETURN_VOID) {
|
|
// If the operand isn't stackified, insert a COPY to read the operand and
|
|
// stackify it.
|
|
MachineOperand &MO = MI.getOperand(0);
|
|
Register Reg = MO.getReg();
|
|
if (!MFI.isVRegStackified(Reg)) {
|
|
Register NewReg = MRI.createVirtualRegister(MRI.getRegClass(Reg));
|
|
BuildMI(MBB, MI, MI.getDebugLoc(), TII.get(CopyLocalOpc), NewReg)
|
|
.addReg(Reg);
|
|
MO.setReg(NewReg);
|
|
MFI.stackifyVReg(NewReg);
|
|
}
|
|
}
|
|
|
|
// Rewrite the return.
|
|
MI.setDesc(TII.get(FallthroughOpc));
|
|
return true;
|
|
}
|
|
|
|
bool WebAssemblyPeephole::runOnMachineFunction(MachineFunction &MF) {
|
|
LLVM_DEBUG({
|
|
dbgs() << "********** Peephole **********\n"
|
|
<< "********** Function: " << MF.getName() << '\n';
|
|
});
|
|
|
|
MachineRegisterInfo &MRI = MF.getRegInfo();
|
|
WebAssemblyFunctionInfo &MFI = *MF.getInfo<WebAssemblyFunctionInfo>();
|
|
const auto &TII = *MF.getSubtarget<WebAssemblySubtarget>().getInstrInfo();
|
|
const WebAssemblyTargetLowering &TLI =
|
|
*MF.getSubtarget<WebAssemblySubtarget>().getTargetLowering();
|
|
auto &LibInfo =
|
|
getAnalysis<TargetLibraryInfoWrapperPass>().getTLI(MF.getFunction());
|
|
bool Changed = false;
|
|
|
|
for (auto &MBB : MF)
|
|
for (auto &MI : MBB)
|
|
switch (MI.getOpcode()) {
|
|
default:
|
|
break;
|
|
case WebAssembly::CALL_i32:
|
|
case WebAssembly::CALL_i64: {
|
|
MachineOperand &Op1 = MI.getOperand(1);
|
|
if (Op1.isSymbol()) {
|
|
StringRef Name(Op1.getSymbolName());
|
|
if (Name == TLI.getLibcallName(RTLIB::MEMCPY) ||
|
|
Name == TLI.getLibcallName(RTLIB::MEMMOVE) ||
|
|
Name == TLI.getLibcallName(RTLIB::MEMSET)) {
|
|
LibFunc Func;
|
|
if (LibInfo.getLibFunc(Name, Func)) {
|
|
const auto &Op2 = MI.getOperand(2);
|
|
if (!Op2.isReg())
|
|
report_fatal_error("Peephole: call to builtin function with "
|
|
"wrong signature, not consuming reg");
|
|
MachineOperand &MO = MI.getOperand(0);
|
|
Register OldReg = MO.getReg();
|
|
Register NewReg = Op2.getReg();
|
|
|
|
if (MRI.getRegClass(NewReg) != MRI.getRegClass(OldReg))
|
|
report_fatal_error("Peephole: call to builtin function with "
|
|
"wrong signature, from/to mismatch");
|
|
Changed |= maybeRewriteToDrop(OldReg, NewReg, MO, MFI, MRI);
|
|
}
|
|
}
|
|
}
|
|
break;
|
|
}
|
|
// Optimize away an explicit void return at the end of the function.
|
|
case WebAssembly::RETURN_I32:
|
|
Changed |= maybeRewriteToFallthrough(
|
|
MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_I32,
|
|
WebAssembly::COPY_I32);
|
|
break;
|
|
case WebAssembly::RETURN_I64:
|
|
Changed |= maybeRewriteToFallthrough(
|
|
MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_I64,
|
|
WebAssembly::COPY_I64);
|
|
break;
|
|
case WebAssembly::RETURN_F32:
|
|
Changed |= maybeRewriteToFallthrough(
|
|
MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_F32,
|
|
WebAssembly::COPY_F32);
|
|
break;
|
|
case WebAssembly::RETURN_F64:
|
|
Changed |= maybeRewriteToFallthrough(
|
|
MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_F64,
|
|
WebAssembly::COPY_F64);
|
|
break;
|
|
case WebAssembly::RETURN_v16i8:
|
|
Changed |= maybeRewriteToFallthrough(
|
|
MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v16i8,
|
|
WebAssembly::COPY_V128);
|
|
break;
|
|
case WebAssembly::RETURN_v8i16:
|
|
Changed |= maybeRewriteToFallthrough(
|
|
MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v8i16,
|
|
WebAssembly::COPY_V128);
|
|
break;
|
|
case WebAssembly::RETURN_v4i32:
|
|
Changed |= maybeRewriteToFallthrough(
|
|
MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v4i32,
|
|
WebAssembly::COPY_V128);
|
|
break;
|
|
case WebAssembly::RETURN_v2i64:
|
|
Changed |= maybeRewriteToFallthrough(
|
|
MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v2i64,
|
|
WebAssembly::COPY_V128);
|
|
break;
|
|
case WebAssembly::RETURN_v4f32:
|
|
Changed |= maybeRewriteToFallthrough(
|
|
MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v4f32,
|
|
WebAssembly::COPY_V128);
|
|
break;
|
|
case WebAssembly::RETURN_v2f64:
|
|
Changed |= maybeRewriteToFallthrough(
|
|
MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_v2f64,
|
|
WebAssembly::COPY_V128);
|
|
break;
|
|
case WebAssembly::RETURN_VOID:
|
|
Changed |= maybeRewriteToFallthrough(
|
|
MI, MBB, MF, MFI, MRI, TII, WebAssembly::FALLTHROUGH_RETURN_VOID,
|
|
WebAssembly::INSTRUCTION_LIST_END);
|
|
break;
|
|
}
|
|
|
|
return Changed;
|
|
}
|