The aim of this patch is to refactor how we handle and report error. I suggest to use the same approach we use in LLD: delayed error reporting. For that I introduced 'HasError' flag which triggers when we report an error. Now we do not exit instantly on any error. The benefits are: 1) There are no more 'exit(1)' calls in the library code. 2) Code was simplified significantly in a few places. 3) It is now possible to print multiple errors instead of only one. Also, I changed the messages to be lower case and removed a full stop. Differential revision: https://reviews.llvm.org/D67182 llvm-svn: 371380
98 lines
2.6 KiB
YAML
98 lines
2.6 KiB
YAML
# RUN: yaml2obj --docnum=1 %s -o %t
|
|
# RUN: llvm-readobj -l %t | FileCheck %s
|
|
|
|
--- !ELF
|
|
FileHeader:
|
|
Class: ELFCLASS64
|
|
Data: ELFDATA2LSB
|
|
Type: ET_EXEC
|
|
Machine: EM_X86_64
|
|
Sections:
|
|
- Name: .text
|
|
Type: SHT_PROGBITS
|
|
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
|
|
AddressAlign: 0x0000000000001000
|
|
Content: "00000000"
|
|
- Name: .init
|
|
Type: SHT_PROGBITS
|
|
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
|
|
Content: "00000000"
|
|
AddressAlign: 0x0000000000000010
|
|
- Name: .data
|
|
Type: SHT_PROGBITS
|
|
Flags: [ SHF_ALLOC ]
|
|
Content: "00000000"
|
|
AddressAlign: 0x0000000000001000
|
|
ProgramHeaders:
|
|
- Type: PT_LOAD
|
|
Flags: [ PF_X, PF_R ]
|
|
VAddr: 0xAAAA1000
|
|
PAddr: 0xFFFF1000
|
|
Sections:
|
|
- Section: .text
|
|
- Section: .init
|
|
- Type: PT_LOAD
|
|
Flags: [ PF_R ]
|
|
VAddr: 0xAAAA2000
|
|
PAddr: 0xFFFF2000
|
|
Sections:
|
|
- Section: .data
|
|
- Type: PT_GNU_EH_FRAME
|
|
- Type: PT_GNU_STACK
|
|
- Type: PT_GNU_RELRO
|
|
|
|
#CHECK: ProgramHeaders [
|
|
#CHECK-NEXT: ProgramHeader {
|
|
#CHECK-NEXT: Type: PT_LOAD
|
|
#CHECK-NEXT: Offset: 0x1000
|
|
#CHECK-NEXT: VirtualAddress: 0xAAAA1000
|
|
#CHECK-NEXT: PhysicalAddress: 0xFFFF1000
|
|
#CHECK-NEXT: FileSize: 20
|
|
#CHECK-NEXT: MemSize: 20
|
|
#CHECK-NEXT: Flags [
|
|
#CHECK-NEXT: PF_R
|
|
#CHECK-NEXT: PF_X
|
|
#CHECK-NEXT: ]
|
|
#CHECK-NEXT: Alignment: 4096
|
|
#CHECK-NEXT: }
|
|
#CHECK-NEXT: ProgramHeader {
|
|
#CHECK-NEXT: Type: PT_LOAD
|
|
#CHECK-NEXT: Offset: 0x2000
|
|
#CHECK-NEXT: VirtualAddress: 0xAAAA2000
|
|
#CHECK-NEXT: PhysicalAddress: 0xFFFF2000
|
|
#CHECK-NEXT: FileSize: 4
|
|
#CHECK-NEXT: MemSize: 4
|
|
#CHECK-NEXT: Flags [
|
|
#CHECK-NEXT: PF_R
|
|
#CHECK-NEXT: ]
|
|
#CHECK-NEXT: Alignment: 4096
|
|
#CHECK-NEXT: }
|
|
#CHECK-NEXT: ProgramHeader {
|
|
#CHECK-NEXT: Type: PT_GNU_EH_FRAME (0x6474E550)
|
|
#CHECK: }
|
|
#CHECK-NEXT: ProgramHeader {
|
|
#CHECK-NEXT: Type: PT_GNU_STACK (0x6474E551)
|
|
#CHECK: }
|
|
#CHECK-NEXT: ProgramHeader {
|
|
#CHECK-NEXT: Type: PT_GNU_RELRO (0x6474E552)
|
|
#CHECK: }
|
|
#CHECK-NEXT:]
|
|
|
|
## Check we do not allow referencing sections that do not exist.
|
|
# RUN: not yaml2obj --docnum=2 %s -o %t 2>&1 | FileCheck %s --check-prefix=ERR
|
|
|
|
# ERR: error: unknown section referenced: '.foo' by program header
|
|
# ERR: error: unknown section referenced: '.bar' by program header
|
|
|
|
--- !ELF
|
|
FileHeader:
|
|
Class: ELFCLASS64
|
|
Data: ELFDATA2LSB
|
|
Type: ET_EXEC
|
|
Machine: EM_X86_64
|
|
ProgramHeaders:
|
|
- Type: PT_LOAD
|
|
Sections:
|
|
- Section: .foo
|
|
- Section: .bar
|