While it's not necessary to qualify calls to `declval` it makes error messages very crypric if the declaration isn't reachable anymore
For example:
```
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__chrono/duration.h:53:66: error: no type named 'type' in 'std::common_type<long, long>'
typedef chrono::duration<typename common_type<_Rep1, _Rep2>::type,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__type_traits/common_type.h:107:14: note: in instantiation of template class 'std::common_type<std::chrono::duration<long, std::ratio<3600, 1>>, std::chrono::duration<long, std::ratio<3600, 1>>>' requested here
: public common_type<_Tp, _Tp> {};
^
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__chrono/duration.h:279:58: note: in instantiation of template class 'std::common_type<std::chrono::duration<long, std::ratio<3600, 1>>>' requested here
_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR typename common_type<duration>::type operator+() const {return typename common_type<duration>::type(*this);}
^
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__chrono/duration.h:308:54: note: in instantiation of template class 'std::chrono::duration<long, std::ratio<3600, 1>>' requested here
typedef duration< int, ratio_multiply<ratio<24>, hours::period>> days;
^
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__chrono/duration.h:280:81: error: no type named 'type' in 'std::common_type<std::chrono::duration<long, std::ratio<3600, 1>>>'
_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR typename common_type<duration>::type operator-() const {return typename common_type<duration>::type(-__rep_);}
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__chrono/duration.h:308:54: note: in instantiation of template class 'std::chrono::duration<long, std::ratio<3600, 1>>' requested here
typedef duration< int, ratio_multiply<ratio<24>, hours::period>> days;
^
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__chrono/duration.h:53:66: error: no type named 'type' in 'std::common_type<int, int>'
typedef chrono::duration<typename common_type<_Rep1, _Rep2>::type,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__type_traits/common_type.h:107:14: note: in instantiation of template class 'std::common_type<std::chrono::duration<int, std::ratio<86400, 1>>, std::chrono::duration<int, std::ratio<86400, 1>>>' requested here
: public common_type<_Tp, _Tp> {};
^
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__chrono/duration.h:279:58: note: in instantiation of template class 'std::common_type<std::chrono::duration<int, std::ratio<86400, 1>>>' requested here
_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR typename common_type<duration>::type operator+() const {return typename common_type<duration>::type(*this);}
^
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__chrono/duration.h:309:55: note: in instantiation of template class 'std::chrono::duration<int, std::ratio<86400, 1>>' requested here
typedef duration< int, ratio_multiply<ratio<7>, days::period>> weeks;
^
19 similar errors omitted
```
changes with qualification added to:
```
While building module 'std' imported from /home/nikolask/llvm-projects/libcxx/libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/common_type.pass.cpp:13:
In file included from <module-includes>:17:
In file included from /home/nikolask/llvm-projects/libcxx/build/include/c++/v1/math.h:309:
In file included from /home/nikolask/llvm-projects/libcxx/build/include/c++/v1/limits:107:
In file included from /home/nikolask/llvm-projects/libcxx/build/include/c++/v1/type_traits:432:
In file included from /home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__type_traits/common_reference.h:13:
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__type_traits/common_type.h:28:43: error: declaration of 'declval' must be imported from module 'std.utility.__utility.declval' before it is required
using __cond_type = decltype(false ? std::declval<_Tp>() : std::declval<_Up>());
^
/home/nikolask/llvm-projects/libcxx/build/include/c++/v1/__utility/declval.h:30:34: note: declaration here is not visible
decltype(std::__declval<_Tp>(0)) declval() _NOEXCEPT;
^
/home/nikolask/llvm-projects/libcxx/libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/common_type.pass.cpp:13:10: fatal error: could not build module 'std'
#include <functional>
~~~~~~~~^
2 errors generated.
```
Reviewed By: ldionne, Mordante, #libc
Spies: libcxx-commits
Differential Revision: https://reviews.llvm.org/D130854
62 lines
2.8 KiB
C++
62 lines
2.8 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef _LIBCPP___RANDOM_IS_VALID_H
|
|
#define _LIBCPP___RANDOM_IS_VALID_H
|
|
|
|
#include <__config>
|
|
#include <cstdint>
|
|
#include <type_traits>
|
|
|
|
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
|
|
# pragma GCC system_header
|
|
#endif
|
|
|
|
_LIBCPP_BEGIN_NAMESPACE_STD
|
|
|
|
// [rand.req.genl]/1.5:
|
|
// The effect of instantiating a template that has a template type parameter
|
|
// named IntType is undefined unless the corresponding template argument is
|
|
// cv-unqualified and is one of short, int, long, long long, unsigned short,
|
|
// unsigned int, unsigned long, or unsigned long long.
|
|
|
|
template<class> struct __libcpp_random_is_valid_inttype : false_type {};
|
|
template<> struct __libcpp_random_is_valid_inttype<int8_t> : true_type {}; // extension
|
|
template<> struct __libcpp_random_is_valid_inttype<short> : true_type {};
|
|
template<> struct __libcpp_random_is_valid_inttype<int> : true_type {};
|
|
template<> struct __libcpp_random_is_valid_inttype<long> : true_type {};
|
|
template<> struct __libcpp_random_is_valid_inttype<long long> : true_type {};
|
|
template<> struct __libcpp_random_is_valid_inttype<uint8_t> : true_type {}; // extension
|
|
template<> struct __libcpp_random_is_valid_inttype<unsigned short> : true_type {};
|
|
template<> struct __libcpp_random_is_valid_inttype<unsigned int> : true_type {};
|
|
template<> struct __libcpp_random_is_valid_inttype<unsigned long> : true_type {};
|
|
template<> struct __libcpp_random_is_valid_inttype<unsigned long long> : true_type {};
|
|
|
|
#ifndef _LIBCPP_HAS_NO_INT128
|
|
template<> struct __libcpp_random_is_valid_inttype<__int128_t> : true_type {}; // extension
|
|
template<> struct __libcpp_random_is_valid_inttype<__uint128_t> : true_type {}; // extension
|
|
#endif // _LIBCPP_HAS_NO_INT128
|
|
|
|
// [rand.req.urng]/3:
|
|
// A class G meets the uniform random bit generator requirements if G models
|
|
// uniform_random_bit_generator, invoke_result_t<G&> is an unsigned integer type,
|
|
// and G provides a nested typedef-name result_type that denotes the same type
|
|
// as invoke_result_t<G&>.
|
|
// (In particular, reject URNGs with signed result_types; our distributions cannot
|
|
// handle such generator types.)
|
|
|
|
template<class, class = void> struct __libcpp_random_is_valid_urng : false_type {};
|
|
template<class _Gp> struct __libcpp_random_is_valid_urng<_Gp, __enable_if_t<
|
|
is_unsigned<typename _Gp::result_type>::value &&
|
|
_IsSame<decltype(std::declval<_Gp&>()()), typename _Gp::result_type>::value
|
|
> > : true_type {};
|
|
|
|
_LIBCPP_END_NAMESPACE_STD
|
|
|
|
#endif // _LIBCPP___RANDOM_IS_VALID_H
|