7c7702b318
https://discourse.llvm.org/t/parallel-input-file-parsing/60164 initializeSymbols currently sets Defined::section and handles non-prevailing COMDAT groups. Move the code to the parallel postParse to reduce work from the single-threading code path and make parallel section initialization infeasible. Postpone reporting duplicate symbol errors so that the messages have the section information. (`Defined::section` is assigned in postParse and another thread may not have the information). * duplicated-synthetic-sym.s: BinaryFile duplicate definition (very rare) now has no section information * comdat-binding: `%t/w.o %t/g.o` leads to an undesired undefined symbol. This is not ideal but we report a diagnostic to inform that this is unsupported. (See release note) * comdat-discarded-lazy.s: %tdef.o is unextracted. The new behavior (discarded section error) makes more sense * i386-comdat.s: switched to a better approach working around .gnu.linkonce.t.__x86.get_pc_thunk.bx in glibc<2.32 for x86-32. Drop the ancient no-longer-relevant workaround for __i686.get_pc_thunk.bx Depends on D120640 Differential Revision: https://reviews.llvm.org/D120626
44 lines
1.8 KiB
ArmAsm
44 lines
1.8 KiB
ArmAsm
# REQUIRES: x86
|
|
# RUN: rm -rf %t && split-file %s %t
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/g.s -o %t/g.o
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/w.s -o %t/w.o
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/u.s -o %t/u.o
|
|
# RUN: ld.lld -e 0 %t/w.o %t/u.o -o %t/w
|
|
# RUN: llvm-readelf -s %t/w | FileCheck %s --check-prefix=WEAK
|
|
# RUN: ld.lld -e 0 %t/u.o %t/w.o -o %t/u
|
|
# RUN: llvm-readelf -s %t/u | FileCheck %s --check-prefix=UNIQUE
|
|
|
|
## We prefer STB_GLOBAL definition, then changing it to undefined since it is in
|
|
## in a non-prevailing COMDAT. Ideally this should be defined, but our behavior
|
|
## is fine because valid input cannot form this case.
|
|
# RUN: ld.lld -e 0 %t/w.o %t/g.o -o %t/und --noinhibit-exec 2>&1 | FileCheck %s --check-prefix=WARN
|
|
# RUN: llvm-readelf -s %t/und | FileCheck %s --check-prefix=UND
|
|
|
|
# WEAK: NOTYPE WEAK DEFAULT [[#]] _ZZ1fvE1x
|
|
# UNIQUE: OBJECT UNIQUE DEFAULT [[#]] _ZZ1fvE1x
|
|
# UND: NOTYPE GLOBAL DEFAULT UND _ZZ1fvE1x
|
|
|
|
# WARN: warning: relocation refers to a symbol in a discarded section: f()::x
|
|
# WARN-NEXT: >>> defined in {{.*}}g.o
|
|
# WARN-NEXT: >>> section group signature: _ZZ1fvE1x
|
|
# WARN-NEXT: >>> prevailing definition is in {{.*}}w.o
|
|
# WARN-NEXT: >>> or the symbol in the prevailing group had STB_WEAK binding and the symbol in a non-prevailing group had STB_GLOBAL binding. Mixing groups with STB_WEAK and STB_GLOBAL binding signature is not supported
|
|
# WARN-NEXT: >>> referenced by {{.*}}g.o:(.text+0x3)
|
|
|
|
#--- g.s
|
|
movq _ZZ1fvE1x@gotpcrel(%rip), %rax
|
|
|
|
.section .bss._ZZ1fvE1x,"awG",@nobits,_ZZ1fvE1x,comdat
|
|
.globl _ZZ1fvE1x
|
|
_ZZ1fvE1x:
|
|
|
|
#--- w.s
|
|
.section .bss._ZZ1fvE1x,"awG",@nobits,_ZZ1fvE1x,comdat
|
|
.weak _ZZ1fvE1x
|
|
_ZZ1fvE1x:
|
|
|
|
#--- u.s
|
|
.section .bss._ZZ1fvE1x,"awG",@nobits,_ZZ1fvE1x,comdat
|
|
.type _ZZ1fvE1x, @gnu_unique_object
|
|
_ZZ1fvE1x:
|