0a088ead85
Fix a few bugs where we would fail to properly determine header to module correspondence when determining whether to suggest a #include or import, and suggest a #include more often in language modes where there is no import syntax. Generally, if the target is in a header with include guards or #pragma once, we should suggest either #including or importing that header, and not importing a module that happens to textually include it. In passing, improve the notes we attach to the corresponding diagnostics: calling an entity that we couldn't see "previous" is confusing.
15 lines
907 B
Objective-C
15 lines
907 B
Objective-C
// RUN: rm -rf %t
|
|
// RUN: %clang_cc1 -fmodules -fmodules-cache-path=%t -I%S/Inputs/diagnose-missing-import \
|
|
// RUN: -Werror=implicit-function-declaration -fsyntax-only \
|
|
// RUN: -fimplicit-module-maps -verify %s
|
|
@import NCI;
|
|
|
|
void foo() {
|
|
XYZLogEvent(xyzRiskyCloseOpenParam, xyzRiskyCloseOpenParam); // expected-error {{implicit declaration of function 'XYZLogEvent'}} expected-error {{declaration of 'XYZLogEvent' must be imported}} expected-error {{declaration of 'xyzRiskyCloseOpenParam' must be imported from module 'NCI.A'}} expected-error {{declaration of 'xyzRiskyCloseOpenParam' must be imported from module 'NCI.A'}}
|
|
}
|
|
|
|
// expected-note@Inputs/diagnose-missing-import/a.h:5 {{declaration here is not visible}}
|
|
// expected-note@Inputs/diagnose-missing-import/a.h:5 {{declaration here is not visible}}
|
|
// expected-note@Inputs/diagnose-missing-import/a.h:6 {{declaration here is not visible}}
|
|
|