572a87e2aa
Currently each File contains an BumpPtrAllocator in which Atom's are allocated. Some Atom's contain data structures like std::vector which leak as we don't run ~Atom when they are BumpPtrAllocate'd. Now each File actually owns its Atom's using an OwningAtomPtr. This is analygous to std::unique_ptr and may be replaced by it if possible. An Atom can therefore only be owned by a single File, so the Resolver now moves them from one File to another. The MachOLinkingContext owns the File's and so clears all the Atom's in ~MachOLinkingContext, then delete's all the File's. This makes sure all Atom's have been destructed before any of the BumpPtrAllocator's in which they run have gone away. Should hopefully fix the remaining leaks. Will keep an eye on the bots to make sure. llvm-svn: 264022
31 lines
865 B
C++
31 lines
865 B
C++
//===- Core/File.cpp - A Container of Atoms -------------------------------===//
|
|
//
|
|
// The LLVM Linker
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lld/Core/File.h"
|
|
#include "lld/Core/LLVM.h"
|
|
#include <mutex>
|
|
|
|
namespace lld {
|
|
|
|
File::~File() { }
|
|
|
|
File::AtomVector<DefinedAtom> File::_noDefinedAtoms;
|
|
File::AtomVector<UndefinedAtom> File::_noUndefinedAtoms;
|
|
File::AtomVector<SharedLibraryAtom> File::_noSharedLibraryAtoms;
|
|
File::AtomVector<AbsoluteAtom> File::_noAbsoluteAtoms;
|
|
|
|
std::error_code File::parse() {
|
|
std::lock_guard<std::mutex> lock(_parseMutex);
|
|
if (!_lastError.hasValue())
|
|
_lastError = doParse();
|
|
return _lastError.getValue();
|
|
}
|
|
|
|
} // namespace lld
|