b3a0c4d7dc
Summary:
The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.
This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.
This patch was mostly written by a shell script with some manual verification afterwards:
```
lang=python
import sys
def sanitize_line(line):
if line.strip().startswith("self.assertTrue(") and " == " in line:
line = line.replace("self.assertTrue(", "self.assertEquals(")
line = line.replace(" == ", ", ", 1)
if line.strip().startswith("self.assertTrue(") and " != " in line:
line = line.replace("self.assertTrue(", "self.assertNotEqual(")
line = line.replace(" != ", ", ", 1)
return line
for a in sys.argv[1:]:
with open(a, "r") as f:
lines = f.readlines()
with open(a, "w") as f:
for line in lines:
f.write(sanitize_line(line))
```
Reviewers: labath, JDevlieghere
Reviewed By: labath
Subscribers: abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74475
58 lines
2.1 KiB
Python
58 lines
2.1 KiB
Python
"""
|
|
Test lldb breakpoint ids.
|
|
"""
|
|
|
|
|
|
|
|
import lldb
|
|
from lldbsuite.test.lldbtest import *
|
|
import lldbsuite.test.lldbutil as lldbutil
|
|
|
|
|
|
class BreakpointIDTestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
def test(self):
|
|
self.build()
|
|
|
|
exe = self.getBuildArtifact("a.out")
|
|
self.expect("file " + exe,
|
|
patterns=["Current executable set to .*a.out"])
|
|
|
|
bpno = lldbutil.run_break_set_by_symbol(
|
|
self, 'product', num_expected_locations=-1, sym_exact=False)
|
|
self.assertEquals(bpno, 1, "First breakpoint number is 1.")
|
|
|
|
bpno = lldbutil.run_break_set_by_symbol(
|
|
self, 'sum', num_expected_locations=-1, sym_exact=False)
|
|
self.assertEquals(bpno, 2, "Second breakpoint number is 2.")
|
|
|
|
bpno = lldbutil.run_break_set_by_symbol(
|
|
self, 'junk', num_expected_locations=0, sym_exact=False)
|
|
self.assertEquals(bpno, 3, "Third breakpoint number is 3.")
|
|
|
|
self.expect(
|
|
"breakpoint disable 1.1 - 2.2 ",
|
|
COMMAND_FAILED_AS_EXPECTED,
|
|
error=True,
|
|
startstr="error: Invalid range: Ranges that specify particular breakpoint locations must be within the same major breakpoint; you specified two different major breakpoints, 1 and 2.")
|
|
|
|
self.expect(
|
|
"breakpoint disable 2 - 2.2",
|
|
COMMAND_FAILED_AS_EXPECTED,
|
|
error=True,
|
|
startstr="error: Invalid breakpoint id range: Either both ends of range must specify a breakpoint location, or neither can specify a breakpoint location.")
|
|
|
|
self.expect(
|
|
"breakpoint disable 2.1 - 2",
|
|
COMMAND_FAILED_AS_EXPECTED,
|
|
error=True,
|
|
startstr="error: Invalid breakpoint id range: Either both ends of range must specify a breakpoint location, or neither can specify a breakpoint location.")
|
|
|
|
self.expect("breakpoint disable 2.1 - 2.2",
|
|
startstr="2 breakpoints disabled.")
|
|
|
|
self.expect("breakpoint enable 2.*",
|
|
patterns=[".* breakpoints enabled."])
|