83bd2c4a06
Summary: This is an attempt to fix https://bugs.llvm.org/show_bug.cgi?id=45988, where SBValue::GetNumChildren returns 2, but SBValue::GetChildAtIndex(1) returns an invalid value sentinel. The root cause of this seems to be that GetNumChildren can return the number of children of a wrong value. In particular, for pointers GetNumChildren just recursively calls itself on the pointee type, so it effectively walks chains of pointers. This is different from the logic of GetChildAtIndex, which only recurses if pointee.IsAggregateType() returns true (IsAggregateType is false for pointers and references), so it never follows chain of pointers. This patch aims to make GetNumChildren (more) consistent with GetChildAtIndex by only recursively calling GetNumChildren for aggregate types. Ideally, GetNumChildren and GetChildAtIndex would share the code that decides which pointers/references are followed, but that is a bit more invasive change. Reviewers: teemperor, jingham, clayborg Reviewed By: teemperor, clayborg Subscribers: clayborg, labath, shafik, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D80254
29 lines
1.1 KiB
Python
29 lines
1.1 KiB
Python
"""
|
|
Test children counts of pointer values.
|
|
"""
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class TestPointerNumChilden(TestBase):
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
def test_pointer_num_children(self):
|
|
self.build()
|
|
lldbutil.run_to_source_breakpoint(self, "// break here", lldb.SBFileSpec("main.cpp"))
|
|
|
|
result = self.frame().FindVariable("Ref")
|
|
self.assertEqual(1, result.GetNumChildren())
|
|
self.assertEqual(2, result.GetChildAtIndex(0).GetNumChildren())
|
|
self.assertEqual("42", result.GetChildAtIndex(0).GetChildAtIndex(0).GetValue())
|
|
self.assertEqual("56", result.GetChildAtIndex(0).GetChildAtIndex(1).GetValue())
|
|
|
|
result = self.frame().FindVariable("Ptr")
|
|
self.assertEqual(1, result.GetNumChildren())
|
|
self.assertEqual(2, result.GetChildAtIndex(0).GetNumChildren())
|
|
self.assertEqual("42", result.GetChildAtIndex(0).GetChildAtIndex(0).GetValue())
|
|
self.assertEqual("56", result.GetChildAtIndex(0).GetChildAtIndex(1).GetValue())
|