b3a0c4d7dc
Summary:
The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.
This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.
This patch was mostly written by a shell script with some manual verification afterwards:
```
lang=python
import sys
def sanitize_line(line):
if line.strip().startswith("self.assertTrue(") and " == " in line:
line = line.replace("self.assertTrue(", "self.assertEquals(")
line = line.replace(" == ", ", ", 1)
if line.strip().startswith("self.assertTrue(") and " != " in line:
line = line.replace("self.assertTrue(", "self.assertNotEqual(")
line = line.replace(" != ", ", ", 1)
return line
for a in sys.argv[1:]:
with open(a, "r") as f:
lines = f.readlines()
with open(a, "w") as f:
for line in lines:
f.write(sanitize_line(line))
```
Reviewers: labath, JDevlieghere
Reviewed By: labath
Subscribers: abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74475
41 lines
1.6 KiB
Python
41 lines
1.6 KiB
Python
"""Test that C++ global variables can be inspected by name and also their mangled name."""
|
|
|
|
|
|
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class GlobalVariablesCppTestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
def setUp(self):
|
|
TestBase.setUp(self)
|
|
self.source = lldb.SBFileSpec('main.cpp')
|
|
|
|
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24764")
|
|
def test(self):
|
|
self.build()
|
|
|
|
(target, _, _, _) = lldbutil.run_to_source_breakpoint(self, "// Set break point at this line.", self.source)
|
|
|
|
# Check that we can access g_file_global_int by its name
|
|
self.expect("target variable g_file_global_int", VARIABLES_DISPLAYED_CORRECTLY,
|
|
substrs=['42'])
|
|
self.expect("target variable abc::g_file_global_int", VARIABLES_DISPLAYED_CORRECTLY,
|
|
substrs=['42'])
|
|
self.expect("target variable xyz::g_file_global_int", VARIABLES_DISPLAYED_CORRECTLY,
|
|
error=True, substrs=['can\'t find global variable'])
|
|
|
|
# Check that we can access g_file_global_int by its mangled name
|
|
addr = target.EvaluateExpression("&abc::g_file_global_int").GetValueAsUnsigned()
|
|
self.assertNotEqual(addr, 0)
|
|
mangled = lldb.SBAddress(addr, target).GetSymbol().GetMangledName()
|
|
self.assertNotEqual(mangled, None)
|
|
gv = target.FindFirstGlobalVariable(mangled)
|
|
self.assertTrue(gv.IsValid())
|
|
self.assertEqual(gv.GetName(), "abc::g_file_global_int")
|
|
self.assertEqual(gv.GetValueAsUnsigned(), 42)
|