b3a0c4d7dc
Summary:
The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.
This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.
This patch was mostly written by a shell script with some manual verification afterwards:
```
lang=python
import sys
def sanitize_line(line):
if line.strip().startswith("self.assertTrue(") and " == " in line:
line = line.replace("self.assertTrue(", "self.assertEquals(")
line = line.replace(" == ", ", ", 1)
if line.strip().startswith("self.assertTrue(") and " != " in line:
line = line.replace("self.assertTrue(", "self.assertNotEqual(")
line = line.replace(" != ", ", ", 1)
return line
for a in sys.argv[1:]:
with open(a, "r") as f:
lines = f.readlines()
with open(a, "w") as f:
for line in lines:
f.write(sanitize_line(line))
```
Reviewers: labath, JDevlieghere
Reviewed By: labath
Subscribers: abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74475
51 lines
1.9 KiB
Python
51 lines
1.9 KiB
Python
""" Testing explicit symbol loading via target symbols add. """
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class TargetSymbolsAddCommand(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
def setUp(self):
|
|
TestBase.setUp(self)
|
|
self.source = 'main.c'
|
|
|
|
@no_debug_info_test # Prevent the genaration of the dwarf version of this test
|
|
@skipUnlessPlatform(['linux'])
|
|
def test_target_symbols_add(self):
|
|
"""Test that 'target symbols add' can load the symbols
|
|
even if gnu.build-id and gnu_debuglink are not present in the module.
|
|
Similar to test_add_dsym_mid_execution test for macos."""
|
|
self.build()
|
|
exe = self.getBuildArtifact("stripped.out")
|
|
|
|
self.target = self.dbg.CreateTarget(exe)
|
|
self.assertTrue(self.target, VALID_TARGET)
|
|
|
|
main_bp = self.target.BreakpointCreateByName("main", "stripped.out")
|
|
self.assertTrue(main_bp, VALID_BREAKPOINT)
|
|
|
|
self.process = self.target.LaunchSimple(
|
|
None, None, self.get_process_working_directory())
|
|
self.assertTrue(self.process, PROCESS_IS_VALID)
|
|
|
|
# The stop reason of the thread should be breakpoint.
|
|
self.assertEquals(self.process.GetState(), lldb.eStateStopped,
|
|
STOPPED_DUE_TO_BREAKPOINT)
|
|
|
|
exe_module = self.target.GetModuleAtIndex(0)
|
|
|
|
# Check that symbols are not loaded and main.c is not know to be
|
|
# the source file.
|
|
self.expect("frame select", substrs=['main.c'], matching=False)
|
|
|
|
# Tell LLDB that a.out has symbols for stripped.out
|
|
self.runCmd("target symbols add -s %s %s" %
|
|
(exe, self.getBuildArtifact("a.out")))
|
|
|
|
# Check that symbols are now loaded and main.c is in the output.
|
|
self.expect("frame select", substrs=['main.c'])
|