aa56e66bf7
A somewhat common code-pattern is to default a destructor in the source file and not in the header.
For example, this is the way to use smart pointers with forward-declared classes:
```c++
struct Impl;
struct A {
~A(); // Can't be defaulted in the header.
private:
std::unique_ptr<Impl> impl;
};
```
To be able to use this check with this pattern, I modified the behavior with `AllowSoleDefaultDtor`
to not trigger on destructors if they aren't defined yet.
Since a declared destructor should still be defined somewhere in the program, this
won't miss bad classes, just diagnose on less translation units.
Reviewed By: carlosgalvezp
Differential Revision: https://reviews.llvm.org/D143851
27 lines
1.1 KiB
C++
27 lines
1.1 KiB
C++
// RUN: %check_clang_tidy -std=c++98 %s cppcoreguidelines-special-member-functions %t
|
|
|
|
class DefinesDestructor {
|
|
~DefinesDestructor();
|
|
};
|
|
// CHECK-MESSAGES: [[@LINE-3]]:7: warning: class 'DefinesDestructor' defines a destructor but does not define a copy constructor or a copy assignment operator [cppcoreguidelines-special-member-functions]
|
|
|
|
class DefinesCopyConstructor {
|
|
DefinesCopyConstructor(const DefinesCopyConstructor &);
|
|
};
|
|
// CHECK-MESSAGES: [[@LINE-3]]:7: warning: class 'DefinesCopyConstructor' defines a copy constructor but does not define a destructor or a copy assignment operator [cppcoreguidelines-special-member-functions]
|
|
|
|
class DefinesCopyAssignment {
|
|
DefinesCopyAssignment &operator=(const DefinesCopyAssignment &);
|
|
};
|
|
// CHECK-MESSAGES: [[@LINE-3]]:7: warning: class 'DefinesCopyAssignment' defines a copy assignment operator but does not define a destructor or a copy constructor [cppcoreguidelines-special-member-functions]
|
|
|
|
class DefinesNothing {
|
|
};
|
|
|
|
class DefinesEverything {
|
|
DefinesEverything(const DefinesEverything &);
|
|
DefinesEverything &operator=(const DefinesEverything &);
|
|
~DefinesEverything();
|
|
};
|
|
|