5e50dd048e
This commit restructures how TypeID is implemented to ideally avoid the current problems related to shared libraries. This is done by changing the "implicit" fallback path to use the name of the type, instead of using a static template variable (which breaks shared libraries). The major downside to this is that it adds some additional initialization costs for the implicit path. Given the use of type names for uniqueness in the fallback, we also no longer allow types defined in anonymous namespaces to have an implicit TypeID. To simplify defining an ID for these classes, a new `MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID` macro was added to allow for explicitly defining a TypeID directly on an internal class. To help identify when types are using the fallback, `-debug-only=typeid` can be used to log which types are using implicit ids. This change generally only requires changes to the test passes, which are all defined in anonymous namespaces, and thus can't use the fallback any longer. Differential Revision: https://reviews.llvm.org/D122775
76 lines
2.5 KiB
C++
76 lines
2.5 KiB
C++
//===- TestInlining.cpp - Pass to inline calls in the test dialect --------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// TODO: This pass is only necessary because the main inlining pass
|
|
// has no abstracted away the call+callee relationship. When the inlining
|
|
// interface has this support, this pass should be removed.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "TestDialect.h"
|
|
#include "mlir/Dialect/Func/IR/FuncOps.h"
|
|
#include "mlir/IR/BlockAndValueMapping.h"
|
|
#include "mlir/IR/BuiltinOps.h"
|
|
#include "mlir/Pass/Pass.h"
|
|
#include "mlir/Transforms/InliningUtils.h"
|
|
#include "llvm/ADT/StringSet.h"
|
|
|
|
using namespace mlir;
|
|
using namespace test;
|
|
|
|
namespace {
|
|
struct Inliner : public PassWrapper<Inliner, OperationPass<FuncOp>> {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(Inliner)
|
|
|
|
StringRef getArgument() const final { return "test-inline"; }
|
|
StringRef getDescription() const final {
|
|
return "Test inlining region calls";
|
|
}
|
|
|
|
void runOnOperation() override {
|
|
auto function = getOperation();
|
|
|
|
// Collect each of the direct function calls within the module.
|
|
SmallVector<func::CallIndirectOp, 16> callers;
|
|
function.walk(
|
|
[&](func::CallIndirectOp caller) { callers.push_back(caller); });
|
|
|
|
// Build the inliner interface.
|
|
InlinerInterface interface(&getContext());
|
|
|
|
// Try to inline each of the call operations.
|
|
for (auto caller : callers) {
|
|
auto callee = dyn_cast_or_null<FunctionalRegionOp>(
|
|
caller.getCallee().getDefiningOp());
|
|
if (!callee)
|
|
continue;
|
|
|
|
// Inline the functional region operation, but only clone the internal
|
|
// region if there is more than one use.
|
|
if (failed(inlineRegion(
|
|
interface, &callee.getBody(), caller, caller.getArgOperands(),
|
|
caller.getResults(), caller.getLoc(),
|
|
/*shouldCloneInlinedRegion=*/!callee.getResult().hasOneUse())))
|
|
continue;
|
|
|
|
// If the inlining was successful then erase the call and callee if
|
|
// possible.
|
|
caller.erase();
|
|
if (callee.use_empty())
|
|
callee.erase();
|
|
}
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
namespace mlir {
|
|
namespace test {
|
|
void registerInliner() { PassRegistration<Inliner>(); }
|
|
} // namespace test
|
|
} // namespace mlir
|