e28a70daf4
We prioritize non-* wildcards overs VER_NDX_LOCAL/VER_NDX_GLOBAL "*".
This patch generalizes the rule to "*" of other versions and thus fixes PR40176.
I don't feel strongly about this GNU linkers' behavior but the
generalization simplifies code.
Delete `config->defaultSymbolVersion` which was used to special case
VER_NDX_LOCAL/VER_NDX_GLOBAL "*".
In `SymbolTable::scanVersionScript`, custom versions are handled the same
way as VER_NDX_LOCAL/VER_NDX_GLOBAL. So merge
`config->versionScript{Locals,Globals}` into `config->versionDefinitions`.
Overall this seems to simplify the code.
In `SymbolTable::assign{Exact,Wildcard}Versions`,
`sym->verdefIndex == config->defaultSymbolVersion` is changed to
`verdefIndex == UINT32_C(-1)`.
This allows us to give duplicate assignment diagnostics for
`{ global: foo; };` `V1 { global: foo; };`
In test/linkerscript/version-script.s:
vs_index of an undefined symbol changes from 0 to 1. This doesn't matter (arguably 1 is better because the binding is STB_GLOBAL) because vs_index of an undefined symbol is ignored.
Reviewed By: ruiu
Differential Revision: https://reviews.llvm.org/D65716
llvm-svn: 367869
58 lines
1.8 KiB
ArmAsm
58 lines
1.8 KiB
ArmAsm
# REQUIRES: x86
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
|
|
|
|
# RUN: echo "bar = foo; VERSION { V { global: foo; bar; local: *; }; }" > %t.script
|
|
# RUN: ld.lld -T %t.script -shared --no-undefined-version %t.o -o %t.so
|
|
# RUN: llvm-readobj -V %t.so | FileCheck %s
|
|
|
|
# RUN: echo "SECTIONS { .text : { bar = foo; *(.text) } }" > %t.script
|
|
# RUN: echo "VERSION { V { global: foo; bar; local: *; }; }" >> %t.script
|
|
# RUN: ld.lld -T %t.script -shared --no-undefined-version %t.o -o %t.so
|
|
# RUN: llvm-readobj -V %t.so | FileCheck %s
|
|
|
|
## Check that we are able to version symbols defined in script.
|
|
# CHECK: Symbols [
|
|
# CHECK-NEXT: Symbol {
|
|
# CHECK-NEXT: Version: 0
|
|
# CHECK-NEXT: Name:
|
|
# CHECK-NEXT: }
|
|
# CHECK-NEXT: Symbol {
|
|
# CHECK-NEXT: Version: 1
|
|
# CHECK-NEXT: Name: und
|
|
# CHECK-NEXT: }
|
|
# CHECK-NEXT: Symbol {
|
|
# CHECK-NEXT: Version: 2
|
|
# CHECK-NEXT: Name: foo@@V
|
|
# CHECK-NEXT: }
|
|
# CHECK-NEXT: Symbol {
|
|
# CHECK-NEXT: Version: 2
|
|
# CHECK-NEXT: Name: bar@@V
|
|
# CHECK-NEXT: }
|
|
# CHECK-NEXT: ]
|
|
|
|
# RUN: echo "bar = und; VERSION { V { global: foo; bar; local: *; }; }" > %t.script
|
|
# RUN: not ld.lld -T %t.script -shared --no-undefined-version %t.o -o %t.so \
|
|
# RUN: 2>&1 | FileCheck --check-prefix=ERR %s
|
|
# ERR: symbol not found: und
|
|
|
|
# RUN: echo "und = 0x1; VERSION { V { global: und; local: *; }; }" > %t.script
|
|
# RUN: ld.lld -T %t.script -shared --no-undefined-version %t.o -o %t.so
|
|
# RUN: llvm-readobj -V %t.so | FileCheck %s --check-prefix=UNDEF
|
|
# UNDEF: Symbols [
|
|
# UNDEF-NEXT: Symbol {
|
|
# UNDEF-NEXT: Version: 0
|
|
# UNDEF-NEXT: Name:
|
|
# UNDEF-NEXT: }
|
|
# UNDEF-NEXT: Symbol {
|
|
# UNDEF-NEXT: Version: 2
|
|
# UNDEF-NEXT: Name: und@@V
|
|
# UNDEF-NEXT: }
|
|
# UNDEF-NEXT: ]
|
|
|
|
.global und
|
|
|
|
.text
|
|
.globl foo
|
|
.type foo,@function
|
|
foo:
|