8b3af63b89
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
86 lines
2.7 KiB
C++
86 lines
2.7 KiB
C++
//===-- OperatingSystemPython.h ---------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_OperatingSystemPython_h_
|
|
#define liblldb_OperatingSystemPython_h_
|
|
|
|
#ifndef LLDB_DISABLE_PYTHON
|
|
|
|
#include "lldb/Target/OperatingSystem.h"
|
|
#include "lldb/Utility/StructuredData.h"
|
|
|
|
class DynamicRegisterInfo;
|
|
|
|
namespace lldb_private {
|
|
class ScriptInterpreter;
|
|
}
|
|
|
|
class OperatingSystemPython : public lldb_private::OperatingSystem {
|
|
public:
|
|
OperatingSystemPython(lldb_private::Process *process,
|
|
const lldb_private::FileSpec &python_module_path);
|
|
|
|
~OperatingSystemPython() override;
|
|
|
|
// Static Functions
|
|
static lldb_private::OperatingSystem *
|
|
CreateInstance(lldb_private::Process *process, bool force);
|
|
|
|
static void Initialize();
|
|
|
|
static void Terminate();
|
|
|
|
static lldb_private::ConstString GetPluginNameStatic();
|
|
|
|
static const char *GetPluginDescriptionStatic();
|
|
|
|
// lldb_private::PluginInterface Methods
|
|
lldb_private::ConstString GetPluginName() override;
|
|
|
|
uint32_t GetPluginVersion() override;
|
|
|
|
// lldb_private::OperatingSystem Methods
|
|
bool UpdateThreadList(lldb_private::ThreadList &old_thread_list,
|
|
lldb_private::ThreadList &real_thread_list,
|
|
lldb_private::ThreadList &new_thread_list) override;
|
|
|
|
void ThreadWasSelected(lldb_private::Thread *thread) override;
|
|
|
|
lldb::RegisterContextSP
|
|
CreateRegisterContextForThread(lldb_private::Thread *thread,
|
|
lldb::addr_t reg_data_addr) override;
|
|
|
|
lldb::StopInfoSP
|
|
CreateThreadStopReason(lldb_private::Thread *thread) override;
|
|
|
|
// Method for lazy creation of threads on demand
|
|
lldb::ThreadSP CreateThread(lldb::tid_t tid, lldb::addr_t context) override;
|
|
|
|
protected:
|
|
bool IsValid() const {
|
|
return m_python_object_sp && m_python_object_sp->IsValid();
|
|
}
|
|
|
|
lldb::ThreadSP CreateThreadFromThreadInfo(
|
|
lldb_private::StructuredData::Dictionary &thread_dict,
|
|
lldb_private::ThreadList &core_thread_list,
|
|
lldb_private::ThreadList &old_thread_list,
|
|
std::vector<bool> &core_used_map, bool *did_create_ptr);
|
|
|
|
DynamicRegisterInfo *GetDynamicRegisterInfo();
|
|
|
|
lldb::ValueObjectSP m_thread_list_valobj_sp;
|
|
std::unique_ptr<DynamicRegisterInfo> m_register_info_up;
|
|
lldb_private::ScriptInterpreter *m_interpreter;
|
|
lldb_private::StructuredData::ObjectSP m_python_object_sp;
|
|
};
|
|
|
|
#endif // LLDB_DISABLE_PYTHON
|
|
|
|
#endif // liblldb_OperatingSystemPython_h_
|