647c3f4e47
Summary: This patch could be treated as a rebase of D33960. It also fixes PR35547. A fix for `llvm/test/Other/close-stderr.ll` is proposed in D68164. Seems the consensus is that the test is passing by chance and I'm not sure how important it is for us. So it is removed like in D33960 for now. The rest of the test fixes are just adding `--crash` flag to `not` tool. ** The reason it fixes PR35547 is `exit` does cleanup including calling class destructor whereas `abort` does not do any cleanup. In multithreading environment such as ThinLTO or JIT, threads may share states which mostly are ManagedStatic<>. If faulting thread tearing down a class when another thread is using it, there are chances of memory corruption. This is bad 1. It will stop error reporting like pretty stack printer; 2. The memory corruption is distracting and nondeterministic in terms of error message, and corruption type (depending one the timing, it could be double free, heap free after use, etc.). Reviewers: rnk, chandlerc, zturner, sepavloff, MaskRay, espindola Reviewed By: rnk, MaskRay Subscribers: wuzish, jholewinski, qcolombet, dschuff, jyknight, emaste, sdardis, nemanjai, jvesely, nhaehnle, sbc100, arichardson, jgravelle-google, aheejin, kbarton, fedor.sergeev, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, PkmX, jocewei, jsji, lenary, s.egerton, pzheng, cfe-commits, MaskRay, filcab, davide, MatzeB, mehdi_amini, hiraditya, steven_wu, dexonsmith, rupprecht, seiya, llvm-commits Tags: #llvm, #clang Differential Revision: https://reviews.llvm.org/D67847
36 lines
1.3 KiB
LLVM
36 lines
1.3 KiB
LLVM
; RUN: llvm-as %s -o - | llvm-dis - | FileCheck %s -check-prefixes CHECK,PROG-AS0
|
|
; RUN: llvm-as -data-layout "P200" %s -o - | llvm-dis | FileCheck %s -check-prefixes CHECK,PROG-AS200
|
|
; RUN: not --crash llvm-as -data-layout "P123456789" %s -o /dev/null 2>&1 | FileCheck %s -check-prefix BAD-DATALAYOUT
|
|
; BAD-DATALAYOUT: LLVM ERROR: Invalid address space, must be a 24-bit integer
|
|
|
|
; PROG-AS0-NOT: target datalayout
|
|
; PROG-AS200: target datalayout = "P200"
|
|
|
|
; Check that a function declaration without an address space (i.e. AS0) does not
|
|
; have the addrspace() attribute printed if it is address space zero and it is
|
|
; equal to the program address space.
|
|
|
|
; PROG-AS0: define void @no_as() {
|
|
; PROG-AS200: define void @no_as() addrspace(200) {
|
|
define void @no_as() {
|
|
ret void
|
|
}
|
|
|
|
; A function with an explicit addrspace should only have the addrspace printed
|
|
; if it is non-zero or if the module has a nonzero datalayout
|
|
; PROG-AS0: define void @explit_as0() {
|
|
; PROG-AS200: define void @explit_as0() addrspace(0) {
|
|
define void @explit_as0() addrspace(0) {
|
|
ret void
|
|
}
|
|
|
|
; CHECK: define void @explit_as200() addrspace(200) {
|
|
define void @explit_as200() addrspace(200) {
|
|
ret void
|
|
}
|
|
|
|
; CHECK: define void @explicit_as3() addrspace(3) {
|
|
define void @explicit_as3() addrspace(3) {
|
|
ret void
|
|
}
|