64c92df7cb
Summary: This patch makes Windows threads to compare by a thread ID, not by a handle. It's because the same thread can have different handles on Windows (for example, `GetCurrentThread` always returns the fake handle `-2`). This leads to some incorrect behavior. For example, in `Process::GetRunLock` always `m_public_run_lock` is returned without this patch. Reviewers: zturner, clayborg, stella.stamenova Reviewed By: stella.stamenova Subscribers: stella.stamenova, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D53357 llvm-svn: 344729
76 lines
2.0 KiB
C++
76 lines
2.0 KiB
C++
//===-- HostThreadWindows.cpp -----------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Utility/Status.h"
|
|
|
|
#include "lldb/Host/windows/HostThreadWindows.h"
|
|
#include "lldb/Host/windows/windows.h"
|
|
|
|
#include "llvm/ADT/STLExtras.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
namespace {
|
|
void __stdcall ExitThreadProxy(ULONG_PTR dwExitCode) {
|
|
::ExitThread(dwExitCode);
|
|
}
|
|
}
|
|
|
|
HostThreadWindows::HostThreadWindows()
|
|
: HostNativeThreadBase(), m_owns_handle(true) {}
|
|
|
|
HostThreadWindows::HostThreadWindows(lldb::thread_t thread)
|
|
: HostNativeThreadBase(thread), m_owns_handle(true) {}
|
|
|
|
HostThreadWindows::~HostThreadWindows() { Reset(); }
|
|
|
|
void HostThreadWindows::SetOwnsHandle(bool owns) { m_owns_handle = owns; }
|
|
|
|
Status HostThreadWindows::Join(lldb::thread_result_t *result) {
|
|
Status error;
|
|
if (IsJoinable()) {
|
|
DWORD wait_result = ::WaitForSingleObject(m_thread, INFINITE);
|
|
if (WAIT_OBJECT_0 == wait_result && result) {
|
|
DWORD exit_code = 0;
|
|
if (!::GetExitCodeThread(m_thread, &exit_code))
|
|
*result = 0;
|
|
*result = exit_code;
|
|
} else if (WAIT_OBJECT_0 != wait_result)
|
|
error.SetError(::GetLastError(), eErrorTypeWin32);
|
|
} else
|
|
error.SetError(ERROR_INVALID_HANDLE, eErrorTypeWin32);
|
|
|
|
Reset();
|
|
return error;
|
|
}
|
|
|
|
Status HostThreadWindows::Cancel() {
|
|
Status error;
|
|
|
|
DWORD result = ::QueueUserAPC(::ExitThreadProxy, m_thread, 0);
|
|
error.SetError(result, eErrorTypeWin32);
|
|
return error;
|
|
}
|
|
|
|
lldb::tid_t HostThreadWindows::GetThreadId() const {
|
|
return ::GetThreadId(m_thread);
|
|
}
|
|
|
|
void HostThreadWindows::Reset() {
|
|
if (m_owns_handle && m_thread != LLDB_INVALID_HOST_THREAD)
|
|
::CloseHandle(m_thread);
|
|
|
|
HostNativeThreadBase::Reset();
|
|
}
|
|
|
|
bool HostThreadWindows::EqualsThread(lldb::thread_t thread) const {
|
|
return GetThreadId() == ::GetThreadId(thread);
|
|
}
|