67cbfb9d8c
Resolves #99114. Tasks completed: - Implement `faceforward` in `hlsl_intrinsics.h`/`hlsl_intrinsic_helpers.h` - Implement `faceforward` SPIR-V target builtin in `clang/include/clang/Basic/BuiltinsSPIRV.td` - Add a SPIR-V fast path in `hlsl_intrinsic_helpers.h` - Add sema checks for `faceforward` to `CheckSPIRVBuiltinFunctionCall` in `clang/lib/Sema/SemaSPIRV.cpp` - Add codegen for SPIR-V `faceforward` builtin to `EmitSPIRVBuiltinExpr` in `SPIR.cpp` - Add HLSL codegen tests to `clang/test/CodeGenHLSL/builtins/faceforward.hlsl` - Add SPIRV builtin codegen tests to `clang/test/CodeGenSPIRV/Builtins/faceforward.c` - Add sema tests to `clang/test/SemaHLSL/BuiltIns/faceforward-errors.hlsl` - Add spirv sema tests to `clang/test/SemaSPIRV/BuiltIns/faceforward-errors.c` - Create the `int_spv_faceforward` intrinsic in `IntrinsicsSPIRV.td` - In `SPIRVInstructionSelector.cpp` create the `faceforward` lowering and map it to `int_spv_faceforward` in `SPIRVInstructionSelector::selectIntrinsic` - Create SPIR-V backend test case in `llvm/test/CodeGen/SPIRV/hlsl-intrinsics/faceforward.ll` Incomplete tasks: - Create SPIR-V backend test case in `llvm/test/CodeGen/SPIRV/opencl/faceforward.ll` - Not applicable because the OpenCL SPIR-V extended instruction set does not include a `faceforward` function Follow-up tasks: - Implement pattern matching for `faceforward` in `SPIRVCombine.td` and `SPIRVPreLegalizerCombiner.cpp` - In `faceforward.ll`, change `--target-env spv1.4` to `vulkan1.3` and update the test accordingly once [#136344](https://github.com/llvm/llvm-project/issues/136344) has been resolved
63 lines
3.4 KiB
LLVM
63 lines
3.4 KiB
LLVM
; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val --target-env spv1.4 %}
|
|
|
|
; FIXME(#136344): Change --target-env to vulkan1.3 and update this test accordingly once the issue is resolved.
|
|
|
|
; Make sure SPIRV operation function calls for faceforward are lowered correctly.
|
|
|
|
; CHECK-DAG: %[[#op_ext_glsl:]] = OpExtInstImport "GLSL.std.450"
|
|
; CHECK-DAG: %[[#float_16:]] = OpTypeFloat 16
|
|
; CHECK-DAG: %[[#vec4_float_16:]] = OpTypeVector %[[#float_16]] 4
|
|
; CHECK-DAG: %[[#float_32:]] = OpTypeFloat 32
|
|
; CHECK-DAG: %[[#vec4_float_32:]] = OpTypeVector %[[#float_32]] 4
|
|
|
|
define noundef half @faceforward_half(half noundef %a, half noundef %b, half noundef %c) {
|
|
entry:
|
|
; CHECK: %[[#]] = OpFunction %[[#float_16]] None %[[#]]
|
|
; CHECK: %[[#arg0:]] = OpFunctionParameter %[[#float_16]]
|
|
; CHECK: %[[#arg1:]] = OpFunctionParameter %[[#float_16]]
|
|
; CHECK: %[[#arg2:]] = OpFunctionParameter %[[#float_16]]
|
|
; CHECK: %[[#]] = OpExtInst %[[#float_16]] %[[#op_ext_glsl]] FaceForward %[[#arg0]] %[[#arg1]] %[[#arg2]]
|
|
%spv.faceforward = call half @llvm.spv.faceforward.f16(half %a, half %b, half %c)
|
|
ret half %spv.faceforward
|
|
}
|
|
|
|
define noundef float @faceforward_float(float noundef %a, float noundef %b, float noundef %c) {
|
|
entry:
|
|
; CHECK: %[[#]] = OpFunction %[[#float_32]] None %[[#]]
|
|
; CHECK: %[[#arg0:]] = OpFunctionParameter %[[#float_32]]
|
|
; CHECK: %[[#arg1:]] = OpFunctionParameter %[[#float_32]]
|
|
; CHECK: %[[#arg2:]] = OpFunctionParameter %[[#float_32]]
|
|
; CHECK: %[[#]] = OpExtInst %[[#float_32]] %[[#op_ext_glsl]] FaceForward %[[#arg0]] %[[#arg1]] %[[#arg2]]
|
|
%spv.faceforward = call float @llvm.spv.faceforward.f32(float %a, float %b, float %c)
|
|
ret float %spv.faceforward
|
|
}
|
|
|
|
define noundef <4 x half> @faceforward_half4(<4 x half> noundef %a, <4 x half> noundef %b, <4 x half> noundef %c) {
|
|
entry:
|
|
; CHECK: %[[#]] = OpFunction %[[#vec4_float_16]] None %[[#]]
|
|
; CHECK: %[[#arg0:]] = OpFunctionParameter %[[#vec4_float_16]]
|
|
; CHECK: %[[#arg1:]] = OpFunctionParameter %[[#vec4_float_16]]
|
|
; CHECK: %[[#arg2:]] = OpFunctionParameter %[[#vec4_float_16]]
|
|
; CHECK: %[[#]] = OpExtInst %[[#vec4_float_16]] %[[#op_ext_glsl]] FaceForward %[[#arg0]] %[[#arg1]] %[[#arg2]]
|
|
%spv.faceforward = call <4 x half> @llvm.spv.faceforward.v4f16(<4 x half> %a, <4 x half> %b, <4 x half> %c)
|
|
ret <4 x half> %spv.faceforward
|
|
}
|
|
|
|
define noundef <4 x float> @faceforward_float4(<4 x float> noundef %a, <4 x float> noundef %b, <4 x float> noundef %c) {
|
|
entry:
|
|
; CHECK: %[[#]] = OpFunction %[[#vec4_float_32]] None %[[#]]
|
|
; CHECK: %[[#arg0:]] = OpFunctionParameter %[[#vec4_float_32]]
|
|
; CHECK: %[[#arg1:]] = OpFunctionParameter %[[#vec4_float_32]]
|
|
; CHECK: %[[#arg2:]] = OpFunctionParameter %[[#vec4_float_32]]
|
|
; CHECK: %[[#]] = OpExtInst %[[#vec4_float_32]] %[[#op_ext_glsl]] FaceForward %[[#arg0]] %[[#arg1]] %[[#arg2]]
|
|
%spv.faceforward = call <4 x float> @llvm.spv.faceforward.v4f32(<4 x float> %a, <4 x float> %b, <4 x float> %c)
|
|
ret <4 x float> %spv.faceforward
|
|
}
|
|
|
|
declare half @llvm.spv.faceforward.f16(half, half, half)
|
|
declare float @llvm.spv.faceforward.f32(float, float, float)
|
|
|
|
declare <4 x half> @llvm.spv.faceforward.v4f16(<4 x half>, <4 x half>, <4 x half>)
|
|
declare <4 x float> @llvm.spv.faceforward.v4f32(<4 x float>, <4 x float>, <4 x float>)
|