This new option is set to `false` by default. It should be set only in Canonicalizer tests to detect faulty canonicalization patterns. I.e., patterns that prevent the canonicalizer from converging. The canonicalizer should always convergence on such small unit tests that we have in `canonicalize.mlir`. Two faulty canonicalization patterns were detected and fixed with this change. Differential Revision: https://reviews.llvm.org/D140873
84 lines
3.2 KiB
C++
84 lines
3.2 KiB
C++
//===- Canonicalizer.cpp - Canonicalize MLIR operations -------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This transformation pass converts operations into their canonical forms by
|
|
// folding constants, applying operation identity transformations etc.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/Transforms/Passes.h"
|
|
|
|
#include "mlir/Pass/Pass.h"
|
|
#include "mlir/Transforms/GreedyPatternRewriteDriver.h"
|
|
|
|
namespace mlir {
|
|
#define GEN_PASS_DEF_CANONICALIZER
|
|
#include "mlir/Transforms/Passes.h.inc"
|
|
} // namespace mlir
|
|
|
|
using namespace mlir;
|
|
|
|
namespace {
|
|
/// Canonicalize operations in nested regions.
|
|
struct Canonicalizer : public impl::CanonicalizerBase<Canonicalizer> {
|
|
Canonicalizer() = default;
|
|
Canonicalizer(const GreedyRewriteConfig &config,
|
|
ArrayRef<std::string> disabledPatterns,
|
|
ArrayRef<std::string> enabledPatterns) {
|
|
this->topDownProcessingEnabled = config.useTopDownTraversal;
|
|
this->enableRegionSimplification = config.enableRegionSimplification;
|
|
this->maxIterations = config.maxIterations;
|
|
this->maxNumRewrites = config.maxNumRewrites;
|
|
this->disabledPatterns = disabledPatterns;
|
|
this->enabledPatterns = enabledPatterns;
|
|
}
|
|
|
|
/// Initialize the canonicalizer by building the set of patterns used during
|
|
/// execution.
|
|
LogicalResult initialize(MLIRContext *context) override {
|
|
RewritePatternSet owningPatterns(context);
|
|
for (auto *dialect : context->getLoadedDialects())
|
|
dialect->getCanonicalizationPatterns(owningPatterns);
|
|
for (RegisteredOperationName op : context->getRegisteredOperations())
|
|
op.getCanonicalizationPatterns(owningPatterns, context);
|
|
|
|
patterns = FrozenRewritePatternSet(std::move(owningPatterns),
|
|
disabledPatterns, enabledPatterns);
|
|
return success();
|
|
}
|
|
void runOnOperation() override {
|
|
GreedyRewriteConfig config;
|
|
config.useTopDownTraversal = topDownProcessingEnabled;
|
|
config.enableRegionSimplification = enableRegionSimplification;
|
|
config.maxIterations = maxIterations;
|
|
config.maxNumRewrites = maxNumRewrites;
|
|
LogicalResult converged =
|
|
applyPatternsAndFoldGreedily(getOperation(), patterns, config);
|
|
// Canonicalization is best-effort. Non-convergence is not a pass failure.
|
|
if (testConvergence && failed(converged))
|
|
signalPassFailure();
|
|
}
|
|
|
|
FrozenRewritePatternSet patterns;
|
|
};
|
|
} // namespace
|
|
|
|
/// Create a Canonicalizer pass.
|
|
std::unique_ptr<Pass> mlir::createCanonicalizerPass() {
|
|
return std::make_unique<Canonicalizer>();
|
|
}
|
|
|
|
/// Creates an instance of the Canonicalizer pass with the specified config.
|
|
std::unique_ptr<Pass>
|
|
mlir::createCanonicalizerPass(const GreedyRewriteConfig &config,
|
|
ArrayRef<std::string> disabledPatterns,
|
|
ArrayRef<std::string> enabledPatterns) {
|
|
return std::make_unique<Canonicalizer>(config, disabledPatterns,
|
|
enabledPatterns);
|
|
}
|