aa56e66bf7
A somewhat common code-pattern is to default a destructor in the source file and not in the header.
For example, this is the way to use smart pointers with forward-declared classes:
```c++
struct Impl;
struct A {
~A(); // Can't be defaulted in the header.
private:
std::unique_ptr<Impl> impl;
};
```
To be able to use this check with this pattern, I modified the behavior with `AllowSoleDefaultDtor`
to not trigger on destructors if they aren't defined yet.
Since a declared destructor should still be defined somewhere in the program, this
won't miss bad classes, just diagnose on less translation units.
Reviewed By: carlosgalvezp
Differential Revision: https://reviews.llvm.org/D143851
73 lines
3.5 KiB
C++
73 lines
3.5 KiB
C++
// RUN: %check_clang_tidy %s cppcoreguidelines-special-member-functions %t
|
|
|
|
class DefinesDestructor {
|
|
~DefinesDestructor();
|
|
};
|
|
// CHECK-MESSAGES: [[@LINE-3]]:7: warning: class 'DefinesDestructor' defines a destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
|
|
|
|
class DefinesDefaultedDestructor {
|
|
~DefinesDefaultedDestructor() = default;
|
|
};
|
|
// CHECK-MESSAGES: [[@LINE-3]]:7: warning: class 'DefinesDefaultedDestructor' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
|
|
|
|
class DefinesCopyConstructor {
|
|
DefinesCopyConstructor(const DefinesCopyConstructor &);
|
|
};
|
|
// CHECK-MESSAGES: [[@LINE-3]]:7: warning: class 'DefinesCopyConstructor' defines a copy constructor but does not define a destructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
|
|
|
|
class DefinesCopyAssignment {
|
|
DefinesCopyAssignment &operator=(const DefinesCopyAssignment &);
|
|
};
|
|
// CHECK-MESSAGES: [[@LINE-3]]:7: warning: class 'DefinesCopyAssignment' defines a copy assignment operator but does not define a destructor, a copy constructor, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
|
|
|
|
class DefinesMoveConstructor {
|
|
DefinesMoveConstructor(DefinesMoveConstructor &&);
|
|
};
|
|
// CHECK-MESSAGES: [[@LINE-3]]:7: warning: class 'DefinesMoveConstructor' defines a move constructor but does not define a destructor, a copy constructor, a copy assignment operator or a move assignment operator [cppcoreguidelines-special-member-functions]
|
|
|
|
class DefinesMoveAssignment {
|
|
DefinesMoveAssignment &operator=(DefinesMoveAssignment &&);
|
|
};
|
|
// CHECK-MESSAGES: [[@LINE-3]]:7: warning: class 'DefinesMoveAssignment' defines a move assignment operator but does not define a destructor, a copy constructor, a copy assignment operator or a move constructor [cppcoreguidelines-special-member-functions]
|
|
class DefinesNothing {
|
|
};
|
|
|
|
class DefinesEverything {
|
|
DefinesEverything(const DefinesEverything &);
|
|
DefinesEverything &operator=(const DefinesEverything &);
|
|
DefinesEverything(DefinesEverything &&);
|
|
DefinesEverything &operator=(DefinesEverything &&);
|
|
~DefinesEverything();
|
|
};
|
|
|
|
class DeletesEverything {
|
|
DeletesEverything(const DeletesEverything &) = delete;
|
|
DeletesEverything &operator=(const DeletesEverything &) = delete;
|
|
DeletesEverything(DeletesEverything &&) = delete;
|
|
DeletesEverything &operator=(DeletesEverything &&) = delete;
|
|
~DeletesEverything() = delete;
|
|
};
|
|
|
|
class DeletesCopyDefaultsMove {
|
|
DeletesCopyDefaultsMove(const DeletesCopyDefaultsMove &) = delete;
|
|
DeletesCopyDefaultsMove &operator=(const DeletesCopyDefaultsMove &) = delete;
|
|
DeletesCopyDefaultsMove(DeletesCopyDefaultsMove &&) = default;
|
|
DeletesCopyDefaultsMove &operator=(DeletesCopyDefaultsMove &&) = default;
|
|
~DeletesCopyDefaultsMove() = default;
|
|
};
|
|
|
|
template <typename T>
|
|
struct TemplateClass {
|
|
TemplateClass() = default;
|
|
TemplateClass(const TemplateClass &);
|
|
TemplateClass &operator=(const TemplateClass &);
|
|
TemplateClass(TemplateClass &&);
|
|
TemplateClass &operator=(TemplateClass &&);
|
|
~TemplateClass();
|
|
};
|
|
|
|
// Multiple instantiations of a class template will trigger multiple matches for defined special members.
|
|
// This should not cause problems.
|
|
TemplateClass<int> InstantiationWithInt;
|
|
TemplateClass<double> InstantiationWithDouble;
|