d482fe2add
Pavel Labath wrote in D73206: The internal representation of DebugNames and Apple indexes is fixed by the relevant (pseudo-)standards, so we can't really change it. The question is how to efficiently (and cleanly) convert from the internal representation to some common thing. The conversion from AppleIndex to DIERef is trivial (which is not surprising as it was the first and the overall design was optimized for that). With debug_names, the situation gets more tricky. The internal representation of debug_names uses CU-relative DIE offsets, but DIERef wants an absolute offset. That means the index has to do more work to produce the common representation. And it needs to do that for all results, even though a lot of the index users are really interested only in a single entry. With the switch to user_id_t, _all_ indexes would have to do some extra work to encode it, only for their users to have to immediately decode it back. Having a iterator/callback based api would allow us to minimize the impact of that, as it would only need to happen for the entries that are really used. And /I think/ we could make it interface returns DWARFDies directly, and each index converts to that using the most direct approach available. Jan Kratochvil: It also makes all the callers shorter as they no longer need to fetch DWARFDIE from DIERef (and handling if not found by ReportInvalidDIERef) but the callers are already served DWARFDIE which they need. In some cases the DWARFDIE had to be fetched both by callee (DWARFIndex implementation) and caller. Differential Revision: https://reviews.llvm.org/D77970
87 lines
3.2 KiB
C++
87 lines
3.2 KiB
C++
//===-- DWARFIndex.cpp ----------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "Plugins/SymbolFile/DWARF/DWARFIndex.h"
|
|
#include "Plugins/Language/ObjC/ObjCLanguage.h"
|
|
#include "Plugins/SymbolFile/DWARF/DWARFDIE.h"
|
|
#include "Plugins/SymbolFile/DWARF/SymbolFileDWARF.h"
|
|
|
|
#include "lldb/Core/Module.h"
|
|
|
|
using namespace lldb_private;
|
|
using namespace lldb;
|
|
|
|
DWARFIndex::~DWARFIndex() = default;
|
|
|
|
bool DWARFIndex::ProcessFunctionDIE(
|
|
llvm::StringRef name, DIERef ref, SymbolFileDWARF &dwarf,
|
|
const CompilerDeclContext &parent_decl_ctx, uint32_t name_type_mask,
|
|
llvm::function_ref<bool(DWARFDIE die)> callback) {
|
|
DWARFDIE die = dwarf.GetDIE(ref);
|
|
if (!die) {
|
|
ReportInvalidDIERef(ref, name);
|
|
return true;
|
|
}
|
|
|
|
// Exit early if we're searching exclusively for methods or selectors and
|
|
// we have a context specified (no methods in namespaces).
|
|
uint32_t looking_for_nonmethods =
|
|
name_type_mask & ~(eFunctionNameTypeMethod | eFunctionNameTypeSelector);
|
|
if (!looking_for_nonmethods && parent_decl_ctx.IsValid())
|
|
return true;
|
|
|
|
// Otherwise, we need to also check that the context matches. If it does not
|
|
// match, we do nothing.
|
|
if (!SymbolFileDWARF::DIEInDeclContext(parent_decl_ctx, die))
|
|
return true;
|
|
|
|
// In case of a full match, we just insert everything we find.
|
|
if (name_type_mask & eFunctionNameTypeFull)
|
|
return callback(die);
|
|
|
|
// If looking for ObjC selectors, we need to also check if the name is a
|
|
// possible selector.
|
|
if (name_type_mask & eFunctionNameTypeSelector &&
|
|
ObjCLanguage::IsPossibleObjCMethodName(die.GetName()))
|
|
return callback(die);
|
|
|
|
bool looking_for_methods = name_type_mask & lldb::eFunctionNameTypeMethod;
|
|
bool looking_for_functions = name_type_mask & lldb::eFunctionNameTypeBase;
|
|
if (looking_for_methods || looking_for_functions) {
|
|
// If we're looking for either methods or functions, we definitely want this
|
|
// die. Otherwise, only keep it if the die type matches what we are
|
|
// searching for.
|
|
if ((looking_for_methods && looking_for_functions) ||
|
|
looking_for_methods == die.IsMethod())
|
|
return callback(die);
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
DWARFIndex::DIERefCallbackImpl::DIERefCallbackImpl(
|
|
const DWARFIndex &index, llvm::function_ref<bool(DWARFDIE die)> callback,
|
|
llvm::StringRef name)
|
|
: m_index(index),
|
|
m_dwarf(*llvm::cast<SymbolFileDWARF>(index.m_module.GetSymbolFile())),
|
|
m_callback(callback), m_name(name) {}
|
|
|
|
bool DWARFIndex::DIERefCallbackImpl::operator()(DIERef ref) const {
|
|
if (DWARFDIE die = m_dwarf.GetDIE(ref))
|
|
return m_callback(die);
|
|
m_index.ReportInvalidDIERef(ref, m_name);
|
|
return true;
|
|
}
|
|
|
|
void DWARFIndex::ReportInvalidDIERef(DIERef ref, llvm::StringRef name) const {
|
|
m_module.ReportErrorIfModifyDetected(
|
|
"the DWARF debug information has been modified (accelerator table had "
|
|
"bad die 0x%8.8x for '%s')\n",
|
|
ref.die_offset(), name.str().c_str());
|
|
}
|