This reapplies54a61c94f9, its follow up in547b712500, which were reverted95fe61e639. Original commit message: VarLoc based LiveDebugValues will abandon variable location propagation if there are too many blocks and variable assignments in the function. If it didn't, and we had (say) 1000 blocks and 1000 variables in scope, we'd end up with 1 million DBG_VALUEs just at the start of blocks. Instruction-referencing LiveDebugValues should honour this limitation too (because the same limitation applies to it). Hoist the relevant command line options into LiveDebugValues.cpp and pass it down into the implementation classes as an argument to ExtendRanges. I've duplicated all the run-lines in live-debug-values-cutoffs.mir to have an instruction-referencing flavour. Differential Revision: https://reviews.llvm.org/D107823
120 lines
4.0 KiB
C++
120 lines
4.0 KiB
C++
//===- LiveDebugValues.cpp - Tracking Debug Value MIs ---------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "LiveDebugValues.h"
|
|
|
|
#include "llvm/CodeGen/MachineBasicBlock.h"
|
|
#include "llvm/CodeGen/MachineFrameInfo.h"
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
#include "llvm/CodeGen/Passes.h"
|
|
#include "llvm/InitializePasses.h"
|
|
#include "llvm/Pass.h"
|
|
#include "llvm/Support/CommandLine.h"
|
|
#include "llvm/Target/TargetMachine.h"
|
|
|
|
/// \file LiveDebugValues.cpp
|
|
///
|
|
/// The LiveDebugValues pass extends the range of variable locations
|
|
/// (specified by DBG_VALUE instructions) from single blocks to successors
|
|
/// and any other code locations where the variable location is valid.
|
|
/// There are currently two implementations: the "VarLoc" implementation
|
|
/// explicitly tracks the location of a variable, while the "InstrRef"
|
|
/// implementation tracks the values defined by instructions through locations.
|
|
///
|
|
/// This file implements neither; it merely registers the pass, allows the
|
|
/// user to pick which implementation will be used to propagate variable
|
|
/// locations.
|
|
|
|
#define DEBUG_TYPE "livedebugvalues"
|
|
|
|
using namespace llvm;
|
|
|
|
static cl::opt<bool>
|
|
ForceInstrRefLDV("force-instr-ref-livedebugvalues", cl::Hidden,
|
|
cl::desc("Use instruction-ref based LiveDebugValues with "
|
|
"normal DBG_VALUE inputs"),
|
|
cl::init(false));
|
|
|
|
// Options to prevent pathological compile-time behavior. If InputBBLimit and
|
|
// InputDbgValueLimit are both exceeded, range extension is disabled.
|
|
static cl::opt<unsigned> InputBBLimit(
|
|
"livedebugvalues-input-bb-limit",
|
|
cl::desc("Maximum input basic blocks before DBG_VALUE limit applies"),
|
|
cl::init(10000), cl::Hidden);
|
|
static cl::opt<unsigned> InputDbgValueLimit(
|
|
"livedebugvalues-input-dbg-value-limit",
|
|
cl::desc(
|
|
"Maximum input DBG_VALUE insts supported by debug range extension"),
|
|
cl::init(50000), cl::Hidden);
|
|
|
|
/// Generic LiveDebugValues pass. Calls through to VarLocBasedLDV or
|
|
/// InstrRefBasedLDV to perform location propagation, via the LDVImpl
|
|
/// base class.
|
|
class LiveDebugValues : public MachineFunctionPass {
|
|
public:
|
|
static char ID;
|
|
|
|
LiveDebugValues();
|
|
~LiveDebugValues() {
|
|
if (TheImpl)
|
|
delete TheImpl;
|
|
}
|
|
|
|
/// Calculate the liveness information for the given machine function.
|
|
bool runOnMachineFunction(MachineFunction &MF) override;
|
|
|
|
MachineFunctionProperties getRequiredProperties() const override {
|
|
return MachineFunctionProperties().set(
|
|
MachineFunctionProperties::Property::NoVRegs);
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
AU.setPreservesCFG();
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
|
|
private:
|
|
LDVImpl *TheImpl;
|
|
TargetPassConfig *TPC;
|
|
};
|
|
|
|
char LiveDebugValues::ID = 0;
|
|
|
|
char &llvm::LiveDebugValuesID = LiveDebugValues::ID;
|
|
|
|
INITIALIZE_PASS(LiveDebugValues, DEBUG_TYPE, "Live DEBUG_VALUE analysis", false,
|
|
false)
|
|
|
|
/// Default construct and initialize the pass.
|
|
LiveDebugValues::LiveDebugValues() : MachineFunctionPass(ID) {
|
|
initializeLiveDebugValuesPass(*PassRegistry::getPassRegistry());
|
|
TheImpl = nullptr;
|
|
}
|
|
|
|
bool LiveDebugValues::runOnMachineFunction(MachineFunction &MF) {
|
|
if (!TheImpl) {
|
|
TPC = getAnalysisIfAvailable<TargetPassConfig>();
|
|
|
|
bool InstrRefBased = false;
|
|
if (TPC) {
|
|
auto &TM = TPC->getTM<TargetMachine>();
|
|
InstrRefBased = TM.Options.ValueTrackingVariableLocations;
|
|
}
|
|
|
|
// Allow the user to force selection of InstrRef LDV.
|
|
InstrRefBased |= ForceInstrRefLDV;
|
|
|
|
if (InstrRefBased)
|
|
TheImpl = llvm::makeInstrRefBasedLiveDebugValues();
|
|
else
|
|
TheImpl = llvm::makeVarLocBasedLiveDebugValues();
|
|
}
|
|
|
|
return TheImpl->ExtendRanges(MF, TPC, InputBBLimit, InputDbgValueLimit);
|
|
}
|